From patchwork Mon Jun 24 14:23:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Remus X-Patchwork-Id: 57147 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 715643846094 for ; Mon, 24 Jun 2024 22:05:15 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 60E5D384AB52 for ; Mon, 24 Jun 2024 22:04:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60E5D384AB52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 60E5D384AB52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719266688; cv=none; b=HjnOETygFB4cpz3WaNdZ/R9hT/cZ8DfbcF9TbyGC4WzqWFT/biNlOB8ky82TyQBHNNPWgkj7YjR4d1iLlyHcOrE+0wsk7b0qWi3ZWmso4TV9KSpSRaoRLTf4TddZ3YXfHlX2zwjGo9jeHIbDBxv6DTAhPOZW0NmNk8UqjlPPvqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719266688; c=relaxed/simple; bh=3cnOVnUcm1iJRYOa+yJ0tfpXNorptkFiAMh+Yawk99Q=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=jLG0iuTC+Q4cu+pZJ4kXUaxQdr8NUGnhwAVbG1O4Lr/CY4ebcJtgvY2c88Eh7sTQHd/+4RTcc+CRyjqNTltsNNxzkNwxFj3jV7edjm/NYC0bX1zx4bejfp8/4fXbbJGb3To6L3KvkPIIP1J984300ALwIr4aKvdYPx+6aqgZqng= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45ODuqU8007161; Mon, 24 Jun 2024 14:27:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=pp1; bh=qulJHFvu9A2Fqv5IolCnFxXNLR 2xJC/7xxNlQUMppvk=; b=hVO5V8+qr21TJzcwu5+QsfmxfD9VdVmkC6IMF5bnbe UNsIvwQucPGA6r3Psi8f3rN7lj+l/K8XIiCoI+GNNNX4sptX1n6QQ9c379oc+Amp heFWo6xYAWQ+nhGmr2l9t8FQIfzgxxuALwl7lyVo6h3lL5rDRSeclc0lgSds6SPZ zsxZSLa5HJrewnxvIgIiCIoGR9yzBYFg3dQZ7kL681y4iRP0ohibi7afk5Fi7X/E cJEF+caIuspDugs/7xEvnw3Re8bQvNe5ozs0QVotudUmToOl2jhDvRPjIjEiey5A RrsdU48Gl+tv5njL0kFWdsrTVrr9kaP8j/e4qJWsWIsg== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yy7ha8jce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jun 2024 14:27:46 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45OEFGSR000411; Mon, 24 Jun 2024 14:23:42 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3yxbn30tkk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jun 2024 14:23:42 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45OENbjK53084418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Jun 2024 14:23:39 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33AC72004B; Mon, 24 Jun 2024 14:23:37 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1BF2120040; Mon, 24 Jun 2024 14:23:37 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 24 Jun 2024 14:23:37 +0000 (GMT) From: Jens Remus To: binutils@sourceware.org, Indu Bhagat Cc: Jens Remus , Andreas Krebbel Subject: [PATCH v4 00/15] sframe: Enhancements to SFrame info generation Date: Mon, 24 Jun 2024 16:23:19 +0200 Message-Id: <20240624142334.3283823-1-jremus@linux.ibm.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: rwGCOeepczvZ_U8crHZ3tOZk7rW5dkm7 X-Proofpoint-ORIG-GUID: rwGCOeepczvZ_U8crHZ3tOZk7rW5dkm7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-24_11,2024-06-24_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 bulkscore=0 malwarescore=0 adultscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 spamscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2406240115 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Patches 1 and 2 (updated) are minor cleanups/enhancements to the existing SFrame support on AArch64 and x86 AMD64. Patch 3 enables readelf/objdump to dump the SFrame fixed offsets from CFA to the frame pointer (FP) and return address (RA). Patch 4 changes readelf/objdump to display 'f' in the SFrame RA tracking column, if the architecture is using a fixed RA offset. Additionally it corrects the logic to display 'u' in the SFrame FP tracking column. Patch 5 (updated) enhances an SFrame warning message to print the human readable DWARF call frame instruction name. Patches 6 and 7 resolve issues that cause the assembler to either generate bad SFrame FDE or to silently skip it. Both issues would be triggered by s390-specific SFrame error test cases introduced by the separate patch series. Patch 8 refactors SFrame CFI opcode DW_CFA_register processing into a separate function. This harmonizes the CFI opcode processing. Patch 9 (updated) adds verbose assembler warning messages when generation of SFrame FDE is skipped. Patch 10 (updated) resolves an issue that causes the assembler to generate bad SFrame FDE in case the FP without RA was saved on the stack, which the SFrame format cannot represent. I will send two alternative solution proposals as RFC. Patch 11 (updated) skips SFrame FDE for .cfi_window_save on all architectures except AArch64, which multiplexed it with .cfi_negate_ra_state. Patches 12 and 13 (updated) resolve issues where generation of SFrame FDE was unnecessarily skipped. Patch 14 adds tests for the SFrame RA tracking predicate to places where it was missing to align the logic. Patch 15 (updated) is a minor enhancement to add checks that the architecture-dependent RA tracking is correctly configured. Changes v3 -> v4: - Removed dash in terms "stack pointer", "frame pointer", and "return address" as requested by Indu. - Use terse warning message texts as suggested by Indu. - use proper DWARF terminology "CFI instruction" as suggested by Indu. - Fix bad indentation reported by GCC's check_GNU_style.py. - Dropped misleading comment "No errors encountered". as suggtested by Indu. - Add comment to sframe_xlate_do_offset why SP register is ignored. Changes v2 -> v3: - Additional patches as noted in cover letter and patch notes. - Reword further SFrame macro, variable, and function descriptions to align with those previously touched. - Align description of definition in source with declaration in header. - Updated gas synthesized CFI test cases for x86 AMD64 to test for architecture-specific fixed RA offset instead of using a pattern. - Updated ld SFrame test cases for x86 AMD64 to test for architecture- specific fixed RA offset. - Updated SFrame warning message texts as suggested by Indu, except for the .cfi_def_cfa[_register] ones. - Do not test sframe_ra_tracking_p when determining the SFrame register name in sframe_register_name. The RA register name does not depend on whether RA tracking is used or not. - Corrected formatting of ChangeLog in commit message. Changes v1 -> v2: - Resolved a regression reported by Linaro-TCWG-CI on AArch64 in one of the generic ld SFrame test cases. The test case contained a .cfi_def_cfa directive, specifying a CFA base register number that is not necessarily a SFrame SP/FP register number on all architectures. This caused the changes from patch 6 to skip SFrame FDE generation on AArch64 (and s390x aswell) with a warning, causing the test case to fail. Thanks and regards, Jens Jens Remus (15): x86: Remove unused SFrame CFI RA register variable gas: Enhance arch-specific SFrame configuration descriptions readelf/objdump: Dump SFrame CFA fixed FP and RA offsets readelf/objdump: Display SFrame fixed RA offset as 'f' in dump gas: Print DWARF call frame insn name in SFrame warning message gas: Skip SFrame FDE if CFI specifies non-FP/SP base register gas: Warn if SFrame FDE is skipped due to non-default return column gas: Refactor SFrame CFI opcode DW_CFA_register processing gas: User readable warnings if SFrame FDE is not generated gas: Skip SFrame FDE if FP without RA on stack gas: Skip SFrame FDE if .cfi_window_save gas: Don't skip SFrame FDE if .cfi_register specifies RA w/o tracking gas: Don't skip SFrame FDE if .cfi_register specifies SP register gas: Test predicate whether SFrame RA tracking is used gas: Validate SFrame RA tracking and fixed RA offset gas/config/tc-aarch64.c | 6 +- gas/config/tc-aarch64.h | 12 +- gas/config/tc-i386.c | 6 +- gas/config/tc-i386.h | 10 +- gas/gen-sframe.c | 246 +++++++++++++++--- gas/gen-sframe.h | 2 + .../gas/cfi-sframe/cfi-sframe-common-1.d | 2 + .../gas/cfi-sframe/cfi-sframe-common-2.d | 2 + .../gas/cfi-sframe/cfi-sframe-common-3.d | 2 + .../gas/cfi-sframe/cfi-sframe-common-4.d | 6 +- .../gas/cfi-sframe/cfi-sframe-common-5.d | 6 +- .../gas/cfi-sframe/cfi-sframe-common-6.d | 6 +- .../gas/cfi-sframe/cfi-sframe-common-7.d | 6 +- .../gas/cfi-sframe/cfi-sframe-common-8.d | 4 +- .../gas/cfi-sframe/cfi-sframe-x86_64-1.d | 9 +- gas/testsuite/gas/cfi-sframe/common-empty-1.d | 4 +- gas/testsuite/gas/cfi-sframe/common-empty-2.d | 4 +- gas/testsuite/gas/cfi-sframe/common-empty-3.d | 3 + .../gas/scfi/x86_64/scfi-cfi-sections-1.d | 11 +- .../gas/scfi/x86_64/scfi-dyn-stack-1.d | 11 +- ld/testsuite/ld-sframe/discard.s | 1 - ld/testsuite/ld-x86-64/sframe-plt-1.d | 9 +- ld/testsuite/ld-x86-64/sframe-simple-1.d | 17 +- libsframe/sframe-dump.c | 18 +- 24 files changed, 305 insertions(+), 98 deletions(-)