From patchwork Fri Dec 8 16:03:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Remus X-Patchwork-Id: 56484 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A903C3857C75 for ; Fri, 8 Dec 2023 16:04:33 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3F70D3858CDB for ; Fri, 8 Dec 2023 16:03:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F70D3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3F70D3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702051425; cv=none; b=Ymiu+xO+RY0ss3mh0PcZTdshaIJCG7RfEMoz7qVK++GeckaPYyPEyS82xjP8fWzFPk9gFTl41DYo736sP0wYKWyLbumSIayzCucx+JuzzD8ERNN9zSYN1DrKF8tTVIvxGzpLJ0l97KemnKDH7kGfui+Rv117EFst6e0wSWzFZqg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702051425; c=relaxed/simple; bh=aZHu8Ame8vrHhRzXrFQRcD4t07ADHCPlxgDrZn2UKS0=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=e4LaI0M4yQdEOnWCsc/6kLX3Xj0pNfV0oUZXC8c144Yl4v9G7mbeXNc+hJKN5aJm6TI8wI76rmd0cIjBdIrEJ+y4XkhkKzJ62qPd969EvvDDiJnkLl/1x6FPeG4N089600th0he1e+Jmry3AGDDfgpuvXv0qiPkArg+2f6WaRsY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B8Fv1Gi028342 for ; Fri, 8 Dec 2023 16:03:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=zbaJk4kWt7BkKt5GXMtZ/UFhwIdIm7Z+SRlJfRXZeAQ=; b=d4RyGuswyPppNv/K3/22L3Fiid2b4wvhqB1crvwPkPrIqSFTqhW7/B7w0xHRv3G7btp2 /3n0hOHW+RrgQCCUetrVMpiOx56XQPgIaAjNelnFKu0SUOqKvU/tO+kT/BdwLB1Lsb56 O4EJoFgkP6pVY3SkB6W273+y4+WNzbJXZy77YP+1JzTFOxv3MIwdloYnym2OfYuxb0p3 JxXLA0tMXTBBW6lvLGYr0ApQRfYNm7U5H8pTmn3k0GLJIJpY2bfZnwdzIHkVoSETo6ip xiXFkyRxpubUdha9ZTr8c4uM+6lhJk6Oq5u+r0D7Z7HGV8MYfjSDxbSdrs2iFVDlYeuj dg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uv67wg7h8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 08 Dec 2023 16:03:38 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3B8Fv7A2028553 for ; Fri, 8 Dec 2023 16:03:38 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uv67wg7gs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Dec 2023 16:03:38 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3B8DPkYS028462; Fri, 8 Dec 2023 16:03:37 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3utavk2f4e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Dec 2023 16:03:36 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3B8G3Xef16908688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Dec 2023 16:03:33 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A04E520043; Fri, 8 Dec 2023 16:03:33 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7D15520040; Fri, 8 Dec 2023 16:03:33 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 8 Dec 2023 16:03:33 +0000 (GMT) From: Jens Remus To: binutils@sourceware.org Cc: Jens Remus , Andreas Krebbel , Nick Clifton Subject: [PATCH 0/2] s390: Optionally print instruction description in disassembly Date: Fri, 8 Dec 2023 17:03:28 +0100 Message-Id: <20231208160330.1387610-1-jremus@linux.ibm.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: XccvQzz_-Jhf0v2CAq1uF2f8K60b3bn8 X-Proofpoint-ORIG-GUID: UPPOnuZdRVWV3MArurGbATfBHgwXCtir X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-08_11,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 spamscore=0 adultscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=484 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312080132 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org With this patch series the s390 disassembler optionally prints the instruction descriptions as comment in the disassembly. This is enabled by specifying the new s390-specific disassembler option "insndesc". Patch 1 is a cleanup in the s390-mkopc build, that I stumbled upon. Patch 2 allows to optionally print the instruction descriptions as comments using s390-specific disassembler option "insndesc". Example output: $ objdump -d -M insndesc test ... 0000000000000620 : 620: c0 10 00 00 0d 5c larl %r1,20d8 <__TMC_END__> # load address relative long 626: c0 20 00 00 0d 59 larl %r2,20d8 <__TMC_END__> # load address relative long 62c: ec 12 00 0a 80 64 cgrje %r1,%r2,640 # compare and branch relative (64) 632: c4 18 00 00 0c d7 lgrl %r1,1fe0 <_ITM_deregisterTMCloneTable@Base> # load relative long (64) 638: ec 18 00 04 00 7c cgije %r1,0,640 # compare immediate and branch relative (64<8) 63e: 07 f1 br %r1 # unconditional branch 640: 07 fe br %r14 # unconditional branch Note that the readability can be enhanced by using a filter such as "expand": $ objdump -d -M insndesc test | expand -t 8,16,24,32,40,80 ... 0000000000000620 : 620: c0 10 00 00 0d 5c larl %r1,20d8 <__TMC_END__> # load address relative long 626: c0 20 00 00 0d 59 larl %r2,20d8 <__TMC_END__> # load address relative long 62c: ec 12 00 0a 80 64 cgrje %r1,%r2,640 # compare and branch relative (64) 632: c4 18 00 00 0c d7 lgrl %r1,1fe0 <_ITM_deregisterTMCloneTable@Base> # load relative long (64) 638: ec 18 00 04 00 7c cgije %r1,0,640 # compare immediate and branch relative (64<8) 63e: 07 f1 br %r1 # unconditional branch 640: 07 fe br %r14 # unconditional branch Regards, Jens Jens Remus (2): s390: Fix build when using EXEEXT_FOR_BUILD s390: Optionally print instruction description in disassembly binutils/NEWS | 5 ++++ include/opcode/s390.h | 5 +++- opcodes/Makefile.am | 7 +++-- opcodes/Makefile.in | 7 +++-- opcodes/s390-dis.c | 13 ++++++++- opcodes/s390-mkopc.c | 18 ++++++++----- opcodes/s390-opc.c | 62 +++++++++++++++++++++---------------------- 7 files changed, 73 insertions(+), 44 deletions(-)