[gdb/testsuite] Fix xpass in gdb.python/lib-types.exp
Commit Message
Hi,
When running gdb.python/lib-types.exp, we have an xpass:
...
(gdb) python print (str (typedef_const_typedef_class1_ref_obj.type))^M
typedef_const_typedef_class1_ref^M
(gdb) XPASS: gdb.python/lib-types.exp: \
python print (str (typedef_const_typedef_class1_ref_obj.type)) \
(PRMS gcc/55641)
...
When running the same with gcc 4.8, we have an xfail instead:
...
(gdb) python print (str (typedef_const_typedef_class1_ref_obj.type))^M
const typedef_const_typedef_class1_ref^M
(gdb) XFAIL: gdb.python/lib-types.exp: \
python print (str (typedef_const_typedef_class1_ref_obj.type)) \
(PRMS gcc/55641)
...
It's incorrect to xfail a gdb test-case for gcc bug.
Marking the test unsupported for older gcc instead is not necessary either:
it's just that gdb prints different output when given different input, which
is entirely expected behaviour.
Fix this by passing for both patterns.
Tested on x86_64-linux, with:
- gcc 7.5.0
- gcc 4.8.5
- clang 5.0.2
OK for trunk?
Thanks,
- Tom
[gdb/testsuite] Fix xpass in gdb.python/lib-types.exp
gdb/testsuite/ChangeLog:
2020-02-19 Tom de Vries <tdevries@suse.de>
* gdb.python/lib-types.exp: Remove gcc/55641 xfail.
---
gdb/testsuite/gdb.python/lib-types.exp | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
Comments
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> It's incorrect to xfail a gdb test-case for gcc bug.
I think we've used "kfail" for this in the past, though TBH I never
truly understood the kfail/xfail distinction and I probably have it
backward or something.
Tom> 2020-02-19 Tom de Vries <tdevries@suse.de>
Tom> * gdb.python/lib-types.exp: Remove gcc/55641 xfail.
This is ok. Thank you.
Tom
@@ -103,8 +103,15 @@ gdb_test_multiple "python print (str (basic_type_typedef_const_typedef_class1_ob
# test nested typedef/reference stripping
gdb_test_no_output "python typedef_const_typedef_class1_ref_obj = gdb.parse_and_eval ('typedef_const_typedef_class1_ref_obj')"
gdb_test_no_output "python basic_type_typedef_const_typedef_class1_ref_obj = gdb.types.get_basic_type (typedef_const_typedef_class1_ref_obj.type)"
-if {[test_compiler_info {gcc-*-*}]} { setup_xfail gcc/55641 *-*-* }
-gdb_test "python print (str (typedef_const_typedef_class1_ref_obj.type))" "\[\r\n\]+typedef_const_typedef_class1_ref"
+gdb_test_multiple "python print (str (typedef_const_typedef_class1_ref_obj.type))" "" {
+ -re -wrap "\[\r\n\]+const typedef_const_typedef_class1_ref" {
+ # Compiler with PR gcc/55641.
+ pass $gdb_test_name
+ }
+ -re -wrap "\[\r\n\]+typedef_const_typedef_class1_ref" {
+ pass $gdb_test_name
+ }
+}
set test "nested typedef/ref stripping"
gdb_test_multiple "python print (str (basic_type_typedef_const_typedef_class1_ref_obj))" $test {
-re "\[\r\n\]+class1\[\r\n\]+$gdb_prompt $" {