Message ID | 4d5a1276-91aa-7197-5f90-854767987f73@suse.de |
---|---|
State | New, archived |
Headers |
Received: (qmail 80844 invoked by alias); 9 Feb 2020 14:17:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 80835 invoked by uid 89); 9 Feb 2020 14:17:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Feb 2020 14:17:28 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D6EEFAC35; Sun, 9 Feb 2020 14:17:25 +0000 (UTC) Subject: Re: [PATCH] Move gdbserver to top level From: Tom de Vries <tdevries@suse.de> To: Tom Tromey <tom@tromey.com> Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org References: <87d0bf45up.fsf@tromey.com> <7ceebbb7-b2f7-3d4a-1d8a-f31310badbe8@redhat.com> <874kwk8nz9.fsf@tromey.com> <171a3144-af37-1c29-a2a4-c4cd7eaa14c0@redhat.com> <87r1zm6x8s.fsf@tromey.com> <01b4b5ca-a802-54b5-3135-428b7c9faa84@redhat.com> <87o8uo4mj0.fsf@tromey.com> <87blqfn0d6.fsf@tromey.com> <0b6b4f24-f5c8-b236-c249-737e70395667@suse.de> Message-ID: <4d5a1276-91aa-7197-5f90-854767987f73@suse.de> Date: Sun, 9 Feb 2020 15:17:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <0b6b4f24-f5c8-b236-c249-737e70395667@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes |
Commit Message
Tom de Vries
Feb. 9, 2020, 2:17 p.m. UTC
On 09-02-2020 14:59, Tom de Vries wrote: > On 03-02-2020 22:34, Tom Tromey wrote: >> I'm going to push it tomorrow or the day after, unless there's some >> objection. > > Hi, > > FYI, starting this commit, I'm running into: > ... > (gdb) PASS: gdb.multi/multi-target.exp: continue: non-stop=off: set > remote-exec file in inferior 2 > spawn of --once --multi localhost:2346 failed > ERROR: tcl error sourcing > /data/gdb_versions/devel/src/gdb/testsuite/gdb.multi/multi-target.exp. > ERROR: Timeout waiting for gdbserver response. Looking at other tests that use gdbserver, I guess this is missing: ... ... [ It would be nice though if the gdbserver tests will work again, given that I'm actually building gdbserver. ] Thanks, - Tom
Comments
On 09-02-2020 15:17, Tom de Vries wrote: > [ It would be nice though if the gdbserver tests will work again, given > that I'm actually building gdbserver. ] Hmm, I noticed that also on the buildbot ( https://sourceware.org/ml/gdb-testers/2020-q1/msg03282.html ) we no longer run the gdb.server tests: ... Running /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/abspath.exp ... testcase /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/abspath.exp completed in 0 seconds Running /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/bkpt-other-inferior.exp ... testcase /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/bkpt-other-inferior.exp completed in 0 seconds Running /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/connect-stopped-target.exp ... testcase /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/connect-stopped-target.exp completed in 0 seconds ... Thanks, - Tom
On Monday, February 10 2020, Tom de Vries wrote: > On 09-02-2020 15:17, Tom de Vries wrote: >> [ It would be nice though if the gdbserver tests will work again, given >> that I'm actually building gdbserver. ] > > Hmm, I noticed that also on the buildbot ( > https://sourceware.org/ml/gdb-testers/2020-q1/msg03282.html ) we no > longer run the gdb.server tests: > ... > Running > /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/abspath.exp > ... > testcase > /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/abspath.exp > completed in 0 seconds > > Running > /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/bkpt-other-inferior.exp > ... > testcase > /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/bkpt-other-inferior.exp > completed in 0 seconds > > Running > /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/connect-stopped-target.exp > ... > testcase > /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/connect-stopped-target.exp > completed in 0 seconds > ... I wonder why... We build GDB from scratch on every build. Is there anything special that needs to be done to run the gdbserver tests now?
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> I wonder why... We build GDB from scratch on every build. Is there
Sergio> anything special that needs to be done to run the gdbserver tests now?
No, I just neglected to update the gdb test suite to find gdbserver in
the new spot.
I will send a patch momentarily.
Tom
On Tuesday, February 11 2020, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes: > > Sergio> I wonder why... We build GDB from scratch on every build. Is there > Sergio> anything special that needs to be done to run the gdbserver tests now? > > No, I just neglected to update the gdb test suite to find gdbserver in > the new spot. > > I will send a patch momentarily. Thanks, Tom.
diff --git a/gdb/testsuite/gdb.multi/multi-target.exp b/gdb/testsuite/gdb.multi/multi-target.exp index 3588eb4d76..6c727b5e3b 100644 --- a/gdb/testsuite/gdb.multi/multi-target.exp +++ b/gdb/testsuite/gdb.multi/multi-target.exp @@ -17,6 +17,10 @@ load_lib gdbserver-support.exp +if { [skip_gdbserver_tests] } { + return 0 +} + standard_testfile # The plain remote target can't do multiple inferiors.