[1/6] New proc _handle_attribute
Commit Message
This patch is to move some code to a new procedure _handle_attribute,
which will be used in my following patches.
gdb/testsuite:
2014-10-24 Yao Qi <yao@codesourcery.com>
* lib/dwarf.exp (_handle_DW_TAG): Move some code to ...
(_handle_attribute): New procedure.
---
gdb/testsuite/lib/dwarf.exp | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
Comments
Yao Qi writes:
> This patch is to move some code to a new procedure _handle_attribute,
> which will be used in my following patches.
>
> gdb/testsuite:
>
> 2014-10-24 Yao Qi <yao@codesourcery.com>
>
> * lib/dwarf.exp (_handle_DW_TAG): Move some code to ...
> (_handle_attribute): New procedure.
LGTM
@@ -461,6 +461,18 @@ namespace eval Dwarf {
return $name
}
+ proc _handle_attribute { attr_name attr_value attr_form } {
+ variable _abbrev_section
+ variable _constants
+
+ _handle_DW_FORM $attr_form $attr_value
+
+ _defer_output $_abbrev_section {
+ _op .uleb128 $_constants($attr_name) $attr_name
+ _op .uleb128 $_constants($attr_form) $attr_form
+ }
+ }
+
proc _handle_DW_TAG {tag_name {attrs {}} {children {}}} {
variable _abbrev_section
variable _abbrev_num
@@ -489,12 +501,7 @@ namespace eval Dwarf {
}
set attr_form [_map_name $attr_form _FORM]
- _handle_DW_FORM $attr_form $attr_value
-
- _defer_output $_abbrev_section {
- _op .uleb128 $_constants($attr_name) $attr_name
- _op .uleb128 $_constants($attr_form) $attr_form
- }
+ _handle_attribute $attr_name $attr_value $attr_form
}
_defer_output $_abbrev_section {