gdb: small cleanup in breakpoint.c's includes
Commit Message
In an attempt to reduce the number of files re-build when some headers
are touched, I ran include-what-you-use with breakpoint.c as a guinea
pig. It revealed a few files that were unnecessary to include, which
this patch removes.
breakpoint.c uses tilde_expand from readline, hence the necessity to
include tilde.h. AFAIK, it's fine to include just that, and not the
whole readline headers.
include-what-you-use also reported many header files that should be
included but aren't, I suppose that breakpoint.c currently includes them
indirectly. For now I'll pretend I didn't see that :).
gdb/ChangeLog:
* breakpoint.c: Remove some includes: continuations.h, skip.h,
mi/mi-main.h, readline/readline.h, readline/history.h. Add
include: readline/tilde.h.
-#include "skip.h"
#include "ax-gdb.h"
#include "dummy-frame.h"
#include "interps.h"
@@ -69,11 +67,9 @@
#include "thread-fsm.h"
#include "tid-parse.h"
#include "cli/cli-style.h"
-#include "mi/mi-main.h"
/* readline include files */
-#include "readline/readline.h"
-#include "readline/history.h"
+#include "readline/tilde.h"
/* readline defines this. */
#undef savestring
---
gdb/breakpoint.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
Comments
On 2019-09-21 9:40 p.m., Simon Marchi wrote:
> In an attempt to reduce the number of files re-build when some headers
> are touched, I ran include-what-you-use with breakpoint.c as a guinea
> pig. It revealed a few files that were unnecessary to include, which
> this patch removes.
>
> breakpoint.c uses tilde_expand from readline, hence the necessity to
> include tilde.h. AFAIK, it's fine to include just that, and not the
> whole readline headers.
>
> include-what-you-use also reported many header files that should be
> included but aren't, I suppose that breakpoint.c currently includes them
> indirectly. For now I'll pretend I didn't see that :).
>
> gdb/ChangeLog:
>
> * breakpoint.c: Remove some includes: continuations.h, skip.h,
> mi/mi-main.h, readline/readline.h, readline/history.h. Add
> include: readline/tilde.h.
I pushed this.
Simon
@@ -59,9 +59,7 @@
#include "gdb_regex.h"
#include "probe.h"
#include "cli/cli-utils.h"
-#include "continuations.h"
#include "stack.h"
-#include "skip.h"
#include "ax-gdb.h"
#include "dummy-frame.h"
#include "interps.h"
@@ -69,11 +67,9 @@
#include "thread-fsm.h"
#include "tid-parse.h"
#include "cli/cli-style.h"
-#include "mi/mi-main.h"
/* readline include files */
-#include "readline/readline.h"
-#include "readline/history.h"
+#include "readline/tilde.h"
/* readline defines this. */
#undef savestring