| Message ID | 470d2036c006c525b5dd78b4c7fb860ee521aafd.1565398514.git.alistair.francis@wdc.com |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 80009 invoked by alias); 10 Aug 2019 01:04:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 79921 invoked by uid 89); 10 Aug 2019 01:04:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: esa3.hgst.iphmx.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1565399055; x=1596935055; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Q1cupIoxLi+OKY7uNLHdGNN+fPHgDFUTJku3zJfavAg=; b=a2MAZt74ygWFgHnsAb9j0132R2DI2xtNWfyAi6vtCfF80X+WO293NYtT U/6v3wn+PQGNu4Wzc97MNDAAyug9Ta13mJ0Vlh3OSqeTBCeFphj2ynu+u c4atour1SfsWgBvT84+IaZC2bTWbRCNivQhpjoqVC0yPb6fCtItQLqx34 j2q4WR+3uIUwLUIxM7cF8fRdFW5Y6HbJMSgnYJrN/5/ZLcHo4URw3y0gY OGkJuqV6LiJ2LkBHdliAU4KeeWl1WJ4qiZnfGUK/rFepAsaMyCywaqQq5 TvCgPaYp0DM2h2+0JbpD6mVdmzyVqEf1+0/FXB7aL2RS6qAUuwssZSk5C g==; IronPort-SDR: wqrrOflu46JBRTF2edIUfPz7yyXOUrsmZ1dDwTmKyYX/4Bjt4m36MMNffH30lAw4wVDTr+t26n vRPPqrjxvSiC1zRILUkm+DW54o6U+xdkuIuGBREkaouo6oWlzyljlIz+1jVqBR3ftGCFCJeLsP n1Q8SEovY/rEOMvjh2dpdKPrVf4odp4jd6ad/ZiidO1RocswvNt6NShh2khcvBXhjl3iWkGCv8 0dw/vR+ILwgI8hOYCfHww4vFvjiFwvtfBYujdW+cecsLB25gttbvgKNgJMDBuM1WNcKevcASDH oOg= IronPort-SDR: RzBu5I7JLyncamABcXu3FHmBREyT8VwrWG0WYPZbK0k6oOWydxJf9RzIL9ucsAXSi/DA0VKmRq IVX2laBDqQJQh0HRzvqb77jkKx4vOB79mXTHwzNboGkNh5misuLHcgLuKay7hbY6CtGFx4mDDT t8+vhHsZlUkIFyBgF7+q37eLRYmHPTpIksxhDsNFMHq7pf9wR5oqGfVoQtun566PyjmCG6F7i3 n0715sRDrpfDuL41xkmHHGuTB1NCSTswimXwNxM7KR6bm6jv3x+3PSPjHaRi8IcUhMbqJO7uix BLNuiObgKrylsQWvNYxZuTyV IronPort-SDR: heGjh+rBQwh63xlIRehdUIXzktVLwP/CuDNyycb7yfWytzkcULM495FmwcvoL5iYnMorKMnyXK KiKuNJuNeOwB649CFHXMvRWNgrdlP0PsryeoXxzJHz2vh5iWJkXQWI3+a9BS9/XmpGLuyxjzSm LK+LudAQJhFO920OD0sBgN8ugU1g1/1sGvwedwcuVT75MLcsC5AjfEvw5dhVyTsNk98km6d7Hd a6VVDcvEsTMrsfI61W1Mauzwarfw8db29TR9lEOTdfIDl8z4Afys0yg44m5ywFsJfhg4bYsgbK Oso= From: Alistair Francis <alistair.francis@wdc.com> To: libc-alpha@sourceware.org Cc: arnd@arndb.de, adhemerval.zanella@linaro.org, fweimer@redhat.com, palmer@sifive.com, macro@wdc.com, zongbox@gmail.com, alistair.francis@wdc.com, alistair23@gmail.com Subject: [RFC v4 23/24] WIP: syscall.list: Call 64-bit versions of syscalls Date: Fri, 9 Aug 2019 18:00:53 -0700 Message-Id: <470d2036c006c525b5dd78b4c7fb860ee521aafd.1565398514.git.alistair.francis@wdc.com> In-Reply-To: <cover.1565398513.git.alistair.francis@wdc.com> References: <cover.1565398513.git.alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit |
Commit Message
Alistair Francis
Aug. 10, 2019, 1 a.m. UTC
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
sysdeps/unix/sysv/linux/syscalls.list | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
On Fri, Aug 9, 2019 at 6:04 PM Alistair Francis <alistair.francis@wdc.com> wrote: > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com> > --- > sysdeps/unix/sysv/linux/syscalls.list | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list > index e374f97b5f8..4844d1a9a3b 100644 > --- a/sysdeps/unix/sysv/linux/syscalls.list > +++ b/sysdeps/unix/sysv/linux/syscalls.list > @@ -5,7 +5,7 @@ alarm - alarm i:i alarm > bdflush EXTRA bdflush i:ii __compat_bdflush bdflush@GLIBC_2.0:GLIBC_2.23 > capget EXTRA capget i:pp capget > capset EXTRA capset i:pp capset > -clock_adjtime EXTRA clock_adjtime i:ip clock_adjtime > +clock_adjtime EXTRA clock_adjtime64 i:ip clock_adjtime > create_module EXTRA create_module 3 __compat_create_module create_module@GLIBC_2.0:GLIBC_2.23 > delete_module EXTRA delete_module 3 delete_module > epoll_create EXTRA epoll_create i:i epoll_create > @@ -52,7 +52,7 @@ sched_getp - sched_getparam i:ip __sched_getparam sched_getparam > sched_gets - sched_getscheduler i:i __sched_getscheduler sched_getscheduler > sched_primax - sched_get_priority_max i:i __sched_get_priority_max sched_get_priority_max > sched_primin - sched_get_priority_min i:i __sched_get_priority_min sched_get_priority_min > -sched_rr_gi - sched_rr_get_interval i:ip __sched_rr_get_interval sched_rr_get_interval > +sched_rr_gi - sched_rr_get_interval_time64 i:ip __sched_rr_get_interval sched_rr_get_interval > sched_setp - sched_setparam i:ip __sched_setparam sched_setparam > sched_sets - sched_setscheduler i:iip __sched_setscheduler sched_setscheduler > sched_yield - sched_yield i: __sched_yield sched_yield > @@ -96,8 +96,8 @@ fremovexattr - fremovexattr i:is fremovexattr > mq_setattr - mq_getsetattr i:ipp mq_setattr > > timerfd_create EXTRA timerfd_create i:ii timerfd_create > -timerfd_settime EXTRA timerfd_settime i:iipp timerfd_settime > -timerfd_gettime EXTRA timerfd_gettime i:ip timerfd_gettime > +timerfd_settime EXTRA timerfd_settime64 i:iipp timerfd_settime > +timerfd_gettime EXTRA timerfd_gettime64 i:ip timerfd_gettime Does anyone have ideas/opinions on how to handle this correctly? Alistair > > fanotify_init EXTRA fanotify_init i:ii fanotify_init > > -- > 2.22.0 >
* Alistair Francis: > On Fri, Aug 9, 2019 at 6:04 PM Alistair Francis > <alistair.francis@wdc.com> wrote: >> >> Signed-off-by: Alistair Francis <alistair.francis@wdc.com> >> --- >> sysdeps/unix/sysv/linux/syscalls.list | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list >> index e374f97b5f8..4844d1a9a3b 100644 >> --- a/sysdeps/unix/sysv/linux/syscalls.list >> +++ b/sysdeps/unix/sysv/linux/syscalls.list >> @@ -5,7 +5,7 @@ alarm - alarm i:i alarm >> bdflush EXTRA bdflush i:ii __compat_bdflush bdflush@GLIBC_2.0:GLIBC_2.23 >> capget EXTRA capget i:pp capget >> capset EXTRA capset i:pp capset >> -clock_adjtime EXTRA clock_adjtime i:ip clock_adjtime >> +clock_adjtime EXTRA clock_adjtime64 i:ip clock_adjtime >> create_module EXTRA create_module 3 __compat_create_module create_module@GLIBC_2.0:GLIBC_2.23 >> delete_module EXTRA delete_module 3 delete_module >> epoll_create EXTRA epoll_create i:i epoll_create >> @@ -52,7 +52,7 @@ sched_getp - sched_getparam i:ip __sched_getparam sched_getparam >> sched_gets - sched_getscheduler i:i __sched_getscheduler sched_getscheduler >> sched_primax - sched_get_priority_max i:i __sched_get_priority_max sched_get_priority_max >> sched_primin - sched_get_priority_min i:i __sched_get_priority_min sched_get_priority_min >> -sched_rr_gi - sched_rr_get_interval i:ip __sched_rr_get_interval sched_rr_get_interval >> +sched_rr_gi - sched_rr_get_interval_time64 i:ip __sched_rr_get_interval sched_rr_get_interval >> sched_setp - sched_setparam i:ip __sched_setparam sched_setparam >> sched_sets - sched_setscheduler i:iip __sched_setscheduler sched_setscheduler >> sched_yield - sched_yield i: __sched_yield sched_yield >> @@ -96,8 +96,8 @@ fremovexattr - fremovexattr i:is fremovexattr >> mq_setattr - mq_getsetattr i:ipp mq_setattr >> >> timerfd_create EXTRA timerfd_create i:ii timerfd_create >> -timerfd_settime EXTRA timerfd_settime i:iipp timerfd_settime >> -timerfd_gettime EXTRA timerfd_gettime i:ip timerfd_gettime >> +timerfd_settime EXTRA timerfd_settime64 i:iipp timerfd_settime >> +timerfd_gettime EXTRA timerfd_gettime64 i:ip timerfd_gettime > > Does anyone have ideas/opinions on how to handle this correctly? As in many of the other cases, you can add this to <sysdep.h>: #define __NR_timerfd_settime __NR_timerfd_settime64 #define __NR_timerfd_gettime __NR_timerfd_gettime64 Once a second such port arrives, we can factor out these common system call renamings into a generic-64 subdirectory. I still think it's just wrong that the kernel doesn't provide these names as part of the UAPI headers. Thanks, Florian
On Wed, Aug 14, 2019 at 11:57 AM Florian Weimer <fweimer@redhat.com> wrote: > > * Alistair Francis: > > > On Fri, Aug 9, 2019 at 6:04 PM Alistair Francis > > <alistair.francis@wdc.com> wrote: > >> > >> Signed-off-by: Alistair Francis <alistair.francis@wdc.com> > >> --- > >> sysdeps/unix/sysv/linux/syscalls.list | 8 ++++---- > >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> > >> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list > >> index e374f97b5f8..4844d1a9a3b 100644 > >> --- a/sysdeps/unix/sysv/linux/syscalls.list > >> +++ b/sysdeps/unix/sysv/linux/syscalls.list > >> @@ -5,7 +5,7 @@ alarm - alarm i:i alarm > >> bdflush EXTRA bdflush i:ii __compat_bdflush bdflush@GLIBC_2.0:GLIBC_2.23 > >> capget EXTRA capget i:pp capget > >> capset EXTRA capset i:pp capset > >> -clock_adjtime EXTRA clock_adjtime i:ip clock_adjtime > >> +clock_adjtime EXTRA clock_adjtime64 i:ip clock_adjtime > >> create_module EXTRA create_module 3 __compat_create_module create_module@GLIBC_2.0:GLIBC_2.23 > >> delete_module EXTRA delete_module 3 delete_module > >> epoll_create EXTRA epoll_create i:i epoll_create > >> @@ -52,7 +52,7 @@ sched_getp - sched_getparam i:ip __sched_getparam sched_getparam > >> sched_gets - sched_getscheduler i:i __sched_getscheduler sched_getscheduler > >> sched_primax - sched_get_priority_max i:i __sched_get_priority_max sched_get_priority_max > >> sched_primin - sched_get_priority_min i:i __sched_get_priority_min sched_get_priority_min > >> -sched_rr_gi - sched_rr_get_interval i:ip __sched_rr_get_interval sched_rr_get_interval > >> +sched_rr_gi - sched_rr_get_interval_time64 i:ip __sched_rr_get_interval sched_rr_get_interval > >> sched_setp - sched_setparam i:ip __sched_setparam sched_setparam > >> sched_sets - sched_setscheduler i:iip __sched_setscheduler sched_setscheduler > >> sched_yield - sched_yield i: __sched_yield sched_yield > >> @@ -96,8 +96,8 @@ fremovexattr - fremovexattr i:is fremovexattr > >> mq_setattr - mq_getsetattr i:ipp mq_setattr > >> > >> timerfd_create EXTRA timerfd_create i:ii timerfd_create > >> -timerfd_settime EXTRA timerfd_settime i:iipp timerfd_settime > >> -timerfd_gettime EXTRA timerfd_gettime i:ip timerfd_gettime > >> +timerfd_settime EXTRA timerfd_settime64 i:iipp timerfd_settime > >> +timerfd_gettime EXTRA timerfd_gettime64 i:ip timerfd_gettime > > > > Does anyone have ideas/opinions on how to handle this correctly? > > As in many of the other cases, you can add this to <sysdep.h>: > > #define __NR_timerfd_settime __NR_timerfd_settime64 > #define __NR_timerfd_gettime __NR_timerfd_gettime64 > > Once a second such port arrives, we can factor out these common system > call renamings into a generic-64 subdirectory. Great! That's a straightforward fix. Alistair > > I still think it's just wrong that the kernel doesn't provide these > names as part of the UAPI headers. > > Thanks, > Florian
* Alistair Francis: > On Wed, Aug 14, 2019 at 11:57 AM Florian Weimer <fweimer@redhat.com> wrote: >> >> * Alistair Francis: >> >> > On Fri, Aug 9, 2019 at 6:04 PM Alistair Francis >> > <alistair.francis@wdc.com> wrote: >> >> >> >> Signed-off-by: Alistair Francis <alistair.francis@wdc.com> >> >> --- >> >> sysdeps/unix/sysv/linux/syscalls.list | 8 ++++---- >> >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> >> >> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list >> >> index e374f97b5f8..4844d1a9a3b 100644 >> >> --- a/sysdeps/unix/sysv/linux/syscalls.list >> >> +++ b/sysdeps/unix/sysv/linux/syscalls.list >> >> @@ -5,7 +5,7 @@ alarm - alarm i:i alarm >> >> bdflush EXTRA bdflush i:ii __compat_bdflush bdflush@GLIBC_2.0:GLIBC_2.23 >> >> capget EXTRA capget i:pp capget >> >> capset EXTRA capset i:pp capset >> >> -clock_adjtime EXTRA clock_adjtime i:ip clock_adjtime >> >> +clock_adjtime EXTRA clock_adjtime64 i:ip clock_adjtime >> >> create_module EXTRA create_module 3 __compat_create_module create_module@GLIBC_2.0:GLIBC_2.23 >> >> delete_module EXTRA delete_module 3 delete_module >> >> epoll_create EXTRA epoll_create i:i epoll_create >> >> @@ -52,7 +52,7 @@ sched_getp - sched_getparam i:ip __sched_getparam sched_getparam >> >> sched_gets - sched_getscheduler i:i __sched_getscheduler sched_getscheduler >> >> sched_primax - sched_get_priority_max i:i __sched_get_priority_max sched_get_priority_max >> >> sched_primin - sched_get_priority_min i:i __sched_get_priority_min sched_get_priority_min >> >> -sched_rr_gi - sched_rr_get_interval i:ip __sched_rr_get_interval sched_rr_get_interval >> >> +sched_rr_gi - sched_rr_get_interval_time64 i:ip __sched_rr_get_interval sched_rr_get_interval >> >> sched_setp - sched_setparam i:ip __sched_setparam sched_setparam >> >> sched_sets - sched_setscheduler i:iip __sched_setscheduler sched_setscheduler >> >> sched_yield - sched_yield i: __sched_yield sched_yield >> >> @@ -96,8 +96,8 @@ fremovexattr - fremovexattr i:is fremovexattr >> >> mq_setattr - mq_getsetattr i:ipp mq_setattr >> >> >> >> timerfd_create EXTRA timerfd_create i:ii timerfd_create >> >> -timerfd_settime EXTRA timerfd_settime i:iipp timerfd_settime >> >> -timerfd_gettime EXTRA timerfd_gettime i:ip timerfd_gettime >> >> +timerfd_settime EXTRA timerfd_settime64 i:iipp timerfd_settime >> >> +timerfd_gettime EXTRA timerfd_gettime64 i:ip timerfd_gettime >> > >> > Does anyone have ideas/opinions on how to handle this correctly? >> >> As in many of the other cases, you can add this to <sysdep.h>: >> >> #define __NR_timerfd_settime __NR_timerfd_settime64 >> #define __NR_timerfd_gettime __NR_timerfd_gettime64 >> >> Once a second such port arrives, we can factor out these common system >> call renamings into a generic-64 subdirectory. > > Great! That's a straightforward fix. Note that getting this to work on legacy architectures (which have a 32-bit time_t) today obviously requires vastly different steps. I do not know if completing this work is a requirement for acceptance of the RV32 port (I don't think it should be, but others might disagree). Thanks, Florian
diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list index e374f97b5f8..4844d1a9a3b 100644 --- a/sysdeps/unix/sysv/linux/syscalls.list +++ b/sysdeps/unix/sysv/linux/syscalls.list @@ -5,7 +5,7 @@ alarm - alarm i:i alarm bdflush EXTRA bdflush i:ii __compat_bdflush bdflush@GLIBC_2.0:GLIBC_2.23 capget EXTRA capget i:pp capget capset EXTRA capset i:pp capset -clock_adjtime EXTRA clock_adjtime i:ip clock_adjtime +clock_adjtime EXTRA clock_adjtime64 i:ip clock_adjtime create_module EXTRA create_module 3 __compat_create_module create_module@GLIBC_2.0:GLIBC_2.23 delete_module EXTRA delete_module 3 delete_module epoll_create EXTRA epoll_create i:i epoll_create @@ -52,7 +52,7 @@ sched_getp - sched_getparam i:ip __sched_getparam sched_getparam sched_gets - sched_getscheduler i:i __sched_getscheduler sched_getscheduler sched_primax - sched_get_priority_max i:i __sched_get_priority_max sched_get_priority_max sched_primin - sched_get_priority_min i:i __sched_get_priority_min sched_get_priority_min -sched_rr_gi - sched_rr_get_interval i:ip __sched_rr_get_interval sched_rr_get_interval +sched_rr_gi - sched_rr_get_interval_time64 i:ip __sched_rr_get_interval sched_rr_get_interval sched_setp - sched_setparam i:ip __sched_setparam sched_setparam sched_sets - sched_setscheduler i:iip __sched_setscheduler sched_setscheduler sched_yield - sched_yield i: __sched_yield sched_yield @@ -96,8 +96,8 @@ fremovexattr - fremovexattr i:is fremovexattr mq_setattr - mq_getsetattr i:ipp mq_setattr timerfd_create EXTRA timerfd_create i:ii timerfd_create -timerfd_settime EXTRA timerfd_settime i:iipp timerfd_settime -timerfd_gettime EXTRA timerfd_gettime i:ip timerfd_gettime +timerfd_settime EXTRA timerfd_settime64 i:iipp timerfd_settime +timerfd_gettime EXTRA timerfd_gettime64 i:ip timerfd_gettime fanotify_init EXTRA fanotify_init i:ii fanotify_init