Message ID | 20190715101124.77677-1-alan.hayward@arm.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 90690 invoked by alias); 15 Jul 2019 10:11:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 90681 invoked by uid 89); 15 Jul 2019 10:11:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy=earliest, Changes, NEWS, H*RU:10a6 X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30055.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Jul 2019 10:11:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=faISdBXTfSVpveA/laRsj4R9qxtEJTcWVD3vOvpi12Y=; b=HR+3/M9VOU/dEziCUEkpjmdWj95pgVZK0ZNX3XfOtmFYBSa9ycSIz8VsOVXgnUS6ZTRAK7urB/S1dRCEUzsMRTWBgp2ACzeAk+fh9pXVYRHrs0tTNOnzx1zUcIgc6XjsF4NCdc7the/zx3lY+LaJ5sA2V6UMlLCeUBSIU1uoCKw= Received: from VI1PR08CA0190.eurprd08.prod.outlook.com (2603:10a6:800:d2::20) by AM0PR08MB4946.eurprd08.prod.outlook.com (2603:10a6:208:165::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Mon, 15 Jul 2019 10:11:37 +0000 Received: from AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::205) by VI1PR08CA0190.outlook.office365.com (2603:10a6:800:d2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2073.10 via Frontend Transport; Mon, 15 Jul 2019 10:11:37 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT044.mail.protection.outlook.com (10.152.17.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Mon, 15 Jul 2019 10:11:36 +0000 Received: ("Tessian outbound 3c2a520fbb81:v24"); Mon, 15 Jul 2019 10:11:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b84bf26670fa6260 X-CR-MTA-TID: 64aa7808 Received: from 26ad9beb3b0d.2 (cr-mta-lb-1.cr-mta-net [104.47.6.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8CF76171-B60A-4282-9EAE-29597952EC31.1; Mon, 15 Jul 2019 10:11:31 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 26ad9beb3b0d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Mon, 15 Jul 2019 10:11:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G7BCv1ukxHRWn+mtGTrpInRUqmZsc7PekYSMGAyla7DTF3kIicv9+wV19qrY0LxJLtSwWy4kYdKQoWNiAyVL9r0O9UHZCrrbeYk658rbB+fMQSi9syW902h9S85yujLpBC9CxQNk1Vqz5zY32iyqCrLK4MtmK61mMj2uGAdQSOTNpoYmQihXK0P3vFUHWCfrAvDG1xZUu7dhsWORuO+q0cQUDDczmaBSSWcKfDZKlvJhGszYbnbYGJX4n0y2aEZr+7wPbTlZteZfyCB2yVQOXkiSZziWHkFr6yYeoJV9zEWhJzcy9YRyZrEqumpn8gGa3LDZiHUjDVSvAEIv7lICYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=faISdBXTfSVpveA/laRsj4R9qxtEJTcWVD3vOvpi12Y=; b=MXAugY3qSmU4bV4tUXSPRKKEi+sO1X8cAmRxAxymfqI1iQqc862SPixYznlqNrw4yN8A79+n2MfdzsaVhusa0yDKwCO0pW0ld0jjuJC1121c9nZS5o0xZ7LIvzkRk5I0KA4WIX74LsZJtw0QOZEgTDpIO/MaofcdPRTRtui40uEzW6h3g8F20ShYT+q5f7zqPNmr7xmxnSpEXgHL0e7Ewb3ACp41+/uElO49oOMYjRS1h9x3VyNBuPATbz2tCOm8GAbdpHN7imS026lInXCLjp3k+AT4IUleJNliru0LDOAHEiAcf22lVk8qaMa3ekmAdGyx59n0TPCV63B14riW9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=faISdBXTfSVpveA/laRsj4R9qxtEJTcWVD3vOvpi12Y=; b=HR+3/M9VOU/dEziCUEkpjmdWj95pgVZK0ZNX3XfOtmFYBSa9ycSIz8VsOVXgnUS6ZTRAK7urB/S1dRCEUzsMRTWBgp2ACzeAk+fh9pXVYRHrs0tTNOnzx1zUcIgc6XjsF4NCdc7the/zx3lY+LaJ5sA2V6UMlLCeUBSIU1uoCKw= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2374.eurprd08.prod.outlook.com (10.172.230.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Mon, 15 Jul 2019 10:11:29 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1%6]) with mapi id 15.20.2073.012; Mon, 15 Jul 2019 10:11:29 +0000 From: Alan Hayward <Alan.Hayward@arm.com> To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> CC: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com> Subject: [PATCH] Require GNU make 3.82 Date: Mon, 15 Jul 2019 10:11:29 +0000 Message-ID: <20190715101124.77677-1-alan.hayward@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB6PR0802MB2374; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:2201;OLM:2201; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(136003)(39860400002)(376002)(396003)(189003)(199004)(54534003)(7736002)(2501003)(68736007)(5660300002)(66446008)(64756008)(2351001)(99286004)(66556008)(305945005)(6916009)(4326008)(2906002)(6506007)(53936002)(386003)(316002)(52116002)(6116002)(86362001)(8936002)(1076003)(8676002)(71190400001)(71200400001)(3846002)(478600001)(50226002)(25786009)(66476007)(66946007)(6512007)(81166006)(81156014)(14454004)(2616005)(5640700003)(26005)(6486002)(186003)(54906003)(6436002)(256004)(476003)(14444005)(102836004)(44832011)(36756003)(66066001)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0802MB2374; H:DB6PR0802MB2133.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: VFVLQCbX2QRQaSmhiwxhpy4MZ6cpO0gdkCDWc7+xNWv/EtZEXuayVXJVPoEVxTaioXjv/czaoGKFwiYN4sU3oLFUNWGlEVABibNvzfnWNUl0eKJmiAQwWjAwLj1GG1l2To9DnDJrD4WoVGQcF3GfmlesFACbdhIzcXNBrYI90zIKQHb7yS36arVyop9ExxEuKOQ/rMiddiolGqaylhTiWn6czMLlpohbFIih+UzfkSUpikp4yMZKtU4K0RHQp5gCaI11dQdrgfs/D+yfSZjMAy1jJnx2gaPqoK3DJu+VJtMCDUEDLVUhqSY92EFU1QowJpeEfRART1dLc69pb74eeOrCwTd+NE18p1SnMQxPBDG2tZ9xwx+LHq82JmiQWNAirUHBX+BBxHTqEtiqPexCxZnqgKCv2Qq/uzxYSWObV7U= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 32ead961-9acb-4f6a-4ebe-08d7090ccd89 X-IsSubscribed: yes |
Commit Message
Alan Hayward
July 15, 2019, 10:11 a.m. UTC
Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be. Update the NEWS file to state that versions earlier than 3.82 are not supported. 3.82 was released in 2010, 3.81 was released 2006. A quick investigation of the default GNU make version provided across various distros found the earliest provided version to be 3.82: *RHEL 7, Centos 6 - make 3.82 *Fedora 27 - make 4.2.1 *OpenSuse 42.2, SLES11 - make 4.2.1 *Ubuntu 16.04/18.04 - make 4.1 *Debian Jessie - make 4.0 Note that Glibc requires at least 4.0, whereas GCC still allows 3.81. gdb/ChangeLog: 2019-07-15 Alan Hayward <alan.hayward@arm.com> * NEWS: Require GNU make 3.82. --- gdb/NEWS | 5 +++++ 1 file changed, 5 insertions(+)
Comments
On Mon, 15 Jul 2019 10:11:29 +0000 Alan Hayward <Alan.Hayward@arm.com> wrote: > Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be. > > Update the NEWS file to state that versions earlier than 3.82 are not > supported. > > 3.82 was released in 2010, 3.81 was released 2006. A quick investigation > of the default GNU make version provided across various distros found the > earliest provided version to be 3.82: > *RHEL 7, Centos 6 - make 3.82 > *Fedora 27 - make 4.2.1 > *OpenSuse 42.2, SLES11 - make 4.2.1 > *Ubuntu 16.04/18.04 - make 4.1 > *Debian Jessie - make 4.0 > > Note that Glibc requires at least 4.0, whereas GCC still allows 3.81. > > gdb/ChangeLog: > > 2019-07-15 Alan Hayward <alan.hayward@arm.com> > > * NEWS: Require GNU make 3.82. This seems okay to me, though I think that Eli needs to approve it. Regardless, I think you should wait a few days to push it in case there are any objections. (The other solution is to rewrite the Makefile rules that caused the breakage.) Kevin
> On 16 Jul 2019, at 01:51, Kevin Buettner <kevinb@redhat.com> wrote: > > On Mon, 15 Jul 2019 10:11:29 +0000 > Alan Hayward <Alan.Hayward@arm.com> wrote: > >> Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be. >> >> Update the NEWS file to state that versions earlier than 3.82 are not >> supported. >> >> 3.82 was released in 2010, 3.81 was released 2006. A quick investigation >> of the default GNU make version provided across various distros found the >> earliest provided version to be 3.82: >> *RHEL 7, Centos 6 - make 3.82 >> *Fedora 27 - make 4.2.1 >> *OpenSuse 42.2, SLES11 - make 4.2.1 >> *Ubuntu 16.04/18.04 - make 4.1 >> *Debian Jessie - make 4.0 >> >> Note that Glibc requires at least 4.0, whereas GCC still allows 3.81. >> >> gdb/ChangeLog: >> >> 2019-07-15 Alan Hayward <alan.hayward@arm.com> >> >> * NEWS: Require GNU make 3.82. > > This seems okay to me, though I think that Eli needs to approve it. > Regardless, I think you should wait a few days to push it in case > there are any objections. (The other solution is to rewrite the > Makefile rules that caused the breakage.) > > Kevin Agreed. I’ll give it a good week after the last comment before pushing. I did have a look at why the changes broke. I couldn’t see any reason why it would break, other than it being a bug in 3.81. Alan.
> From: Alan Hayward <Alan.Hayward@arm.com> > CC: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com> > Date: Mon, 15 Jul 2019 10:11:29 +0000 > > Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be. Which feature of Make 3.82 and later is required to successfully build gdbserver? > diff --git a/gdb/NEWS b/gdb/NEWS > index 4e479bf738..3a92b24e44 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -251,6 +251,11 @@ maint show test-options-completion-result > GDB) in the output directory for each test script. Multiple invocations > are appended with .1, .2, .3 etc. > > +* Building GDB and GDBserver now requires GNU make >= 3.82. > + > + Using another implementation of the make program or an earlier version of > + GNU make to build GDB or GDBserver is not supported. > + The test is OK, thanks.
> Date: Thu, 18 Jul 2019 09:17:23 +0300 > From: Eli Zaretskii <eliz@gnu.org> > CC: gdb-patches@sourceware.org, nd@arm.com > > The test is OK, thanks. Sorry, I meant "text".
> On 18 Jul 2019, at 07:17, Eli Zaretskii <eliz@gnu.org> wrote: > >> From: Alan Hayward <Alan.Hayward@arm.com> >> CC: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com> >> Date: Mon, 15 Jul 2019 10:11:29 +0000 >> >> Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be. > > Which feature of Make 3.82 and later is required to successfully > build gdbserver? > It’s not a specific feature in 3.82 that is required. It looks like it is a bug in 3.81. The GDB makefile isn’t doing anything special and everything works using 3.82 upwards. Rewriting the makefile to work around the issue is probably going to be a little messy. >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 4e479bf738..3a92b24e44 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -251,6 +251,11 @@ maint show test-options-completion-result >> GDB) in the output directory for each test script. Multiple invocations >> are appended with .1, .2, .3 etc. >> >> +* Building GDB and GDBserver now requires GNU make >= 3.82. >> + >> + Using another implementation of the make program or an earlier version of >> + GNU make to build GDB or GDBserver is not supported. >> + > > The test is OK, thanks. Thanks! Alan.
I pushed this patch. > On 18 Jul 2019, at 11:57, Alan Hayward <Alan.Hayward@arm.com> wrote: > > > >> On 18 Jul 2019, at 07:17, Eli Zaretskii <eliz@gnu.org> wrote: >> >>> From: Alan Hayward <Alan.Hayward@arm.com> >>> CC: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com> >>> Date: Mon, 15 Jul 2019 10:11:29 +0000 >>> >>> Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be. >> >> Which feature of Make 3.82 and later is required to successfully >> build gdbserver? >> > > It’s not a specific feature in 3.82 that is required. > > It looks like it is a bug in 3.81. The GDB makefile isn’t doing anything special > and everything works using 3.82 upwards. > > Rewriting the makefile to work around the issue is probably going to be a little > messy. > > >>> diff --git a/gdb/NEWS b/gdb/NEWS >>> index 4e479bf738..3a92b24e44 100644 >>> --- a/gdb/NEWS >>> +++ b/gdb/NEWS >>> @@ -251,6 +251,11 @@ maint show test-options-completion-result >>> GDB) in the output directory for each test script. Multiple invocations >>> are appended with .1, .2, .3 etc. >>> >>> +* Building GDB and GDBserver now requires GNU make >= 3.82. >>> + >>> + Using another implementation of the make program or an earlier version of >>> + GNU make to build GDB or GDBserver is not supported. >>> + >> >> The test is OK, thanks. > > Thanks! > > Alan.
diff --git a/gdb/NEWS b/gdb/NEWS index 4e479bf738..3a92b24e44 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -251,6 +251,11 @@ maint show test-options-completion-result GDB) in the output directory for each test script. Multiple invocations are appended with .1, .2, .3 etc. +* Building GDB and GDBserver now requires GNU make >= 3.82. + + Using another implementation of the make program or an earlier version of + GNU make to build GDB or GDBserver is not supported. + *** Changes in GDB 8.3 * GDB and GDBserver now support access to additional registers on