diff mbox

[18/25] gdb/sparc: Use default_unwind_pc

Message ID 64e36625e462d78c2fe3acede9f7de7659402afb.1553721878.git.andrew.burgess@embecosm.com
State New, archived
Headers

Commit Message

Andrew Burgess March 27, 2019, 9:34 p.m. UTC 
  Make use of the default gdbarch method gdbarch_unwind_pc where
possible.

I have not tested this change but, by inspecting the code, I believe
the default methods are equivalent to the code being deleted.

gdb/ChangeLog:

	* sparc-tdep.c (sparc_unwind_pc): Delete.
	(sparc32_gdbarch_init): Don't register deleted function with
	gdbarch.
---
 gdb/ChangeLog    | 6 ++++++
 gdb/sparc-tdep.c | 9 ---------
 2 files changed, 6 insertions(+), 9 deletions(-)

Comments

Kevin Buettner March 27, 2019, 10:33 p.m. UTC | #1 
On Wed, 27 Mar 2019 21:34:14 +0000
Andrew Burgess <andrew.burgess@embecosm.com> wrote:

> gdb/ChangeLog:
> 
> 	* sparc-tdep.c (sparc_unwind_pc): Delete.
> 	(sparc32_gdbarch_init): Don't register deleted function with
> 	gdbarch.

Okay.

Kevin
diff mbox

Patch

diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c
index a155cfa7384..b75fe962c31 100644
--- a/gdb/sparc-tdep.c
+++ b/gdb/sparc-tdep.c
@@ -1114,13 +1114,6 @@  sparc_analyze_prologue (struct gdbarch *gdbarch, CORE_ADDR pc,
   return pc;
 }
 
-static CORE_ADDR
-sparc_unwind_pc (struct gdbarch *gdbarch, struct frame_info *this_frame)
-{
-  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
-  return frame_unwind_register_unsigned (this_frame, tdep->pc_regnum);
-}
-
 /* Return PC of first real instruction of the function starting at
    START_PC.  */
 
@@ -1882,8 +1875,6 @@  sparc32_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 
   set_gdbarch_dummy_id (gdbarch, sparc_dummy_id);
 
-  set_gdbarch_unwind_pc (gdbarch, sparc_unwind_pc);
-
   frame_base_set_default (gdbarch, &sparc32_frame_base);
 
   /* Hook in the DWARF CFI frame unwinder.  */