contrib/gdb-add-index.sh -dwarf-5
Commit Message
Hi,
------------------------------------------------------------------------------
(gdb) help save gdb-index
Save a gdb-index file.
Usage: save gdb-index [-dwarf-5] DIRECTORY
No options create one file with .gdb-index extension for pre-DWARF-5
compatible .gdb_index section. With -dwarf-5 creates two files with
extension .debug_names and .debug_str for DWARF-5 .debug_names section.
------------------------------------------------------------------------------
But gdb-add-index command provides no way how to pass the -dwarf-5 option.
OK for check-in?
Jan
2018-06-30 Jan Kratochvil <jan.kratochvil@redhat.com>
* contrib/gdb-add-index.sh ($dwarf5): New, use it.
Comments
On 2018-06-30 03:36 PM, Jan Kratochvil wrote:
> Hi,
>
> ------------------------------------------------------------------------------
> (gdb) help save gdb-index
> Save a gdb-index file.
> Usage: save gdb-index [-dwarf-5] DIRECTORY
>
> No options create one file with .gdb-index extension for pre-DWARF-5
> compatible .gdb_index section. With -dwarf-5 creates two files with
> extension .debug_names and .debug_str for DWARF-5 .debug_names section.
> ------------------------------------------------------------------------------
>
> But gdb-add-index command provides no way how to pass the -dwarf-5 option.
>
> OK for check-in?
>
>
> Jan
>
Hi Jan,
That LGTM. But could you maybe update the "usage" line to include the
optional -dwarf-5 argument?
echo "usage: $myname [-dwarf-5] FILE" 1>&2
Maybe some day this will evolve in a proper --help.
Simon
@@ -23,6 +23,12 @@ OBJCOPY=${OBJCOPY:=objcopy}
myname="${0##*/}"
+dwarf5=""
+if [ "$1" = "-dwarf-5" ]; then
+ dwarf5="$1"
+ shift
+fi
+
if test $# != 1; then
echo "usage: $myname FILE" 1>&2
exit 1
@@ -48,7 +54,7 @@ rm -f $index4 $index5 $debugstr $debugstrmerge $debugstrerr
trap "rm -f $index4 $index5 $debugstr $debugstrmerge $debugstrerr" 0
$GDB --batch -nx -iex 'set auto-load no' \
- -ex "file $file" -ex "save gdb-index $dir" || {
+ -ex "file $file" -ex "save gdb-index $dwarf5 $dir" || {
# Just in case.
status=$?
echo "$myname: gdb error generating index for $file" 1>&2