diff mbox

Remove trad_frame_set_reg_unknown declaration

Message ID 1410271158-8556-1-git-send-email-james.hogan@imgtec.com
State New, archived
Headers

Commit Message

James Hogan Sept. 9, 2014, 1:59 p.m. UTC 
  The trad_frame_set_reg_unknown declaration was added in commit
0db9b4b70969 (March 2004), but apparently never defined or referenced.

gdb/ChangeLog:

	* trad-frame.h (trad_frame_set_reg_unknown): Remove declaration.
---
 gdb/ChangeLog    | 4 ++++
 gdb/trad-frame.h | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Joel Brobecker Sept. 9, 2014, 2:22 p.m. UTC | #1 
> The trad_frame_set_reg_unknown declaration was added in commit
> 0db9b4b70969 (March 2004), but apparently never defined or referenced.
> 
> gdb/ChangeLog:
> 
> 	* trad-frame.h (trad_frame_set_reg_unknown): Remove declaration.

LGTM, go ahead and push.

Thank you!
James Hogan Sept. 9, 2014, 3:21 p.m. UTC | #2 
On 09/09/14 15:22, Joel Brobecker wrote:
>> The trad_frame_set_reg_unknown declaration was added in commit
>> 0db9b4b70969 (March 2004), but apparently never defined or referenced.
>>
>> gdb/ChangeLog:
>>
>> 	* trad-frame.h (trad_frame_set_reg_unknown): Remove declaration.
> 
> LGTM, go ahead and push.

Thanks.

I forgot to mention, I don't have push rights yet (although IMG do have
copyright assignment I believe). Could you/somebody please apply it?
(otherwise I'm happy to queue my minor patches up until I can push them).

Cheers
James
Joel Brobecker Sept. 9, 2014, 3:44 p.m. UTC | #3 
> >> gdb/ChangeLog:
> >>
> >> 	* trad-frame.h (trad_frame_set_reg_unknown): Remove declaration.
> > 
> > LGTM, go ahead and push.
> 
> Thanks.
> 
> I forgot to mention, I don't have push rights yet (although IMG do have
> copyright assignment I believe). Could you/somebody please apply it?
> (otherwise I'm happy to queue my minor patches up until I can push them).

I just pushed it for you.

You've now submitted one good patch, which is the minimum requirement
for asking for Writer After Approval privileges. So, if you'd like,
we can set you up with write access.  Just contact me privately about
it.

Thanks,
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9d3f392554b5..4297a8b49921 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@ 
+2014-09-09  James Hogan  <james.hogan@imgtec.com>
+
+	* trad-frame.h (trad_frame_set_reg_unknown): Remove declaration.
+
 2014-09-08  Doug Evans  <xdje42@gmail.com>
 
 	PR 17247
diff --git a/gdb/trad-frame.h b/gdb/trad-frame.h
index d75b9c922532..9ec95a898579 100644
--- a/gdb/trad-frame.h
+++ b/gdb/trad-frame.h
@@ -43,8 +43,6 @@  CORE_ADDR trad_frame_get_this_base (struct trad_frame_cache *this_trad_cache);
 
 void trad_frame_set_reg_realreg (struct trad_frame_cache *this_trad_cache,
 				 int regnum, int realreg);
-void trad_frame_set_reg_unknown (struct trad_frame_cache *this_trad_cache,
-				 int regnum, CORE_ADDR addr);
 void trad_frame_set_reg_addr (struct trad_frame_cache *this_trad_cache,
 			      int regnum, CORE_ADDR addr);
 void trad_frame_set_reg_value (struct trad_frame_cache *this_cache,