diff mbox

Fix aarch64 native build issue caused by use of LONGEST

Message ID CAHFci28bntUtNPyibqBPmcyM+nmo=t534tBvgtabcFot=ZXfTw@mail.gmail.com
State New, archived
Headers

Commit Message

Bin.Cheng Aug. 21, 2014, 8:32 a.m. UTC 
  Hi,
Recent gdb code refactor changes LONGEST from a macro to a typedef,
thus the use of it in aarch64-linux-nat.c is no longer valid.

This patch fixes the build failure which is obvious.  Is it OK?

Thanks,
bin

2014-08-21  Bin Cheng  <bin.cheng@arm.com>

* aarch64-linux-nat.c (dr_changed_t): Change the type from
unsigned LONGEST to ULONGEST.

Comments

Will Newton Aug. 21, 2014, 8:40 a.m. UTC | #1 
On 21 August 2014 09:32, Bin.Cheng <amker.cheng@gmail.com> wrote:
> Hi,
> Recent gdb code refactor changes LONGEST from a macro to a typedef,
> thus the use of it in aarch64-linux-nat.c is no longer valid.
>
> This patch fixes the build failure which is obvious.  Is it OK?
>
> Thanks,
> bin
>
> 2014-08-21  Bin Cheng  <bin.cheng@arm.com>
>
> * aarch64-linux-nat.c (dr_changed_t): Change the type from
> unsigned LONGEST to ULONGEST.

I pushed this as obvious given that Marcus is not around.
Gary Benson Aug. 27, 2014, 8:46 a.m. UTC | #2 
Will Newton wrote:
> On 21 August 2014 09:32, Bin.Cheng <amker.cheng@gmail.com> wrote:
> > Recent gdb code refactor changes LONGEST from a macro to a typedef,
> > thus the use of it in aarch64-linux-nat.c is no longer valid.
> >
> > This patch fixes the build failure which is obvious.  Is it OK?
> >
> > 2014-08-21  Bin Cheng  <bin.cheng@arm.com>
> >
> > * aarch64-linux-nat.c (dr_changed_t): Change the type from
> > unsigned LONGEST to ULONGEST.
> 
> I pushed this as obvious given that Marcus is not around.

Bin, Will, thanks for fixing this.

Cheers,
Gary
diff mbox

Patch

diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index 4ae789b..1184197 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -144,7 +144,7 @@  static int debug_hw_points;
    ptrace calls to the kernel, i.e. avoid asking the kernel to write
    to the debug registers with unchanged values.  */
 
-typedef unsigned LONGEST dr_changed_t;
+typedef ULONGEST dr_changed_t;
 
 /* Set each of the lower M bits of X to 1; assert X is wide enough.  */