Message ID | 876098j7ij.fsf@euler.schwinge.homeip.net |
---|---|
State | Committed, archived |
Headers |
Received: (qmail 21253 invoked by alias); 15 Dec 2017 16:11:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 21189 invoked by uid 89); 15 Dec 2017 16:11:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=Samuel, samuel, H*r:PST, respond X-HELO: relay1.mentorg.com From: Thomas Schwinge <thomas@codesourcery.com> To: Samuel Thibault <samuel.thibault@ens-lyon.org> CC: <libc-alpha@sourceware.org> Subject: Re: [hurd,commited] hurd: Fix rtld link In-Reply-To: <20170903023345.24804-1-samuel.thibault@ens-lyon.org> References: <20170903023345.24804-1-samuel.thibault@ens-lyon.org> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Fri, 15 Dec 2017 17:11:32 +0100 Message-ID: <876098j7ij.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable |
Commit Message
Thomas Schwinge
Dec. 15, 2017, 4:11 p.m. UTC
Hi Samuel! On Sun, 3 Sep 2017 04:33:45 +0200, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > --- a/sysdeps/mach/hurd/dl-sysdep.c > +++ b/sysdeps/mach/hurd/dl-sysdep.c > +int weak_function > +__access_noerrno (const char *file, int type) > +{ > + errno = ENOSYS; > + return -1; > +} I just stumbled across this -- OK to push the following? Note that I have not tested this. If approving this, please respond with "Reviewed-by: NAME <EMAIL>" so that your effort will be recorded. See <https://gcc.gnu.org/wiki/Reviewed-by>. commit 336e16f8e6a588ba048997722a114f9d4462dbdb Author: Thomas Schwinge <thomas@codesourcery.com> Date: Fri Dec 15 17:00:50 2017 +0100 Don't set errno in Hurd rtld's __access_noerrno * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set errno. Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961. --- sysdeps/mach/hurd/dl-sysdep.c | 1 - 1 file changed, 1 deletion(-) Grüße Thomas
Comments
Thomas Schwinge, on ven. 15 déc. 2017 17:11:32 +0100, wrote: > Hi Samuel! > > On Sun, 3 Sep 2017 04:33:45 +0200, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > > --- a/sysdeps/mach/hurd/dl-sysdep.c > > +++ b/sysdeps/mach/hurd/dl-sysdep.c > > > +int weak_function > > +__access_noerrno (const char *file, int type) > > +{ > > + errno = ENOSYS; > > + return -1; > > +} D'oh... > I just stumbled across this -- OK to push the following? Note that I > have not tested this. If approving this, please respond with > "Reviewed-by: NAME <EMAIL>" so that your effort will be recorded. See > <https://gcc.gnu.org/wiki/Reviewed-by>. > > commit 336e16f8e6a588ba048997722a114f9d4462dbdb > Author: Thomas Schwinge <thomas@codesourcery.com> > Date: Fri Dec 15 17:00:50 2017 +0100 > > Don't set errno in Hurd rtld's __access_noerrno > > * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set > errno. > > Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961. Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Thanks! > --- > sysdeps/mach/hurd/dl-sysdep.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c > index 2cc342ec8e..5121ce325c 100644 > --- sysdeps/mach/hurd/dl-sysdep.c > +++ sysdeps/mach/hurd/dl-sysdep.c > @@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno); > int weak_function > __access_noerrno (const char *file, int type) > { > - errno = ENOSYS; > return -1; > } > > > > Grüße > Thomas >
diff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c index 2cc342ec8e..5121ce325c 100644 --- sysdeps/mach/hurd/dl-sysdep.c +++ sysdeps/mach/hurd/dl-sysdep.c @@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno); int weak_function __access_noerrno (const char *file, int type) { - errno = ENOSYS; return -1; }