diff mbox

Warnings in native MinGW32 build of GDB 7.8

Message ID 20140815123300.GA6037@adacore.com
State Committed
Headers

Commit Message

Joel Brobecker Aug. 15, 2014, 12:33 p.m. UTC 
  > > Attached is a patch that does that. Can you confirm it fixes your
> > warnings?
> 
> Yes, it does.  Thanks!

Thanks, Eli. I just pushed that patch.
And since I was missing one piece in the ChangeLog entry, I am
attaching the patch I ended up pushing.  The diff itself is the same
though.

Comments

Eli Zaretskii Aug. 15, 2014, 2:21 p.m. UTC | #1 
> Date: Fri, 15 Aug 2014 05:33:00 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: yao@codesourcery.com, gdb-patches@sourceware.org
> 
> > > Attached is a patch that does that. Can you confirm it fixes your
> > > warnings?
> > 
> > Yes, it does.  Thanks!
> 
> Thanks, Eli. I just pushed that patch.

Thanks, I pushed the other part, and also cherry-picked both to the
7.8 branch.
diff mbox

Patch

From eb7a547ad40c97ca306e29c94678e4eab1822089 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Wed, 13 Aug 2014 11:15:00 -0700
Subject: [PATCH] Add "frame.h" #include in gdbarch.h.

This include is needed because gdbarch_dummy_id needs the full
definition of struct frame_id.

gdb/ChangeLog:

        * gdbarch.sh: #include "frame.h" in gdbarch.h.  Delete "struct
        frame_info" partial declaration.
        * gdbarch.h: Regenerate.

Tested on x86_64-linux by rebuilding GDB.
---
 gdb/ChangeLog  | 6 ++++++
 gdb/gdbarch.h  | 3 ++-
 gdb/gdbarch.sh | 3 ++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 53cc615..6aa6592 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@ 
+2014-08-15  Joel Brobecker  <brobecker@adacore.com>
+
+	* gdbarch.sh: #include "frame.h" in gdbarch.h.  Delete "struct
+	frame_info" partial declaration.
+	* gdbarch.h: Regenerate.
+
 2014-08-15  Yao Qi  <yao@codesourcery.com>
 
 	* dwarf2read.c (dwarf_decode_lines_1): Remove parameter 'pst'.
diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 5388e6e..0303b2e 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -35,9 +35,10 @@ 
 #ifndef GDBARCH_H
 #define GDBARCH_H
 
+#include "frame.h"
+
 struct floatformat;
 struct ui_file;
-struct frame_info;
 struct value;
 struct objfile;
 struct obj_section;
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 61d0781..2a8bca8 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -1124,9 +1124,10 @@  cat <<EOF
 #ifndef GDBARCH_H
 #define GDBARCH_H
 
+#include "frame.h"
+
 struct floatformat;
 struct ui_file;
-struct frame_info;
 struct value;
 struct objfile;
 struct obj_section;
-- 
1.9.1