diff mbox

Set print symbol off in some tests

Message ID 1407988791-14057-1-git-send-email-yao@codesourcery.com
State Committed
Headers

Commit Message

Yao Qi Aug. 14, 2014, 3:59 a.m. UTC 
  GDB in default prints the symbol associated on an address, and tests
assume that there is no symbol on address zero.  However, on bare
metal target, address may be mapped to zero and there may be a
symbol.  Then, some tests fails as below:

print const_cast<void *> (0)^M
$8 = (void *) 0x0 <_ftext>^M
(gdb) FAIL: gdb.cp/casts.exp: const_cast of 0

p acp->c1^M
$9 = (A *) 0x0 <_ftext>^M
(gdb) FAIL: gdb.cp/class2.exp: p acp->c1

This patch is to set print symbol off in these tests, like what
I did previously https://sourceware.org/ml/gdb-patches/2014-07/msg00257.html

gdb/testsuite:

2014-08-14  Yao Qi  <yao@codesourcery.com>

	* gdb.cp/casts.exp: Set print symbol off.
	* gdb.cp/class2.exp: Likewise.
	* gdb.cp/overload.exp: Likewise.
	* gdb.cp/templates.exp: Likewise.
---
 gdb/testsuite/gdb.cp/casts.exp     | 3 +++
 gdb/testsuite/gdb.cp/class2.exp    | 3 ++-
 gdb/testsuite/gdb.cp/overload.exp  | 3 +++
 gdb/testsuite/gdb.cp/templates.exp | 2 ++
 4 files changed, 10 insertions(+), 1 deletion(-)

Comments

Joel Brobecker Aug. 14, 2014, 11:03 p.m. UTC | #1 
> 2014-08-14  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.cp/casts.exp: Set print symbol off.
> 	* gdb.cp/class2.exp: Likewise.
> 	* gdb.cp/overload.exp: Likewise.
> 	* gdb.cp/templates.exp: Likewise.

OK!

Thanks,
Yao Qi Aug. 14, 2014, 11:57 p.m. UTC | #2 
On 08/15/2014 07:03 AM, Joel Brobecker wrote:
>> 2014-08-14  Yao Qi  <yao@codesourcery.com>
>>
>> 	* gdb.cp/casts.exp: Set print symbol off.
>> 	* gdb.cp/class2.exp: Likewise.
>> 	* gdb.cp/overload.exp: Likewise.
>> 	* gdb.cp/templates.exp: Likewise.
> 
> OK!
> 
> Thanks,
> 

Thanks Joel, patch is pushed in.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.cp/casts.exp b/gdb/testsuite/gdb.cp/casts.exp
index 9122450..e28f311 100644
--- a/gdb/testsuite/gdb.cp/casts.exp
+++ b/gdb/testsuite/gdb.cp/casts.exp
@@ -42,6 +42,9 @@  if ![runto_main] then {
     continue
 }
 
+# Prevent symbol on address 0x0 being printed.
+gdb_test_no_output "set print symbol off"
+
 gdb_test "break [gdb_get_line_number "casts.exp: 1"]" \
     "Breakpoint.*at.* file .*" \
     ""
diff --git a/gdb/testsuite/gdb.cp/class2.exp b/gdb/testsuite/gdb.cp/class2.exp
index 82faac5..eae5922 100644
--- a/gdb/testsuite/gdb.cp/class2.exp
+++ b/gdb/testsuite/gdb.cp/class2.exp
@@ -28,9 +28,10 @@  if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug c++}]} {
     return -1
 }
 
-# Start with "set print object off".
+# Start with "set print object off" and "set print symbol off".
 
 gdb_test_no_output "set print object off"
+gdb_test_no_output "set print symbol off"
 
 if ![runto_main] then {
     perror "couldn't run to main"
diff --git a/gdb/testsuite/gdb.cp/overload.exp b/gdb/testsuite/gdb.cp/overload.exp
index 73232f7..aea2efc 100644
--- a/gdb/testsuite/gdb.cp/overload.exp
+++ b/gdb/testsuite/gdb.cp/overload.exp
@@ -39,6 +39,9 @@  if ![runto 'marker1'] then {
     continue
 }
 
+# Prevent symbol on address 0x0 being printed.
+gdb_test_no_output "set print symbol off"
+
 gdb_test "up" ".*main.*" "up from marker1"
 
 # Print the monster class type.
diff --git a/gdb/testsuite/gdb.cp/templates.exp b/gdb/testsuite/gdb.cp/templates.exp
index 0cc0e84..42dc1df 100644
--- a/gdb/testsuite/gdb.cp/templates.exp
+++ b/gdb/testsuite/gdb.cp/templates.exp
@@ -293,6 +293,8 @@  gdb_test "c" \
 gdb_test "print fint" \
    "\\$\[0-9\]* = \\{x = 0, t = 0\\}"
 
+# Prevent symbol on address 0x0 being printed.
+gdb_test_no_output "set print symbol off"
 gdb_test "print fvpchar" \
     "\\$\[0-9\]* = \\{x = 0, t = 0x0\\}"