[nsz/math2] e_exp2f.c: Support multiarch

Message ID 20170926230507.GA20101@gmail.com
State New, archived
Headers

Commit Message

H.J. Lu Sept. 26, 2017, 11:05 p.m. UTC
  This is for nsz/math2 branch.
 
This is to support compiling e_exp2f.c more than once for multiarch.

	* sysdeps/ieee754/flt-32/e_exp2f.c [__exp2f] (__ieee754_exp2f,
	__exp2f_finite, exp2f): Skip.
---
 sysdeps/ieee754/flt-32/e_exp2f.c | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Szabolcs Nagy Sept. 27, 2017, 8:50 a.m. UTC | #1
On 27/09/17 00:05, H.J. Lu wrote:
> This is for nsz/math2 branch.
>  

i figured out how to update a branch so nsz/math == nsz/math2 now.

> This is to support compiling e_exp2f.c more than once for multiarch.
> 

shall i do this for all new functions (logf, log2f, powf)?

> 	* sysdeps/ieee754/flt-32/e_exp2f.c [__exp2f] (__ieee754_exp2f,
> 	__exp2f_finite, exp2f): Skip.
> ---
>  sysdeps/ieee754/flt-32/e_exp2f.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sysdeps/ieee754/flt-32/e_exp2f.c b/sysdeps/ieee754/flt-32/e_exp2f.c
> index b53a919a0d..e54a88f692 100644
> --- a/sysdeps/ieee754/flt-32/e_exp2f.c
> +++ b/sysdeps/ieee754/flt-32/e_exp2f.c
> @@ -86,6 +86,9 @@ __exp2f (float x)
>    y = y * s;
>    return (float) y;
>  }
> +
> +#ifndef __exp2f
>  strong_alias (__exp2f, __ieee754_exp2f)
>  strong_alias (__exp2f, __exp2f_finite)
>  versioned_symbol (libm, __exp2f, exp2f, GLIBC_2_27);
> +#endif
>
  
H.J. Lu Sept. 27, 2017, 9:05 p.m. UTC | #2
On 9/27/17, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
> On 27/09/17 00:05, H.J. Lu wrote:
>> This is for nsz/math2 branch.
>>
>
> i figured out how to update a branch so nsz/math == nsz/math2 now.
>

Can you remove nsz/math2  to avoid confusion?

>> This is to support compiling e_exp2f.c more than once for multiarch.
>>
>
> shall i do this for all new functions (logf, log2f, powf)?

Yes, please.

Thanks.

>> 	* sysdeps/ieee754/flt-32/e_exp2f.c [__exp2f] (__ieee754_exp2f,
>> 	__exp2f_finite, exp2f): Skip.
>> ---
>>  sysdeps/ieee754/flt-32/e_exp2f.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/sysdeps/ieee754/flt-32/e_exp2f.c
>> b/sysdeps/ieee754/flt-32/e_exp2f.c
>> index b53a919a0d..e54a88f692 100644
>> --- a/sysdeps/ieee754/flt-32/e_exp2f.c
>> +++ b/sysdeps/ieee754/flt-32/e_exp2f.c
>> @@ -86,6 +86,9 @@ __exp2f (float x)
>>    y = y * s;
>>    return (float) y;
>>  }
>> +
>> +#ifndef __exp2f
>>  strong_alias (__exp2f, __ieee754_exp2f)
>>  strong_alias (__exp2f, __exp2f_finite)
>>  versioned_symbol (libm, __exp2f, exp2f, GLIBC_2_27);
>> +#endif
>>
>
>
  

Patch

diff --git a/sysdeps/ieee754/flt-32/e_exp2f.c b/sysdeps/ieee754/flt-32/e_exp2f.c
index b53a919a0d..e54a88f692 100644
--- a/sysdeps/ieee754/flt-32/e_exp2f.c
+++ b/sysdeps/ieee754/flt-32/e_exp2f.c
@@ -86,6 +86,9 @@  __exp2f (float x)
   y = y * s;
   return (float) y;
 }
+
+#ifndef __exp2f
 strong_alias (__exp2f, __ieee754_exp2f)
 strong_alias (__exp2f, __exp2f_finite)
 versioned_symbol (libm, __exp2f, exp2f, GLIBC_2_27);
+#endif