diff mbox

Add test for string evaluation with "debug expression" on

Message ID 1405444764-17309-1-git-send-email-simon.marchi@ericsson.com
State Committed
Headers

Commit Message

Simon Marchi July 15, 2014, 5:19 p.m. UTC 
  As Joel pointed out in...
https://sourceware.org/ml/gdb-patches/2014-07/msg00391.html
...it would be nice to add a test for that.

Tested on Linux x86_64 (Ubuntu 14.10).

gdb/testsuite/ChangeLog

2014-07-15  Simon Marchi  <simon.marchi@ericsson.com>

	* gdb.base/debug-expr.exp: Test string evaluation with
	"debug expression" on.
---
 gdb/testsuite/gdb.base/debug-expr.exp | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Joel Brobecker July 16, 2014, 1:32 p.m. UTC | #1 
> 2014-07-15  Simon Marchi  <simon.marchi@ericsson.com>
> 
> 	* gdb.base/debug-expr.exp: Test string evaluation with
> 	"debug expression" on.

Thanks for doing that. It looks good to me, so please go ahead and push!
Simon Marchi July 16, 2014, 5:23 p.m. UTC | #2 
On 14-07-16 09:32 AM, Joel Brobecker wrote:
>> 2014-07-15  Simon Marchi  <simon.marchi@ericsson.com>
>>
>> 	* gdb.base/debug-expr.exp: Test string evaluation with
>> 	"debug expression" on.
> 
> Thanks for doing that. It looks good to me, so please go ahead and push!
> 

Thanks, pushed.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/debug-expr.exp b/gdb/testsuite/gdb.base/debug-expr.exp
index d7c82b0..5576091 100644
--- a/gdb/testsuite/gdb.base/debug-expr.exp
+++ b/gdb/testsuite/gdb.base/debug-expr.exp
@@ -50,3 +50,8 @@  gdb_test_no_output "set debug expression 1"
 # This caused gdb to segfault.
 test_debug_expr "print /x {char\[4\]} array" \
     "\[$\]$decimal = \\{0x0, 0x1, 0x2, 0x3\\}"
+
+# This caused gdb to output garbage and possibly segfault
+gdb_test "print \"hello\"" \
+    ".*OP_STRING\[^\r\n\]*Language-specific string type: 0.*\[\r\n\]\\$$decimal = \"hello\"\[\r\n\].*" \
+    "String evaluation with debug expr"