| Message ID | 4c0d8778-916b-43d4-3206-2653f3696390@linux.vnet.ibm.com |
|---|---|
| State | Committed |
| Headers |
Received: (qmail 13481 invoked by alias); 31 Jan 2017 15:13:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 11920 invoked by uid 89); 31 Jan 2017 15:13:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL, BAYES_40, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Compiling, bye, *domain, UD:tst-resolv-qtypes.c X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: Get rid of duplicate const declaration specifier warning in tst-resolv-qtypes.c. To: libc-alpha@sourceware.org References: <8d30c0c3-0b00-fc08-8e49-811aec114ef9@linux.vnet.ibm.com> <878tpry1ce.fsf@linux-m68k.org> From: Stefan Liebler <stli@linux.vnet.ibm.com> Date: Tue, 31 Jan 2017 16:13:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <878tpry1ce.fsf@linux-m68k.org> Content-Type: multipart/mixed; boundary="------------2D9132D6272016E2C321AE95" X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17013115-0028-0000-0000-000002A15815 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17013115-0029-0000-0000-00002237E711 Message-Id: <4c0d8778-916b-43d4-3206-2653f3696390@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-01-31_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701310130 |
Commit Message
Stefan Liebler
Jan. 31, 2017, 3:13 p.m. UTC
On 01/31/2017 11:23 AM, Andreas Schwab wrote: > On Jan 31 2017, Stefan Liebler <stli@linux.vnet.ibm.com> wrote: > >> static const const char *domain = "www.example.com"; > > domain should be const. > > Andreas. > Okay. Here is the updated patch. Okay to commit (after release)? Bye. Stefan
Comments
On 01/31/2017 04:13 PM, Stefan Liebler wrote: > On 01/31/2017 11:23 AM, Andreas Schwab wrote: >> On Jan 31 2017, Stefan Liebler <stli@linux.vnet.ibm.com> wrote: >> >>> static const const char *domain = "www.example.com"; >> >> domain should be const. >> >> Andreas. >> > Okay. > > Here is the updated patch. > > Okay to commit (after release)? > > Bye. > Stefan > ping
On 02/08/2017 03:52 PM, Stefan Liebler wrote: > On 01/31/2017 04:13 PM, Stefan Liebler wrote: >> On 01/31/2017 11:23 AM, Andreas Schwab wrote: >>> On Jan 31 2017, Stefan Liebler <stli@linux.vnet.ibm.com> wrote: >>> >>>> static const const char *domain = "www.example.com"; >>> >>> domain should be const. >>> >>> Andreas. >>> >> Okay. >> >> Here is the updated patch. >> >> Okay to commit (after release)? >> >> Bye. >> Stefan >> > > ping > ping
On Tue, Jan 31, 2017 at 04:13:29PM +0100, Stefan Liebler wrote: > On 01/31/2017 11:23 AM, Andreas Schwab wrote: > >On Jan 31 2017, Stefan Liebler <stli@linux.vnet.ibm.com> wrote: > > > >> static const const char *domain = "www.example.com"; > > > >domain should be const. > > > >Andreas. > > > Okay. > > Here is the updated patch. > > Okay to commit (after release)? > > Bye. > Stefan > > commit 322394d80126fb540026818bb81f0df79d2fa3cf > Author: Stefan Liebler <stli@linux.vnet.ibm.com> > Date: Mon Jan 30 09:06:44 2017 +0100 > > Get rid of duplicate const declaration specifier warning in tst-resolv-qtypes.c. > > Compiling resolv/tst-resolv-qtypes.c with GCC 7 results in: > tst-resolv-qtypes.c:53:14: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier] > static const const char *domain = "www.example.com"; > > This patch removes the duplicate const and makes domain a const pointer > to const char literal. > > ChangeLog: > > * resolv/tst-resolv-qtypes.c (domain): > Change type to const pointer to const char. > > diff --git a/resolv/tst-resolv-qtypes.c b/resolv/tst-resolv-qtypes.c > index dcb39e5..06ea3db 100644 > --- a/resolv/tst-resolv-qtypes.c > +++ b/resolv/tst-resolv-qtypes.c > @@ -50,7 +50,7 @@ response (const struct resolv_response_context *ctx, > resolv_response_close_record (b); > } > > -static const const char *domain = "www.example.com"; > +static const char * const domain = "www.example.com"; > > static int > wrap_res_query (int type, unsigned char *answer, int answer_length) Yes, this is OK.
On 02/24/2017 10:57 AM, Dmitry V. Levin wrote: > On Tue, Jan 31, 2017 at 04:13:29PM +0100, Stefan Liebler wrote: >> On 01/31/2017 11:23 AM, Andreas Schwab wrote: >>> On Jan 31 2017, Stefan Liebler <stli@linux.vnet.ibm.com> wrote: >>> >>>> static const const char *domain = "www.example.com"; >>> >>> domain should be const. >>> >>> Andreas. >>> >> Okay. >> >> Here is the updated patch. >> >> Okay to commit (after release)? >> >> Bye. >> Stefan >> >> commit 322394d80126fb540026818bb81f0df79d2fa3cf >> Author: Stefan Liebler <stli@linux.vnet.ibm.com> >> Date: Mon Jan 30 09:06:44 2017 +0100 >> >> Get rid of duplicate const declaration specifier warning in tst-resolv-qtypes.c. >> >> Compiling resolv/tst-resolv-qtypes.c with GCC 7 results in: >> tst-resolv-qtypes.c:53:14: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier] >> static const const char *domain = "www.example.com"; >> >> This patch removes the duplicate const and makes domain a const pointer >> to const char literal. >> >> ChangeLog: >> >> * resolv/tst-resolv-qtypes.c (domain): >> Change type to const pointer to const char. >> >> diff --git a/resolv/tst-resolv-qtypes.c b/resolv/tst-resolv-qtypes.c >> index dcb39e5..06ea3db 100644 >> --- a/resolv/tst-resolv-qtypes.c >> +++ b/resolv/tst-resolv-qtypes.c >> @@ -50,7 +50,7 @@ response (const struct resolv_response_context *ctx, >> resolv_response_close_record (b); >> } >> >> -static const const char *domain = "www.example.com"; >> +static const char * const domain = "www.example.com"; >> >> static int >> wrap_res_query (int type, unsigned char *answer, int answer_length) > > Yes, this is OK. > > Committed. Thanks. Stefan
On Fri, Feb 24, 2017 at 1:57 AM, Dmitry V. Levin <ldv@altlinux.org> wrote: > On Tue, Jan 31, 2017 at 04:13:29PM +0100, Stefan Liebler wrote: >> On 01/31/2017 11:23 AM, Andreas Schwab wrote: >> >On Jan 31 2017, Stefan Liebler <stli@linux.vnet.ibm.com> wrote: >> > >> >> static const const char *domain = "www.example.com"; >> > >> >domain should be const. >> > >> >Andreas. >> > >> Okay. >> >> Here is the updated patch. >> >> Okay to commit (after release)? >> >> Bye. >> Stefan >> >> commit 322394d80126fb540026818bb81f0df79d2fa3cf >> Author: Stefan Liebler <stli@linux.vnet.ibm.com> >> Date: Mon Jan 30 09:06:44 2017 +0100 >> >> Get rid of duplicate const declaration specifier warning in tst-resolv-qtypes.c. >> >> Compiling resolv/tst-resolv-qtypes.c with GCC 7 results in: >> tst-resolv-qtypes.c:53:14: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier] >> static const const char *domain = "www.example.com"; >> >> This patch removes the duplicate const and makes domain a const pointer >> to const char literal. >> >> ChangeLog: >> >> * resolv/tst-resolv-qtypes.c (domain): >> Change type to const pointer to const char. >> >> diff --git a/resolv/tst-resolv-qtypes.c b/resolv/tst-resolv-qtypes.c >> index dcb39e5..06ea3db 100644 >> --- a/resolv/tst-resolv-qtypes.c >> +++ b/resolv/tst-resolv-qtypes.c >> @@ -50,7 +50,7 @@ response (const struct resolv_response_context *ctx, >> resolv_response_close_record (b); >> } >> >> -static const const char *domain = "www.example.com"; >> +static const char * const domain = "www.example.com"; >> >> static int >> wrap_res_query (int type, unsigned char *answer, int answer_length) > > Yes, this is OK. > I'd like to backport it to 2.25 branch. Any objections? Thanks.
H.J. Lu wrote: > -static const const char *domain = "www.example.com"; > +static const char * const domain = "www.example.com"; Why not: static const char domain[] = "www.example.com"; instead, before you backport? It's simpler and less confusing.
On Thu, Sep 7, 2017 at 10:38 AM, Paul Eggert <eggert@cs.ucla.edu> wrote: > H.J. Lu wrote: >> >> -static const const char *domain = "www.example.com"; >> +static const char * const domain = "www.example.com"; > > > Why not: > > static const char domain[] = "www.example.com"; > > instead, before you backport? It's simpler and less confusing. If we want to do this, it should go into master branch first and backport it 2.26 branch before putting in 2.25 branch. Should we do it?
* H. J. Lu: > On Thu, Sep 7, 2017 at 10:38 AM, Paul Eggert <eggert@cs.ucla.edu> wrote: >> H.J. Lu wrote: >>> >>> -static const const char *domain = "www.example.com"; >>> +static const char * const domain = "www.example.com"; >> >> >> Why not: >> >> static const char domain[] = "www.example.com"; >> >> instead, before you backport? It's simpler and less confusing. > > If we want to do this, it should go into master branch first and > backport it 2.26 branch before putting in 2.25 branch. Should > we do it? I have no objections.
H.J. Lu wrote: >> Why not: >> >> static const char domain[] = "www.example.com"; >> >> instead, before you backport? It's simpler and less confusing. > If we want to do this, it should go into master branch first and > backport it 2.26 branch before putting in 2.25 branch. Should > we do it? Yes, that's the idea.
commit 322394d80126fb540026818bb81f0df79d2fa3cf
Author: Stefan Liebler <stli@linux.vnet.ibm.com>
Date: Mon Jan 30 09:06:44 2017 +0100
Get rid of duplicate const declaration specifier warning in tst-resolv-qtypes.c.
Compiling resolv/tst-resolv-qtypes.c with GCC 7 results in:
tst-resolv-qtypes.c:53:14: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier]
static const const char *domain = "www.example.com";
This patch removes the duplicate const and makes domain a const pointer
to const char literal.
ChangeLog:
* resolv/tst-resolv-qtypes.c (domain):
Change type to const pointer to const char.
diff --git a/resolv/tst-resolv-qtypes.c b/resolv/tst-resolv-qtypes.c
index dcb39e5..06ea3db 100644
--- a/resolv/tst-resolv-qtypes.c
+++ b/resolv/tst-resolv-qtypes.c
@@ -50,7 +50,7 @@ response (const struct resolv_response_context *ctx,
resolv_response_close_record (b);
}
-static const const char *domain = "www.example.com";
+static const char * const domain = "www.example.com";
static int
wrap_res_query (int type, unsigned char *answer, int answer_length)