[obvious?] Fix incorrect reference to source files
Commit Message
These auto-generated register source files have been renamed back in 2010.
It took me a while to find these due to the mismatch.
gdb/gdbserver/ChangeLog:
2016-12-06 Luis Machado <lgustavo@codesourcery.com>
* win32-i386-low.c: Fix incorrect reference to a couple source files.
---
gdb/gdbserver/win32-i386-low.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 2016-12-06 11:15, Luis Machado wrote:
> These auto-generated register source files have been renamed back in
> 2010.
>
> It took me a while to find these due to the mismatch.
>
> gdb/gdbserver/ChangeLog:
>
> 2016-12-06 Luis Machado <lgustavo@codesourcery.com>
>
> * win32-i386-low.c: Fix incorrect reference to a couple source files.
> ---
> gdb/gdbserver/win32-i386-low.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/gdbserver/win32-i386-low.c
> b/gdb/gdbserver/win32-i386-low.c
> index 5daa863..edae9bb 100644
> --- a/gdb/gdbserver/win32-i386-low.c
> +++ b/gdb/gdbserver/win32-i386-low.c
> @@ -29,11 +29,11 @@
> #define FLAG_TRACE_BIT 0x100
>
> #ifdef __x86_64__
> -/* Defined in auto-generated file reg-amd64.c. */
> +/* Defined in auto-generated file amd64.c. */
> void init_registers_amd64 (void);
> extern const struct target_desc *tdesc_amd64;
> #else
> -/* Defined in auto-generated file reg-i386.c. */
> +/* Defined in auto-generated file i386.c. */
> void init_registers_i386 (void);
> extern const struct target_desc *tdesc_i386;
> #endif
You could also put the full path to the file, either
features/i386/amd64.c or gdb/features/i386/amd64.c, since it's not
obvious where those files are located (although a "find" finds it
quickly).
On 12/06/2016 12:54 PM, Simon Marchi wrote:
> On 2016-12-06 11:15, Luis Machado wrote:
>> These auto-generated register source files have been renamed back in
>> 2010.
>>
>> It took me a while to find these due to the mismatch.
>>
>> gdb/gdbserver/ChangeLog:
>>
>> 2016-12-06 Luis Machado <lgustavo@codesourcery.com>
>>
>> * win32-i386-low.c: Fix incorrect reference to a couple source files.
>> ---
>> gdb/gdbserver/win32-i386-low.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/gdbserver/win32-i386-low.c
>> b/gdb/gdbserver/win32-i386-low.c
>> index 5daa863..edae9bb 100644
>> --- a/gdb/gdbserver/win32-i386-low.c
>> +++ b/gdb/gdbserver/win32-i386-low.c
>> @@ -29,11 +29,11 @@
>> #define FLAG_TRACE_BIT 0x100
>>
>> #ifdef __x86_64__
>> -/* Defined in auto-generated file reg-amd64.c. */
>> +/* Defined in auto-generated file amd64.c. */
>> void init_registers_amd64 (void);
>> extern const struct target_desc *tdesc_amd64;
>> #else
>> -/* Defined in auto-generated file reg-i386.c. */
>> +/* Defined in auto-generated file i386.c. */
>> void init_registers_i386 (void);
>> extern const struct target_desc *tdesc_i386;
>> #endif
>
> You could also put the full path to the file, either
> features/i386/amd64.c or gdb/features/i386/amd64.c, since it's not
> obvious where those files are located (although a "find" finds it quickly).
>
Good one. That sounds better.
@@ -29,11 +29,11 @@
#define FLAG_TRACE_BIT 0x100
#ifdef __x86_64__
-/* Defined in auto-generated file reg-amd64.c. */
+/* Defined in auto-generated file amd64.c. */
void init_registers_amd64 (void);
extern const struct target_desc *tdesc_amd64;
#else
-/* Defined in auto-generated file reg-i386.c. */
+/* Defined in auto-generated file i386.c. */
void init_registers_i386 (void);
extern const struct target_desc *tdesc_i386;
#endif