Message ID | 1480107244-1484-8-git-send-email-lgustavo@codesourcery.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 109954 invoked by alias); 25 Nov 2016 20:54:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 109850 invoked by uid 89); 25 Nov 2016 20:54:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1062 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 20:54:29 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1cANVk-0003Vm-I9 from Luis_Gustavo@mentor.com for gdb-patches@sourceware.org; Fri, 25 Nov 2016 12:54:20 -0800 Received: from Opsys.world.mentorg.com (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Fri, 25 Nov 2016 12:54:20 -0800 From: Luis Machado <lgustavo@codesourcery.com> To: <gdb-patches@sourceware.org> Subject: [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple Date: Fri, 25 Nov 2016 14:54:03 -0600 Message-ID: <1480107244-1484-8-git-send-email-lgustavo@codesourcery.com> In-Reply-To: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes |
Commit Message
Luis Machado
Nov. 25, 2016, 8:54 p.m. UTC
This fixes offender testcases that have test names starting with uppercase when using gdb_test_multiple in a multi-line construct. gdb/testsuite/ChangeLog 2016-11-25 Luis Machado <lgustavo@codesourcery.com> Fix test names starting with uppercase throughout the files. * gdb/testsuite/gdb.cp/gdb2495.exp --- gdb/testsuite/gdb.cp/gdb2495.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 11/25/2016 08:54 PM, Luis Machado wrote: > This fixes offender testcases that have test names starting with uppercase > when using gdb_test_multiple in a multi-line construct. > > gdb/testsuite/ChangeLog > 2016-11-25 Luis Machado <lgustavo@codesourcery.com> > > Fix test names starting with uppercase throughout the files. > > * gdb/testsuite/gdb.cp/gdb2495.exp Drop "gdb/testsuite/", and LGTM, but ... > --- > gdb/testsuite/gdb.cp/gdb2495.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp > index dff5977..7e4dfa8 100644 > --- a/gdb/testsuite/gdb.cp/gdb2495.exp > +++ b/gdb/testsuite/gdb.cp/gdb2495.exp > @@ -95,7 +95,7 @@ gdb_test "info breakpoints" \ > > # Turn off this new behaviour. > gdb_test_multiple "set unwind-on-terminating-exception off" \ > - "Turn unwind-on-terminating-exception off" { > + "turn unwind-on-terminating-exception off" { > -re "$gdb_prompt $" {pass "set unwinn-on-terminating-exception off"} > timeout {fail "(timeout) set unwind-on-terminating-exception off"} > } ... I think this could just be: gdb_test "set unwind-on-terminating-exception off" "" ? I'd end up fixing two extra things: - note the typo in the pass case: "unwiNN" - odd "(timeout)" print position. timeout handling it not necessary at all with gdb_test_multiple, even. Thanks, Pedro Alves
On 11/30/2016 02:47 PM, Pedro Alves wrote: > On 11/25/2016 08:54 PM, Luis Machado wrote: >> This fixes offender testcases that have test names starting with uppercase >> when using gdb_test_multiple in a multi-line construct. >> >> gdb/testsuite/ChangeLog >> 2016-11-25 Luis Machado <lgustavo@codesourcery.com> >> >> Fix test names starting with uppercase throughout the files. >> >> * gdb/testsuite/gdb.cp/gdb2495.exp > > Drop "gdb/testsuite/", and LGTM, but ... > >> --- >> gdb/testsuite/gdb.cp/gdb2495.exp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp >> index dff5977..7e4dfa8 100644 >> --- a/gdb/testsuite/gdb.cp/gdb2495.exp >> +++ b/gdb/testsuite/gdb.cp/gdb2495.exp >> @@ -95,7 +95,7 @@ gdb_test "info breakpoints" \ >> >> # Turn off this new behaviour. >> gdb_test_multiple "set unwind-on-terminating-exception off" \ >> - "Turn unwind-on-terminating-exception off" { >> + "turn unwind-on-terminating-exception off" { >> -re "$gdb_prompt $" {pass "set unwinn-on-terminating-exception off"} >> timeout {fail "(timeout) set unwind-on-terminating-exception off"} >> } > > ... I think this could just be: > > gdb_test "set unwind-on-terminating-exception off" "" > gdb_test_no_output then? It doesn't check for any output other than the prompt. > ? > > I'd end up fixing two extra things: > > - note the typo in the pass case: "unwiNN" > - odd "(timeout)" print position. timeout handling it not necessary > at all with gdb_test_multiple, even. I see more occurrences of expecting timeouts where they're not needed. I'll fix in a follow-on patch.
On 11/30/2016 09:05 PM, Luis Machado wrote: > gdb_test_no_output then? It doesn't check for any output other than the > prompt. '-re "$gdb_prompt $"' implicitly matches whatever might come before the prompt too, but yeah, that'd be better even, assuming the command doesn't output anything, which is probably true. OK with that change. > >> ? >> >> I'd end up fixing two extra things: >> >> - note the typo in the pass case: "unwiNN" >> - odd "(timeout)" print position. timeout handling it not necessary >> at all with gdb_test_multiple, even. > > I see more occurrences of expecting timeouts where they're not needed. > I'll fix in a follow-on patch. Thanks much! Thanks, Pedro Alves
diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp index dff5977..7e4dfa8 100644 --- a/gdb/testsuite/gdb.cp/gdb2495.exp +++ b/gdb/testsuite/gdb.cp/gdb2495.exp @@ -95,7 +95,7 @@ gdb_test "info breakpoints" \ # Turn off this new behaviour. gdb_test_multiple "set unwind-on-terminating-exception off" \ - "Turn unwind-on-terminating-exception off" { + "turn unwind-on-terminating-exception off" { -re "$gdb_prompt $" {pass "set unwinn-on-terminating-exception off"} timeout {fail "(timeout) set unwind-on-terminating-exception off"} }