nscd: Remove unused typedef and variable.

Message ID 87r42hclpc.fsf@gnu.org
State Committed
Headers

Commit Message

Ludovic Courtès June 22, 2014, 9:55 a.m. UTC
  The attached patch removed the unused ‘thread_info_t’ typedef and the
‘thread_info’ variable from nscd.c.  The former conflicts with a GNU Mach
typedef, and the latter conflicts with a GNU Mach function declaration:
<https://lists.gnu.org/archive/html/bug-hurd/2014-06/msg00101.html>.

Tested on x86_64-linux-gnu.

Thanks,
Ludo’.

2014-06-22  Ludovic Courtès  <ludo@gnu.org>

	* nscd/nscd.c (thread_info_t): Remove typedef.
	(thread_info): Remove variable.
  

Comments

Ondrej Bilka June 22, 2014, 11:47 a.m. UTC | #1
On Sun, Jun 22, 2014 at 11:55:43AM +0200, Ludovic Courtès wrote:
> The attached patch removed the unused ‘thread_info_t’ typedef and the
> ‘thread_info’ variable from nscd.c.  The former conflicts with a GNU Mach
> typedef, and the latter conflicts with a GNU Mach function declaration:
> <https://lists.gnu.org/archive/html/bug-hurd/2014-06/msg00101.html>.
> 
> Tested on x86_64-linux-gnu.
> 
> Thanks,
> Ludo’.
> 
Looks ok so I commited it.
  
Ludovic Courtès June 23, 2014, 7:37 a.m. UTC | #2
Ondřej Bílka <neleai@seznam.cz> skribis:

> On Sun, Jun 22, 2014 at 11:55:43AM +0200, Ludovic Courtès wrote:
>> The attached patch removed the unused ‘thread_info_t’ typedef and the
>> ‘thread_info’ variable from nscd.c.  The former conflicts with a GNU Mach
>> typedef, and the latter conflicts with a GNU Mach function declaration:
>> <https://lists.gnu.org/archive/html/bug-hurd/2014-06/msg00101.html>.
>> 
>> Tested on x86_64-linux-gnu.
>> 
>> Thanks,
>> Ludo’.
>> 
> Looks ok so I commited it.

Thank you.

Ludo’.
  

Patch

diff --git a/nscd/nscd.c b/nscd/nscd.c
index 5680378..d4faa29 100644
--- a/nscd/nscd.c
+++ b/nscd/nscd.c
@@ -56,20 +56,6 @@ 
 
 #define PACKAGE _libc_intl_domainname
 
-/* Structure used by main() thread to keep track of the number of
-   active threads.  Used to limit how many threads it will create
-   and under a shutdown condition to wait till all in-progress
-   requests have finished before "turning off the lights".  */
-
-typedef struct
-{
-  int             num_active;
-  pthread_cond_t  thread_exit_cv;
-  pthread_mutex_t mutex;
-} thread_info_t;
-
-thread_info_t thread_info;
-
 int do_shutdown;
 int disabled_passwd;
 int disabled_group;