| Message ID | CAMXFM3veSy9SCa=Ke15zON_h+_TD7eK3k8QNS2mrqfBKDDs+vA@mail.gmail.com |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 28593 invoked by alias); 17 Feb 2016 21:05:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 28538 invoked by uid 89); 17 Feb 2016 21:05:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=20160218, 2016-02-18, hongjiu.lu@intel.com, hongjiuluintelcom X-HELO: mail-lb0-f180.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Vk6Y3afANi3Dm1eAmIhkoz8mef6imR2c8y199s6gcNM=; b=mhQynH+b98TegikjcA7pqV3PHjVw42iLhUP7DiFgBJFjdbS/votDdp/HMHJI9RWykU jocf2JbibRGZIuNBmjGOaSScgS3aLigs3ycAIvlPI3NZ83s+VXT1iQuNJjbXXJ7dbwP9 b/6UU3Aq9HSHK83REMJBMoA2APYVit8wbs+FWaQvGS/boihzJMmzaX+SFlF2ehdpfJT7 NGpmYnnxbpMwJR+3yNl2U0Au2xKsENbgkW1/WlNz1fhTrSv7KchaaljZa9ExU6iM8RIy wu6KeGcwdxHiMebb7qtEDTN95SYxZA+lS7Pyba7lX6hi9mnAaz0erdfSQZTVWfUHewlI JooA== X-Gm-Message-State: AG10YOSRSaulaVY05BARSPqbha15eB82vGvChDfpT3sEFMm585Vpqsn+tlKbzgTMfyaxhJLSNvxR9ZpcPBY1OQ== X-Received: by 10.112.161.225 with SMTP id xv1mr1679913lbb.127.1455743117521; Wed, 17 Feb 2016 13:05:17 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <CAMe9rOpCqmoSXE4+ci5p9PX-cCSrpTD=nJt4URYSSQNSSu47gg@mail.gmail.com> References: <CAMXFM3tML81iuKQMKRU-T4Fw0+=sYk0q_BNavMGagt21VcYvzQ@mail.gmail.com> <CAMe9rOp7BF2avdWbGTbsxuYQV_rmXSxzDUAwz+nHK-GhWqPKJA@mail.gmail.com> <CAMXFM3sG90jn3Em-REfaqtj3OGAjh51OcO=yn1qHqJ4aStkPrg@mail.gmail.com> <alpine.DEB.2.10.1602111641250.29940@digraph.polyomino.org.uk> <CAMXFM3uxH=0DHnwikPjs2AobQ0kxOqKg+j=CuOWX=RLB_i8hxg@mail.gmail.com> <CAMe9rOoWy+hqiCOKqFx0nOFVRT_kBETJ5hYE+cY6pFWUke=tkw@mail.gmail.com> <CAMXFM3vG1DNELfGaOOoUvRDGgrGWL4m3M8+5ngPg8RPnCLqUog@mail.gmail.com> <alpine.DEB.2.10.1602161347240.26462@digraph.polyomino.org.uk> <CAMXFM3tXQi0wRFNN1gyu-T3C7g_EWPxMfhK4wexADGtcPojNZg@mail.gmail.com> <alpine.DEB.2.10.1602171711080.18373@digraph.polyomino.org.uk> <CAMXFM3uYod=-mzjLnntwjtu5mAc3bt=pzSk6G7FiO_JHtpvTZQ@mail.gmail.com> <alpine.DEB.2.10.1602171842400.18373@digraph.polyomino.org.uk> <CAMXFM3tB9X7xVSau3ADnGw7_QZLUoY1wVwa0Y8FLDH34vwJJBQ@mail.gmail.com> <CAMe9rOpCqmoSXE4+ci5p9PX-cCSrpTD=nJt4URYSSQNSSu47gg@mail.gmail.com> From: Andrew Senkevich <andrew.n.senkevich@gmail.com> Date: Thu, 18 Feb 2016 00:04:47 +0300 Message-ID: <CAMXFM3veSy9SCa=Ke15zON_h+_TD7eK3k8QNS2mrqfBKDDs+vA@mail.gmail.com> Subject: Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions To: "H.J. Lu" <hjl.tools@gmail.com> Cc: Joseph Myers <joseph@codesourcery.com>, libc-alpha <libc-alpha@sourceware.org> Content-Type: text/plain; charset=UTF-8 |
Commit Message
Andrew Senkevich
Feb. 17, 2016, 9:04 p.m. UTC
2016-02-17 23:06 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>: > On Wed, Feb 17, 2016 at 11:30 AM, Andrew Senkevich > <andrew.n.senkevich@gmail.com> wrote: >> 2016-02-17 21:44 GMT+03:00 Joseph Myers <joseph@codesourcery.com>: >>> On Wed, 17 Feb 2016, Andrew Senkevich wrote: >>> >>>> Is attached version finally Ok for trunk? >>> >>> Please resubmit, with the coding style issues fixed and tests moved to >>> test-skeleton.c unless there's a reason they can't use it, after the >>> freeze is over. This is much too risky to consider during the freeze, and >>> would need to wait a while on master before any backports could be >>> considered (e.g. the new tests could break the testsuite build in some >>> configurations for unforeseen reasons). >> >> May be separate fix and tests to commit fix earlier? >> > > This is a good idea. Please submit a fix-only patch. 2016-02-18 Andrew Senkevich <andrew.senkevich@intel.com> H.J. Lu <hongjiu.lu@intel.com> [BZ #19590] * sysdeps/x86_64/fpu/svml_finite_alias.S (ALIAS_IMPL): Use PIC relocation. Ok to commit? -- WBR, Andrew
Comments
On Wed, Feb 17, 2016 at 1:04 PM, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote: > 2016-02-17 23:06 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>: >> On Wed, Feb 17, 2016 at 11:30 AM, Andrew Senkevich >> <andrew.n.senkevich@gmail.com> wrote: >>> 2016-02-17 21:44 GMT+03:00 Joseph Myers <joseph@codesourcery.com>: >>>> On Wed, 17 Feb 2016, Andrew Senkevich wrote: >>>> >>>>> Is attached version finally Ok for trunk? >>>> >>>> Please resubmit, with the coding style issues fixed and tests moved to >>>> test-skeleton.c unless there's a reason they can't use it, after the >>>> freeze is over. This is much too risky to consider during the freeze, and >>>> would need to wait a while on master before any backports could be >>>> considered (e.g. the new tests could break the testsuite build in some >>>> configurations for unforeseen reasons). >>> >>> May be separate fix and tests to commit fix earlier? >>> >> >> This is a good idea. Please submit a fix-only patch. > > 2016-02-18 Andrew Senkevich <andrew.senkevich@intel.com> > H.J. Lu <hongjiu.lu@intel.com> > > [BZ #19590] > * sysdeps/x86_64/fpu/svml_finite_alias.S (ALIAS_IMPL): Use PIC > relocation. > > diff --git a/sysdeps/x86_64/fpu/svml_finite_alias.S > b/sysdeps/x86_64/fpu/svml_finite_alias.S > index 0062fe4..2dcfc37 100644 > --- a/sysdeps/x86_64/fpu/svml_finite_alias.S > +++ b/sysdeps/x86_64/fpu/svml_finite_alias.S > @@ -23,8 +23,7 @@ > > #define ALIAS_IMPL(alias, target) \ > ENTRY (alias); \ > - call target; \ > - ret; \ > + jmp *target@GOTPCREL(%rip); \ > END (alias) > > .text > > > Ok to commit? > OK. Please leave BZ 19590 open until testcase is added. Thanks.
On Wed, 17 Feb 2016, H.J. Lu wrote:
> OK. Please leave BZ 19590 open until testcase is added.
No, when a bug is fixed it needs to be closed immediately as FIXED with
the milestone set accordingly, otherwise the list of fixed bugs in NEWS
will be wrong. The matter of the testcase needs to be tracked separately.
On Wed, Feb 17, 2016 at 1:44 PM, Joseph Myers <joseph@codesourcery.com> wrote: > On Wed, 17 Feb 2016, H.J. Lu wrote: > >> OK. Please leave BZ 19590 open until testcase is added. > > No, when a bug is fixed it needs to be closed immediately as FIXED with > the milestone set accordingly, otherwise the list of fixed bugs in NEWS > will be wrong. The matter of the testcase needs to be tracked separately. Open a new bug report for testcase.
On Wed, Feb 17, 2016 at 2:12 PM, H.J. Lu <hjl.tools@gmail.com> wrote: > On Wed, Feb 17, 2016 at 1:44 PM, Joseph Myers <joseph@codesourcery.com> wrote: >> On Wed, 17 Feb 2016, H.J. Lu wrote: >> >>> OK. Please leave BZ 19590 open until testcase is added. >> >> No, when a bug is fixed it needs to be closed immediately as FIXED with >> the milestone set accordingly, otherwise the list of fixed bugs in NEWS >> will be wrong. The matter of the testcase needs to be tracked separately. > > Open a new bug report for testcase. I checked in the fix for Andrew, resolved: https://sourceware.org/bugzilla/show_bug.cgi?id=19590 and opened: https://sourceware.org/bugzilla/show_bug.cgi?id=19654
diff --git a/sysdeps/x86_64/fpu/svml_finite_alias.S b/sysdeps/x86_64/fpu/svml_finite_alias.S index 0062fe4..2dcfc37 100644 --- a/sysdeps/x86_64/fpu/svml_finite_alias.S +++ b/sysdeps/x86_64/fpu/svml_finite_alias.S @@ -23,8 +23,7 @@ #define ALIAS_IMPL(alias, target) \ ENTRY (alias); \ - call target; \ - ret; \ + jmp *target@GOTPCREL(%rip); \ END (alias) .text