| Message ID | 87a9aavxdr.fsf@kepler.schwinge.homeip.net |
|---|---|
| State | Committed |
| Headers |
Return-Path: <x14314964@homiemail-mx23.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 2F27E360073 for <siddhesh@wilcox.dreamhost.com>; Thu, 22 May 2014 04:58:24 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id B6F9E63F46832; Thu, 22 May 2014 04:58:23 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 5AF0E63F46815 for <gdb@patchwork.siddhesh.in>; Thu, 22 May 2014 04:58:23 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-type; q=dns; s=default; b=u8TyL 9BASa4zR1cYrgcIpmH8jzhCudiwbMz+MNoJ/75oKno7Ppiu1TGDTmIVnDyqgcDrs EdD8mKPZolKAcAntG/vKdt9vZPM2u7ksQa0FZZu8DJFN03u/lea7FJgsRQ5Xqs32 hXedYz0dfFmi1hujssY6Ht8PjOQyMnCznOpoDI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-type; s=default; bh=tzYHVVO/J0t 5iXZOEzZI2IWbBrU=; b=k/TDIpQUvZK+8hoPfaJSknIivV9XWe8+KUjvHnEEQDa fIZzUFyLjpYuBg3SixaufvoMpr9oYLAAnvT7eHz2X3ji4E0c7MpF7qviAivps2bL jJHNcVv4L5fxfmAu0a49NlinD0ifdfrw2/uFzuq1whSEPA+8FrOV+OvixSzH29ew = Received: (qmail 1557 invoked by alias); 22 May 2014 11:58:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-gdb=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 1536 invoked by uid 89); 22 May 2014 11:58:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 May 2014 11:58:08 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WnRdK-0003da-Jm from Thomas_Schwinge@mentor.com ; Thu, 22 May 2014 04:58:02 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 22 May 2014 04:58:02 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Thu, 22 May 2014 12:58:00 +0100 From: Thomas Schwinge <thomas@codesourcery.com> To: Gary Benson <gbenson@redhat.com>, Andrew Burgess <aburgess@broadcom.com> CC: Ian Lance Taylor <iant@google.com>, gcc-patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>, <gdb-patches@sourceware.org> Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special. In-Reply-To: <20140514142016.GA32660@blade.nx> References: <1399646123-9960-1-git-send-email-aburgess@broadcom.com> <CAKOQZ8zCbzpkwR_HkraUsNoDHEPt2pUXsQEk8kf_Mc43DGTHJw@mail.gmail.com> <536E7A72.1040203@broadcom.com> <CAKOQZ8wBvHe6KdWDuipPmSu=6hrJZ88xDHMyP_B2sHc-4L3qNg@mail.gmail.com> <20140514090125.GA4974@blade.nx> <537337AF.3020806@broadcom.com> <20140514142016.GA32660@blade.nx> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu) Date: Thu, 22 May 2014 13:57:52 +0200 Message-ID: <87a9aavxdr.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-DH-Original-To: gdb@patchwork.siddhesh.in |
Commit Message
Thomas Schwinge
May 22, 2014, 11:57 a.m. UTC
Hi! On Wed, 14 May 2014 15:20:16 +0100, Gary Benson <gbenson@redhat.com> wrote: > Andrew Burgess wrote: > > On 14/05/2014 10:01 AM, Gary Benson wrote: > > > Ian Lance Taylor wrote: > > > > Andrew Burgess <aburgess@broadcom.com> wrote: > > > > > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: > > > > > > Andrew Burgess <aburgess@broadcom.com> wrote: > > > > > > > if ((AUTO_DEMANGLING || GNU_DEMANGLING)) > > > > > > > { > > > > > > > success = gnu_special (work, &mangled, &decl); > > > > > > > + if (!success) > > > > > > > + { > > > > > > > + delete_work_stuff (work); > > > > > > > + string_delete (&decl); > > > > > > > + } > > > > > > > > > > > > > > This patch is OK. > > > > > > Andrew, would you like me to commit this? > > > > Yes please. > > Done: > https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=210425 In GCC, I'm consistenly seeing the following new failure: ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected FAIL at line 4350, options --format=auto --no-params: in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z out: (null) exp: ./test-demangle: 895 tests, 1 failures make[2]: *** [check-cplus-dem] Error 1 The patch was committed incompletely; I added the missing last line in r210803: commit 8207b6a22d5955c41109399cb09f0af661a593ea Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4> AuthorDate: Thu May 22 11:56:45 2014 +0000 Commit: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4> CommitDate: Thu May 22 11:56:45 2014 +0000 Fix test in libiberty/testsuite/demangle-expected. libiberty/ * testsuite/demangle-expected: Fix last commit. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@210803 138bc75d-0d04-0410-961f-82ee72b054a4 --- libiberty/ChangeLog | 4 ++++ libiberty/testsuite/demangle-expected | 1 + 2 files changed, 5 insertions(+) Grüße, Thomas
Comments
Hi Thomas, Thomas Schwinge wrote: > In GCC, I'm consistenly seeing the following new failure: > > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected > FAIL at line 4350, options --format=auto --no-params: > in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > out: (null) > exp: > ./test-demangle: 895 tests, 1 failures > make[2]: *** [check-cplus-dem] Error 1 > > The patch was committed incompletely; I added the missing last line in > r210803: [snip] > @@ -4347,3 +4347,4 @@ void post<std::function<void ()> >(std::function<void ()>&&)::{lambda()#1}*& std > --format=auto --no-params > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z I thought that extra line was a mistake; I thought each test was precisely three lines: # options # input to be demangled # expected output What is the extra line here? Thanks, Gary
Hi Gary! On Thu, 22 May 2014 17:02:08 +0100, Gary Benson <gbenson@redhat.com> wrote: > Thomas Schwinge wrote: > > In GCC, I'm consistenly seeing the following new failure: > > > > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected > > FAIL at line 4350, options --format=auto --no-params: > > in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > out: (null) > > exp: > > ./test-demangle: 895 tests, 1 failures > > make[2]: *** [check-cplus-dem] Error 1 > > > > The patch was committed incompletely; I added the missing last line in > > r210803: > [snip] > > @@ -4347,3 +4347,4 @@ void post<std::function<void ()> >(std::function<void ()>&&)::{lambda()#1}*& std > > --format=auto --no-params > > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > I thought that extra line was a mistake; I thought each test was > precisely three lines: > > # options > # input to be demangled > # expected output > > What is the extra line here? I too had to look it up -- see the explanation at the beginning of the file: # --no-params There are two lines of expected output; the first # is with DMGL_PARAMS, the second is without it. Grüße, Thomas
Thomas Schwinge wrote: > On Thu, 22 May 2014 17:02:08 +0100, Gary Benson <gbenson@redhat.com> wrote: > > Thomas Schwinge wrote: > > > In GCC, I'm consistenly seeing the following new failure: > > > > > > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected > > > FAIL at line 4350, options --format=auto --no-params: > > > in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > > out: (null) > > > exp: > > > ./test-demangle: 895 tests, 1 failures > > > make[2]: *** [check-cplus-dem] Error 1 > > > > > > The patch was committed incompletely; I added the missing last line in > > > r210803: > > [snip] > > > @@ -4347,3 +4347,4 @@ void post<std::function<void ()> >(std::function<void ()>&&)::{lambda()#1}*& std > > > --format=auto --no-params > > > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > > +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > > > I thought that extra line was a mistake; I thought each test was > > precisely three lines: > > > > # options > > # input to be demangled > > # expected output > > > > What is the extra line here? > > I too had to look it up -- see the explanation at the beginning of > the file: > > # --no-params There are two lines of expected output; the first > # is with DMGL_PARAMS, the second is without it. Ah, I missed that. Thank you for fixing this! Gary -- http://gbenson.net/
On 05/22/2014 12:57 PM, Thomas Schwinge wrote: > On Wed, 14 May 2014 15:20:16 +0100, Gary Benson <gbenson@redhat.com> wrote: >> Andrew Burgess wrote: >>> On 14/05/2014 10:01 AM, Gary Benson wrote: >>>> Ian Lance Taylor wrote: >>>>> This patch is OK. >>>> >>>> Andrew, would you like me to commit this? >>> >>> Yes please. >> >> Done: >> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=210425 > ... > Fix test in libiberty/testsuite/demangle-expected. > > libiberty/ > * testsuite/demangle-expected: Fix last commit. Thanks. I've merged this and Andrew's patch to the binutils-gdb git repo.
diff --git libiberty/ChangeLog libiberty/ChangeLog index 7156be7..7b25c7e 100644 --- libiberty/ChangeLog +++ libiberty/ChangeLog @@ -1,3 +1,7 @@ +2014-05-22 Thomas Schwinge <thomas@codesourcery.com> + + * testsuite/demangle-expected: Fix last commit. + 2014-05-14 Andrew Burgess <aburgess@broadcom.com> * cplus-dmem.c (internal_cplus_demangle): Free any resources diff --git libiberty/testsuite/demangle-expected libiberty/testsuite/demangle-expected index 823a1c4..864ee7e 100644 --- libiberty/testsuite/demangle-expected +++ libiberty/testsuite/demangle-expected @@ -4347,3 +4347,4 @@ void post<std::function<void ()> >(std::function<void ()>&&)::{lambda()#1}*& std --format=auto --no-params _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z