Message ID | 20140514203018.A64A72C3A54@topped-with-meat.com |
---|---|
State | Committed |
Headers |
Return-Path: <x14307373@homiemail-mx21.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (peon2454.g.dreamhost.com [208.113.200.127]) by wilcox.dreamhost.com (Postfix) with ESMTP id A132636007B for <siddhesh@wilcox.dreamhost.com>; Wed, 14 May 2014 13:30:26 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14307373) id 284C4193211D; Wed, 14 May 2014 13:30:26 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 907E2175348A for <glibc@patchwork.siddhesh.in>; Wed, 14 May 2014 13:30:25 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:subject:message-id:date; q= dns; s=default; b=qwqnc9J3PdAhjiw4BKlB5R8MaX5xx6MCKXTB6tziQsceiz lJleHQfPbSk1K+ERJljTuLHhJq2zLNF4ocIQksiP/K23QkB905kMg0ijlYXtRQHi jSdgBO1hRhvOfdaSUXxIDGsjKfQI2OhWBLCIkEHHy7R7PDlp6PYACfNTNCgqw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:subject:message-id:date; s= default; bh=nrvt7dEq2f60tNqiHy58UNwV1BE=; b=PSQpjhEy90xn6zNOjnz1 LTrMIvT1QuK8mbRqGV1S9YYQefUfGc4tWclqzMR4bkNN7uyiEcj9ys1rVIJAvxqT 3KWGnh2P5hLvBgwC7tZz7WkDI2elRQ7ZnBYafiH+7sDeVurDkgtdtuPqpAFs+2Ie fPuOQqBAlcJrwBEEs1NprSw= Received: (qmail 12196 invoked by alias); 14 May 2014 20:30:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-glibc=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 12156 invoked by uid 89); 14 May 2014 20:30:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath <roland@hack.frob.com> To: "GNU C. Library" <libc-alpha@sourceware.org> Subject: [COMMITTED PATCH] Fix powerpc fork after i386 reorganization. Message-Id: <20140514203018.A64A72C3A54@topped-with-meat.com> Date: Wed, 14 May 2014 13:30:18 -0700 (PDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=HrjlRSjS c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=_UMSD0gc3EAA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=KS_Sj8JlSlRK_unw3vsA:9 a=CjuIK1q_8ugA:10 X-DH-Original-To: glibc@patchwork.siddhesh.in |
Commit Message
Roland McGrath
May 14, 2014, 8:30 p.m. UTC
When I was fiddling with the i386 fork.[ch] I failed to notice the powerpc dependency on the old file. This should fix it, but is untested. * sysdeps/unix/sysv/linux/powerpc/fork.h: New file. * nptl/sysdeps/unix/sysv/linux/powerpc/fork.c: File removed.
Comments
On 14-05-2014 17:30, Roland McGrath wrote: > When I was fiddling with the i386 fork.[ch] I failed to notice the powerpc > dependency on the old file. This should fix it, but is untested. > > * sysdeps/unix/sysv/linux/powerpc/fork.h: New file. > * nptl/sysdeps/unix/sysv/linux/powerpc/fork.c: File removed. > > --- a/nptl/sysdeps/unix/sysv/linux/powerpc/fork.c > +++ /dev/null > @@ -1 +0,0 @@ > -#include "../i386/fork.c" > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/powerpc/fork.h > @@ -0,0 +1 @@ > +#include <sysdeps/unix/sysv/linux/i386/fork.h> > Thanks for checking on this. Now you have started this cleanup, I think it it time to cleanup powerpc code as well. I'll check on this.
On Wed, 14 May 2014, Roland McGrath wrote: > When I was fiddling with the i386 fork.[ch] I failed to notice the powerpc > dependency on the old file. This should fix it, but is untested. MIPS is using it as well.
> Thanks for checking on this. Now you have started this cleanup, I think > it it time to cleanup powerpc code as well. I'll check on this. I'd intended to get to the other machines eventually, though to leave the testing to machine maintainers and get their approval before committing. But if you want to do the legwork for powerpc, please do! I think these are the steps you'll need to do to mirror what I've done for x86_64 so far: 1. Merge vfork.S code; remove pt-vfork.S entirely. 2. Merge clone.S code. 3. Merge Makefile and Versions files. 4. Move bits/local_lim.h to sysdeps/unix/sysv/linux/ 5. Move bits/{pthreadtypes,semaphore}.h to sysdeps/powerpc/nptl/. 6. Move everything else to sysdeps/unix/sysv/linux/ Thanks, Roland
On Wed, 14 May 2014, Roland McGrath wrote:
> 6. Move everything else to sysdeps/unix/sysv/linux/
There's at least one piece done for ARM but missing for x86_64: moving the
ABI baselines from sysdeps/unix/sysv/linux/x86_64/{64,x32}/nptl out of the
nptl subdirectory.
> There's at least one piece done for ARM but missing for x86_64: moving the > ABI baselines from sysdeps/unix/sysv/linux/x86_64/{64,x32}/nptl out of the > nptl subdirectory. Yes, I have not finished x86 yet.
On Wed, 2014-05-14 at 21:05 +0000, Joseph S. Myers wrote: > On Wed, 14 May 2014, Roland McGrath wrote: > > > When I was fiddling with the i386 fork.[ch] I failed to notice the powerpc > > dependency on the old file. This should fix it, but is untested. > > MIPS is using it as well. Roland, It looks like you changed this for MIPS but my build is still failing: In file included from ../sysdeps/unix/sysv/linux/mips/fork.h:1:0, from cxa_finalize.c:22: ../sysdeps/unix/sysv/linux/i386/fork.h:27:23: fatal error: fork.h: No such file or directory #include_next <fork.h> ^ compilation terminated. I am not sure what fork.h the include_next should be finding. Steve Ellcey sellcey@mips.com
--- a/nptl/sysdeps/unix/sysv/linux/powerpc/fork.c +++ /dev/null @@ -1 +0,0 @@ -#include "../i386/fork.c" --- /dev/null +++ b/sysdeps/unix/sysv/linux/powerpc/fork.h @@ -0,0 +1 @@ +#include <sysdeps/unix/sysv/linux/i386/fork.h>