Message ID | 1395059004-20960-6-git-send-email-will.newton@linaro.org |
---|---|
State | Rejected |
Headers |
Return-Path: <x14307373@homiemail-mx23.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (caibbdcaabja.dreamhost.com [208.113.200.190]) by wilcox.dreamhost.com (Postfix) with ESMTP id 1F7AE3600B0 for <siddhesh@wilcox.dreamhost.com>; Mon, 17 Mar 2014 05:24:29 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14307373) id D509361C26139; Mon, 17 Mar 2014 05:24:28 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id AFCD861C1E5B4 for <glibc@patchwork.siddhesh.in>; Mon, 17 Mar 2014 05:24:28 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=PAtGm73t+A7ZPRptV9xv9oLjGJDgDjJ PlwNID0uc8h5FDvTneP+UTC8j2go5GABh8HzF6JMwiKuiGYxtfAgdYVzMvWZWymJ jpSVAuj0TBUhIKtJjOwZzrqWp6eLBVf6KTx+DFjPKL0XFnOdKC26afar2knYmkCV 2jgA24LaTJjM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=M6Opss4CNBA+eKb/T5cwNZBQvbI=; b=l2CgC fgePjKG4KM3Y+hQaJB/AzWIJn4gFCuca5Rc+u2uYc/5arBS6a2Wwn4QNX927qqMy P3oqoi1h4iD1h/MrITbDMsYWQAgFMGTfdpX6uQ+Vr3AbCWJ3otYRe/yw4IuvabxR pjUE0AXa4vLmwxiTMQ7sjPLAEXvOn9xonigIWo= Received: (qmail 19175 invoked by alias); 17 Mar 2014 12:23:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-glibc=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 18949 invoked by uid 89); 17 Mar 2014 12:23:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f182.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=mmIazm0WFDnXcBTupT2Ke2OXmhonEda1ZqboySaUbmA=; b=mjzuhvC6uUohsu4hViw6707gieuflaSwPw6kmNNRy59eOo4GTFH/WWvTvxPJWDvUd+ BfUzxVnZFRub/hD6VG1uq+7Jf3TUa49bJAfiszLoyhelLRTnSUElSvb3iTnD3gHnvYgk 3zmt5VxnCYv0QOGaN/0RjN0dGRCWVgeP2nyY4g1jsEAXTtR5rF0GesSIvkGbYUhjh3nw 1g+MpEvX+kDVMjAXwDx45YlLPP13HvBVumemhc8nJGCx/sfAjdEZb8Q9HLymZHzg9lCT D94Wt2IoUmjXbX9+J2jM0ieLiVrl1kr4xTuXhOyg4xIfLOaut2EArU2PIx4yCkT7Ljum 0b6Q== X-Gm-Message-State: ALoCoQnQIBtq9XRIVuoUGG5ogzosF+ThCXIsTcAKOJwT8DGBEVVrkpBvoMHe36pawx3OghyJBTKC X-Received: by 10.194.236.232 with SMTP id ux8mr1992956wjc.46.1395059015963; Mon, 17 Mar 2014 05:23:35 -0700 (PDT) From: Will Newton <will.newton@linaro.org> To: libc-alpha@sourceware.org Subject: [PATCH 6/7] malloc/obstack.h: Remove long obsolete NeXT gcc conditional Date: Mon, 17 Mar 2014 12:23:23 +0000 Message-Id: <1395059004-20960-6-git-send-email-will.newton@linaro.org> In-Reply-To: <1395059004-20960-1-git-send-email-will.newton@linaro.org> References: <1395059004-20960-1-git-send-email-will.newton@linaro.org> X-DH-Original-To: glibc@patchwork.siddhesh.in |
Commit Message
Will Newton
March 17, 2014, 12:23 p.m. UTC
This fixes a warning introduced with -Wundef, but in general there is no point supporting this long obsolete configuration. 2014-03-17 Will Newton <will.newton@linaro.org> * malloc/obstack.h: Remove conditional for supporting ancient NeXT gcc version. --- malloc/obstack.h | 7 ------- 1 file changed, 7 deletions(-)
Comments
On Mon, 17 Mar 2014, Will Newton wrote: > This fixes a warning introduced with -Wundef, but in general there > is no point supporting this long obsolete configuration. Have you confirmed that it's outside the scope of what gnulib tries to support (since this code is shared with gnulib - the only reason for glibc headers to support GCC versions before 2.7, as they didn't support any platforms now supported by glibc)?
On 17 March 2014 12:32, Joseph S. Myers <joseph@codesourcery.com> wrote: > On Mon, 17 Mar 2014, Will Newton wrote: > >> This fixes a warning introduced with -Wundef, but in general there >> is no point supporting this long obsolete configuration. > > Have you confirmed that it's outside the scope of what gnulib tries to > support (since this code is shared with gnulib - the only reason for glibc > headers to support GCC versions before 2.7, as they didn't support any > platforms now supported by glibc)? It's not clear to me exactly which platforms gnulib supports but NeXTStep is not in the list of target platforms in the gnulib docs. How are changes to this code handled? It doesn't appear that there is a regular sync of code in either direction.
On Mon, 17 Mar 2014, Will Newton wrote: > On 17 March 2014 12:32, Joseph S. Myers <joseph@codesourcery.com> wrote: > > On Mon, 17 Mar 2014, Will Newton wrote: > > > >> This fixes a warning introduced with -Wundef, but in general there > >> is no point supporting this long obsolete configuration. > > > > Have you confirmed that it's outside the scope of what gnulib tries to > > support (since this code is shared with gnulib - the only reason for glibc > > headers to support GCC versions before 2.7, as they didn't support any > > platforms now supported by glibc)? > > It's not clear to me exactly which platforms gnulib supports but > NeXTStep is not in the list of target platforms in the gnulib docs. > How are changes to this code handled? It doesn't appear that there is > a regular sync of code in either direction. In principle, code from glibc should be updated in gnulib via srclist-update. In practice, all the $LIBCSRC entries in srclist.txt are commented out at present - and there are many files in gnulib with comments stating "This file is part of the GNU C Library." (or similar, possibly with the phrase "GNU C Library" split over two lines - something to watch out for when identifying such files) and no mention in srclist.txt at all. It would be a useful project to identify all gnulib files based on glibc and merge the individual logical changes to those files in gnulib back to glibc, so that the files can be fully in sync again. Where the changes clearly do not affect builds as part of glibc, getting them into glibc shouldn't involve more than a routine coding style review.
diff --git a/malloc/obstack.h b/malloc/obstack.h index 85472f9..0fd623e 100644 --- a/malloc/obstack.h +++ b/malloc/obstack.h @@ -249,13 +249,6 @@ extern int obstack_exit_failure; #define obstack_memory_used(h) _obstack_memory_used (h) #if defined __GNUC__ -/* NextStep 2.0 cc is really gcc 1.93 but it defines __GNUC__ = 2 and - does not implement __extension__. But that compiler doesn't define - __GNUC_MINOR__. */ -# if __GNUC__ < 2 || (__NeXT__ && !__GNUC_MINOR__) -# define __extension__ -# endif - /* For GNU C, if not -traditional, we can define these macros to compute all args only once without using a global variable.