diff mbox series

[RFC,06/34] hurd: Swap around two function calls

Message ID 20230319151017.531737-7-bugaevc@gmail.com
State Committed, archived
Headers
Series The rest of the x86_64-gnu port |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Sergey Bugaev March 19, 2023, 3:09 p.m. UTC 
  ...to keep `sigexc' port initialization in one place, and match what the
comments say.

No functional change.

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
---
 hurd/hurdfault.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Samuel Thibault April 2, 2023, 10:54 p.m. UTC | #1 
Applied, thanks!

Sergey Bugaev, le dim. 19 mars 2023 18:09:49 +0300, a ecrit:
> ...to keep `sigexc' port initialization in one place, and match what the
> comments say.
> 
> No functional change.
> 
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
>  hurd/hurdfault.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hurd/hurdfault.c b/hurd/hurdfault.c
> index a81e7280..4340897d 100644
> --- a/hurd/hurdfault.c
> +++ b/hurd/hurdfault.c
> @@ -174,14 +174,14 @@ _hurdsig_fault_init (void)
>    err = __mach_port_allocate (__mach_task_self (),
>  			      MACH_PORT_RIGHT_RECEIVE, &sigexc);
>    assert_perror (err);
> -  err = __mach_port_allocate (__mach_task_self (),
> -			      MACH_PORT_RIGHT_RECEIVE, &forward_sigexc);
> +  err = __mach_port_insert_right (__mach_task_self (), sigexc,
> +				  sigexc, MACH_MSG_TYPE_MAKE_SEND);
>    assert_perror (err);
>  
>    /* Allocate a port to receive the exception msgs forwarded
>       from the proc server.  */
> -  err = __mach_port_insert_right (__mach_task_self (), sigexc,
> -				  sigexc, MACH_MSG_TYPE_MAKE_SEND);
> +  err = __mach_port_allocate (__mach_task_self (),
> +			      MACH_PORT_RIGHT_RECEIVE, &forward_sigexc);
>    assert_perror (err);
>  
>    /* Set the queue limit for this port to just one.  The proc server will
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/hurd/hurdfault.c b/hurd/hurdfault.c
index a81e7280..4340897d 100644
--- a/hurd/hurdfault.c
+++ b/hurd/hurdfault.c
@@ -174,14 +174,14 @@  _hurdsig_fault_init (void)
   err = __mach_port_allocate (__mach_task_self (),
 			      MACH_PORT_RIGHT_RECEIVE, &sigexc);
   assert_perror (err);
-  err = __mach_port_allocate (__mach_task_self (),
-			      MACH_PORT_RIGHT_RECEIVE, &forward_sigexc);
+  err = __mach_port_insert_right (__mach_task_self (), sigexc,
+				  sigexc, MACH_MSG_TYPE_MAKE_SEND);
   assert_perror (err);
 
   /* Allocate a port to receive the exception msgs forwarded
      from the proc server.  */
-  err = __mach_port_insert_right (__mach_task_self (), sigexc,
-				  sigexc, MACH_MSG_TYPE_MAKE_SEND);
+  err = __mach_port_allocate (__mach_task_self (),
+			      MACH_PORT_RIGHT_RECEIVE, &forward_sigexc);
   assert_perror (err);
 
   /* Set the queue limit for this port to just one.  The proc server will