Message ID | tencent_824259CC97B22A1FAFA8A391886306134208@qq.com |
---|---|
State | New |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7833385841E for <patchwork@sourceware.org>; Tue, 21 Mar 2023 12:25:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7833385841E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679401518; bh=zJYvs39j00b/2ZdtR3VVNChYqO/+7h1mksKljIPHWwo=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=uiK4lN/YqEXAC/DvDotcpfzHkIw5I29Eh4hPeXGyzgMQV1yQzrH2Ov57sAdRIr6N4 MDuJP8L0NP+9UkZsb9Tt0E1rDk/2F4voWme7pQnfX2i/IF4hSJh+zBtVcSaXy/yjTz vTYUkXO5ThteJPT/ZOF+r9yKVO7YDns/t1ug98bY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from out162-62-58-211.mail.qq.com (out162-62-58-211.mail.qq.com [162.62.58.211]) by sourceware.org (Postfix) with ESMTPS id DC4203858D37 for <libc-alpha@sourceware.org>; Tue, 21 Mar 2023 12:24:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC4203858D37 Received: from localhost.localdomain ([39.156.73.13]) by newxmesmtplogicsvrszc2-1.qq.com (NewEsmtp) with SMTP id 6328102A; Tue, 21 Mar 2023 20:24:50 +0800 X-QQ-mid: xmsmtpt1679401490tsv59shqi Message-ID: <tencent_824259CC97B22A1FAFA8A391886306134208@qq.com> X-QQ-XMAILINFO: OKkKo7I1HxIeNtd/nnxKDUaCJqiLMq3cxeSidQkVq9JGPUWrN1aMWE7ds2TkXV R5rNWG6evC62bzEovYX9EcqaYMJhVyCbmjd2WKO6dg38y3f9EXkznQUnPYnDR0+tPPDubZGTp0G5 b3WqbamVYCzuY5Ow41gQDdlbOC//0vBuviZNj21KOoEx1vhn2ujQ4T+JXnwcRdpcq602fctLUNK6 /tr2aYrZ9NaFbcROvzxoIqH0/N7mtGO7tWTxi5ruYbY/qiDEFi6Jfbzjs5Mb0E/fsz6kReRyW1+P QvoFtZV59Hcrgm/hxbs5jfu5Y+NDzgkIOL1EUM/FmUgjH09+YQcCTPBeM+2jrVFVuKN6mv/+9j2k F63VfqzrtIFj+FzTnpeWceD/YQwGL1wVb0NzrAdZNYTbfpmltmYtj27dSK25RWP6d+H+rOjC+4kA dhtOCQE36GZ2KbarK8YvXvzuFBzEwI4dHAubdsw3S4T00ZQw7Hx0Dogjzs3jOjZ7cRcBPodg4m5E Qlec4kaxCLENuWIRhTnk77Uuiu3ZTG3bCFLWXaP0xTcmPaGSyEE/INlbvMk0t4tb0xBOrpl2sc1l V+bK95uPql9ev2l+O4AbewWnL4v2ua0kwGorWaRzFLWIs/F0AyGL5EFBKR4bzJLj9Pe5ffe8A41x zdAy/XCLvLaQP8XPIPx6gENVyxeqnk6sCDSTKYgKcnqIbXgwnuLpdA+9CNqOQwiVVwFgR+5q8boC 5onYxYL9SRyasy4+blP2XI+QtNQzXJsF3Jvx8B7wKx6VB//dO1ZRGh9P7sO8SS0rwZEudMaPYnH/ FxO65X26rkN2mbw6uMaINjdOJQwjA9bpHQ/ycKsEBuIs+0O1Mv6rU7h1R55cdHuessgpPcNu8yDc h2U6z9nKEvMfXX3D8P0O6MRbEUaaRnECALHi+t8w70+kAqSNZ6pqh2XjmyOAK4qf6nly7hAc648y hJEig+b/WsR/lQ2424QZiu4XX4ktiyUvwOqPL+tiwmfSDffOnwLxGGIL7Tsv6f To: libc-alpha@sourceware.org Cc: rongtao@cestc.cn, rtoax@foxmail.com Subject: [PATCH] Add config.log to .gitignore Date: Tue, 21 Mar 2023 20:24:48 +0800 X-OQ-MSGID: <20230321122448.98076-1-rtoax@foxmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_20, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HELO_DYNAMIC_IPADDR, RCVD_IN_DNSWL_NONE, RDNS_DYNAMIC, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Rong Tao via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Rong Tao <rtoax@foxmail.com> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Add config.log to .gitignore
|
|
Checks
Context | Check | Description |
---|---|---|
dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
dj/TryBot-32bit | success | Build for i686 |
Commit Message
荣涛
March 21, 2023, 12:24 p.m. UTC
From: Rong Tao <rongtao@cestc.cn> Ignore generated config.log log file. Signed-off-by: Rong Tao <rongtao@cestc.cn> --- .gitignore | 1 + 1 file changed, 1 insertion(+)
Comments
On Tue, 2023-03-21 at 20:24 +0800, Rong Tao via Libc-alpha wrote: > From: Rong Tao <rongtao@cestc.cn> > > Ignore generated config.log log file. How the config.log file could ever be here? We are saying: The GNU C Library cannot be compiled in the source directory. You must build it in a separate build directory. in the README file. > > Signed-off-by: Rong Tao <rongtao@cestc.cn> > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 07d4a129e5dc..115d50ef48d6 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -15,6 +15,7 @@ copying.* > glibc-* > > configparms > +config.log > > ieeetest > regex
On 2023-03-21 10:10 AM, 荣涛 via Libc-alpha wrote: >> How the config.log file could ever be here? > You are right, sorry, my mistake. I think the patch is desirable anyway. If someone makes a mistake and runs configure in the source directory, configure errors out, but it does so *after* creating config.log in the source directory. If this hypothetical someone goes on to create a separate build directory and do some hacking, and eventually runs 'git commit -a' without carefully checking what files are new or modified in the source directory, config.log could get added to the commit. Adding config.log to .gitignore protects against this chain of human errors. zw
On Wed, 2023-03-22 at 12:01 -0400, Zack Weinberg via Libc-alpha wrote: > On 2023-03-21 10:10 AM, 荣涛 via Libc-alpha wrote: > > > How the config.log file could ever be here? > > You are right, sorry, my mistake. > > I think the patch is desirable anyway. If someone makes a mistake and > runs configure in the source directory, configure errors out, but it > does so *after* creating config.log in the source directory. If this > hypothetical someone goes on to create a separate build directory and > do some hacking, and eventually runs 'git commit -a' without carefully > checking what files are new or modified in the source directory, > config.log could get added to the commit. Adding config.log to > .gitignore protects against this chain of human errors. I guess you mean "git add .", not "git commit -a". The latter won't add config.log even it's there. I'll not object if the others think this patch can prevent a human error from "git add .", but I just want to say "don't use `git add .`, unless, maybe, you've visually inspected the output of `git status`".
On 2023-03-22 12:26 PM, Xi Ruoyao wrote: > On Wed, 2023-03-22 at 12:01 -0400, Zack Weinberg via Libc-alpha wrote: >> On 2023-03-21 10:10 AM, 荣涛 via Libc-alpha wrote: >>>> How the config.log file could ever be here? >>> You are right, sorry, my mistake. >> >> I think the patch is desirable anyway. If someone makes a mistake [...] > > I guess you mean "git add .", not "git commit -a". The latter won't add > config.log even it's there. Yes, probably... > I'll not object if the others think this patch can prevent a human error > from "git add .", but I just want to say "don't use `git add .`, unless, > maybe, you've visually inspected the output of `git status`". Yes, that should be the advice for contributors, but mechanical backstops against human error are a good idea regardless. I actually got into an argument with one of my coworkers once, over exactly what "git add" does, that only ended when we discovered he had become so habituated to typing "git add ." that he didn't even realize that that was what he was doing. zw
diff --git a/.gitignore b/.gitignore index 07d4a129e5dc..115d50ef48d6 100644 --- a/.gitignore +++ b/.gitignore @@ -15,6 +15,7 @@ copying.* glibc-* configparms +config.log ieeetest regex