diff mbox series

Update python-helper.exp for type allocation changes

Message ID 20230320161943.1494343-1-tromey@adacore.com
State New
Headers
Series Update python-helper.exp for type allocation changes |

Commit Message

Tom Tromey March 20, 2023, 4:19 p.m. UTC 
  The type allocation changes introduced a failure in python-helper.exp
that I did not notice.  The bug is that, with these patches,
arch-allocated integer types have a TYPE_SPECIFIC_INT object attached.
This patch updates the test to allow this.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30253
---
 gdb/testsuite/gdb.gdb/python-helper.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom de Vries March 20, 2023, 5:08 p.m. UTC | #1 
On 3/20/23 17:19, Tom Tromey via Gdb-patches wrote:
> The type allocation changes introduced a failure in python-helper.exp
> that I did not notice.  The bug is that, with these patches,
> arch-allocated integer types have a TYPE_SPECIFIC_INT object attached.
> This patch updates the test to allow this.
> 

Hi,

I've applied that patch and verified that it fixes the FAIL.

LGTM.

Thanks,
- Tom

> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30253
> ---
>   gdb/testsuite/gdb.gdb/python-helper.exp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.gdb/python-helper.exp b/gdb/testsuite/gdb.gdb/python-helper.exp
> index dbd78cbcf78..a58e3b601df 100644
> --- a/gdb/testsuite/gdb.gdb/python-helper.exp
> +++ b/gdb/testsuite/gdb.gdb/python-helper.exp
> @@ -145,7 +145,7 @@ proc test_python_helper {} {
>   		    " flags = \[^\r\n\]+," \
>   		    " owner = $hex \\(gdbarch\\)," \
>   		    " target_type = 0x0," \
> -		    " type_specific_field = TYPE_SPECIFIC_NONE}"]
> +		    " int_stuff = { bit_size = $decimal, bit_offset = $decimal }}"]
>       gdb_test -prompt $outer_prompt_re "print *val->m_type->main_type" $answer "pretty print type->main_type"
>   
>       # Send the continue to the outer GDB, which resumes the inner GDB,
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.gdb/python-helper.exp b/gdb/testsuite/gdb.gdb/python-helper.exp
index dbd78cbcf78..a58e3b601df 100644
--- a/gdb/testsuite/gdb.gdb/python-helper.exp
+++ b/gdb/testsuite/gdb.gdb/python-helper.exp
@@ -145,7 +145,7 @@  proc test_python_helper {} {
 		    " flags = \[^\r\n\]+," \
 		    " owner = $hex \\(gdbarch\\)," \
 		    " target_type = 0x0," \
-		    " type_specific_field = TYPE_SPECIFIC_NONE}"]
+		    " int_stuff = { bit_size = $decimal, bit_offset = $decimal }}"]
     gdb_test -prompt $outer_prompt_re "print *val->m_type->main_type" $answer "pretty print type->main_type"
 
     # Send the continue to the outer GDB, which resumes the inner GDB,