diff mbox series

[v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp

Message ID 20230309125437.32662-1-lihui@loongson.cn
State New
Headers
Series [v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp |

Commit Message

Hui Li March 9, 2023, 12:54 p.m. UTC 
  The test results on LoongArch as follows:

Without this patch:

```
$ make check-gdb TESTS="gdb.base/float.exp"
=== gdb Summary ===

 # of expected passes		2
 # of unexpected failures	1

```
With this patch:

```
$ make check-gdb TESTS="gdb.base/float.exp"
=== gdb Summary ===

 # of expected passes		3

```

Signed-off-by: Hui Li <lihui@loongson.cn>
---
 gdb/testsuite/gdb.base/float.exp | 2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Marchi March 11, 2023, 3 a.m. UTC | #1 
On 3/9/23 07:54, Hui Li wrote:
> The test results on LoongArch as follows:
> 
> Without this patch:
> 
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
> 
>  # of expected passes		2
>  # of unexpected failures	1
> 
> ```
> With this patch:
> 
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
> 
>  # of expected passes		3
> 
> ```
> 
> Signed-off-by: Hui Li <lihui@loongson.cn>
> ---
>  gdb/testsuite/gdb.base/float.exp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
> index 7f230cb6f61..5e9be538b73 100644
> --- a/gdb/testsuite/gdb.base/float.exp
> +++ b/gdb/testsuite/gdb.base/float.exp
> @@ -126,6 +126,8 @@ if {[is_aarch64_target]} {
>  	      pass "info float (without FPU)"
>  	}
>      }
> +} elseif {[istarget "loongarch*-*-*"]} {
> +    gdb_test "info float" "f.*fcc0.*fcsr.*" "info float"
>  } else {
>      gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
>  }

This is ok:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon
Tiezhu Yang March 16, 2023, 3:04 p.m. UTC | #2 
On 3/9/23 20:54, Hui Li wrote:
> The test results on LoongArch as follows:
> 
> Without this patch:
> 
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
> 
>   # of expected passes		2
>   # of unexpected failures	1
> 
> ```
> With this patch:
> 
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
> 
>   # of expected passes		3
> 
> ```
> 
> Signed-off-by: Hui Li <lihui@loongson.cn>
> ---
>   gdb/testsuite/gdb.base/float.exp | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
> index 7f230cb6f61..5e9be538b73 100644
> --- a/gdb/testsuite/gdb.base/float.exp
> +++ b/gdb/testsuite/gdb.base/float.exp
> @@ -126,6 +126,8 @@ if {[is_aarch64_target]} {
>   	      pass "info float (without FPU)"
>   	}
>       }
> +} elseif {[istarget "loongarch*-*-*"]} {
> +    gdb_test "info float" "f.*fcc0.*fcsr.*" "info float"
>   } else {
>       gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
>   }

Looks good to me, tested on LoongArch, pushed.

Thanks,
Tiezhu
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
index 7f230cb6f61..5e9be538b73 100644
--- a/gdb/testsuite/gdb.base/float.exp
+++ b/gdb/testsuite/gdb.base/float.exp
@@ -126,6 +126,8 @@  if {[is_aarch64_target]} {
 	      pass "info float (without FPU)"
 	}
     }
+} elseif {[istarget "loongarch*-*-*"]} {
+    gdb_test "info float" "f.*fcc0.*fcsr.*" "info float"
 } else {
     gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
 }