diff mbox series

Remove a use of pagination_enabled

Message ID 20230128152527.479258-1-tom@tromey.com
State Committed
Commit 34116a8a2d0f46c23cf0e4d1c0842e1bea827ab2
Headers
Series Remove a use of pagination_enabled |

Commit Message

Tom Tromey Jan. 28, 2023, 3:25 p.m. UTC 
  I noticed that the TUI temporarily sets pagination_enabled and
gdb_stdout in one spot.  However, I don't believe these settings are
necessary here, as a ui_file is passed to
gdbarch_print_registers_info.  This patch removes these settings.
---
 gdb/tui/tui-regs.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Tom Tromey Feb. 14, 2023, 8:54 p.m. UTC | #1 
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> I noticed that the TUI temporarily sets pagination_enabled and
Tom> gdb_stdout in one spot.  However, I don't believe these settings are
Tom> necessary here, as a ui_file is passed to
Tom> gdbarch_print_registers_info.  This patch removes these settings.

I'm checking this in now.

Tom
diff mbox series

Patch

diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 3e794aed224..50a238401df 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -91,12 +91,6 @@  tui_register_format (frame_info_ptr frame, int regnum)
 
   /* Expand tabs into spaces, since ncurses on MS-Windows doesn't.  */
   tab_expansion_file stream;
-
-  scoped_restore save_pagination
-    = make_scoped_restore (&pagination_enabled, false);
-  scoped_restore save_stdout
-    = make_scoped_restore (&gdb_stdout, &stream);
-
   gdbarch_print_registers_info (gdbarch, &stream, frame, regnum, 1);
 
   /* Remove the possible \n.  */