[1/1] gdb, testsuite: Remove unnecessary call of "set print pretty on"
Commit Message
The command has no effect for the loading of GDB pretty printers and is
removed by this patch to avoid confusion.
Documentation for "set print pretty"
"Cause GDB to print structures in an indented format with one member per line"
---
gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp | 4 ----
.../py-autoloaded-pretty-printers-in-newobjfile-event.exp | 2 --
2 files changed, 6 deletions(-)
Comments
>>>>> "Christina" == Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> writes:
Christina> The command has no effect for the loading of GDB pretty printers and is
Christina> removed by this patch to avoid confusion.
Thank you. This is ok.
Tom
Thank you for the review, I pushed the patch.
Christina
> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Wednesday, February 8, 2023 5:07 PM
> To: Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Schimpe, Christina <christina.schimpe@intel.com>
> Subject: Re: [PATCH 1/1] gdb, testsuite: Remove unnecessary call of "set
> print pretty on"
>
> >>>>> "Christina" == Christina Schimpe via Gdb-patches <gdb-
> patches@sourceware.org> writes:
>
> Christina> The command has no effect for the loading of GDB pretty
> Christina> printers and is removed by this patch to avoid confusion.
>
> Thank you. This is ok.
>
> Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
@@ -50,8 +50,6 @@ proc start_test { breakpoint_comment } {
gdb_breakpoint [gdb_get_line_number ${breakpoint_comment} ${testfile}.c ]
gdb_continue_to_breakpoint ${breakpoint_comment} ".*"
- gdb_test_no_output "set print pretty on" "starting to pretty print"
-
set remote_python_file [gdb_remote_download host ${srcdir}/${subdir}/${testfile}.py]
gdb_test_no_output "source ${remote_python_file}" "load python file"
@@ -64,8 +62,6 @@ with_test_prefix "run to frame" {
untested "couldn't run to main"
}
- gdb_test_no_output "set print pretty on" "starting to pretty print"
-
set remote_python_file [gdb_remote_download host ${srcdir}/${subdir}/${testfile}.py]
gdb_test_no_output "source ${remote_python_file}" "load python file"
@@ -61,8 +61,6 @@ gdb_test_no_output "source ${remote_python_event_handler_file}" "load python fil
gdb_load ${binfile}
-gdb_test_no_output "set print pretty on"
-
if { ![runto_main] } {
return
}