Remove pthread-pi-defines.sym

Message ID 87r0v63h0x.fsf@igel.home
State Committed
Commit 359a0b9dbcd46475f443a33e0062a14b252e327d
Headers
Series Remove pthread-pi-defines.sym |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Andreas Schwab Feb. 3, 2023, 3:28 p.m. UTC
  It became unused with the removal of the assembler implementation of the
pthread functions.
---
 nptl/Makefile               | 3 +--
 nptl/pthread-pi-defines.sym | 9 ---------
 2 files changed, 1 insertion(+), 11 deletions(-)
 delete mode 100644 nptl/pthread-pi-defines.sym
  

Comments

Adhemerval Zanella Netto Feb. 3, 2023, 4:20 p.m. UTC | #1
On 03/02/23 12:28, Andreas Schwab wrote:
> It became unused with the removal of the assembler implementation of the
> pthread functions.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  nptl/Makefile               | 3 +--
>  nptl/pthread-pi-defines.sym | 9 ---------
>  2 files changed, 1 insertion(+), 11 deletions(-)
>  delete mode 100644 nptl/pthread-pi-defines.sym
> 
> diff --git a/nptl/Makefile b/nptl/Makefile
> index 6d1ae452c8..8cec6faee3 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -339,8 +339,7 @@ xtests += tst-eintr1
>  
>  test-srcs = tst-oddstacklimit
>  
> -gen-as-const-headers = unwindbuf.sym \
> -		       pthread-pi-defines.sym
> +gen-as-const-headers = unwindbuf.sym
>  
>  gen-py-const-headers := nptl_lock_constants.pysym
>  pretty-printers := nptl-printers.py
> diff --git a/nptl/pthread-pi-defines.sym b/nptl/pthread-pi-defines.sym
> deleted file mode 100644
> index 0ac51dba98..0000000000
> --- a/nptl/pthread-pi-defines.sym
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -#include <pthreadP.h>
> -
> --- These PI macros are used by assembly code.
> -
> -MUTEX_KIND	offsetof (pthread_mutex_t, __data.__kind)
> -ROBUST_BIT	PTHREAD_MUTEX_ROBUST_NORMAL_NP
> -PI_BIT		PTHREAD_MUTEX_PRIO_INHERIT_NP
> -PS_BIT		PTHREAD_MUTEX_PSHARED_BIT
> -TID_MASK	FUTEX_TID_MASK
  

Patch

diff --git a/nptl/Makefile b/nptl/Makefile
index 6d1ae452c8..8cec6faee3 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -339,8 +339,7 @@  xtests += tst-eintr1
 
 test-srcs = tst-oddstacklimit
 
-gen-as-const-headers = unwindbuf.sym \
-		       pthread-pi-defines.sym
+gen-as-const-headers = unwindbuf.sym
 
 gen-py-const-headers := nptl_lock_constants.pysym
 pretty-printers := nptl-printers.py
diff --git a/nptl/pthread-pi-defines.sym b/nptl/pthread-pi-defines.sym
deleted file mode 100644
index 0ac51dba98..0000000000
--- a/nptl/pthread-pi-defines.sym
+++ /dev/null
@@ -1,9 +0,0 @@ 
-#include <pthreadP.h>
-
--- These PI macros are used by assembly code.
-
-MUTEX_KIND	offsetof (pthread_mutex_t, __data.__kind)
-ROBUST_BIT	PTHREAD_MUTEX_ROBUST_NORMAL_NP
-PI_BIT		PTHREAD_MUTEX_PRIO_INHERIT_NP
-PS_BIT		PTHREAD_MUTEX_PSHARED_BIT
-TID_MASK	FUTEX_TID_MASK