diff mbox series

doc: correct _FORTIFY_SOURCE doc in features.h

Message ID 20230131132510.98243-1-fanquake@gmail.com
State Committed
Commit 1423a26a488aae1c6fa7210e20c147a242f40f47
Headers
Series doc: correct _FORTIFY_SOURCE doc in features.h |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

fanquake Jan. 31, 2023, 1:25 p.m. UTC 
  ---
 include/features.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Siddhesh Poyarekar Jan. 31, 2023, 2:20 p.m. UTC | #1 
Thanks, that looks correct.  Carlos, may I push this before you cut the 
release?

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

On 2023-01-31 08:25, fanquake via Libc-alpha wrote:
> ---
>   include/features.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/features.h b/include/features.h
> index 7d2c7a4f87..07c73b3e55 100644
> --- a/include/features.h
> +++ b/include/features.h
> @@ -57,7 +57,8 @@
>   			__STRICT_ANSI__).
>   
>      _FORTIFY_SOURCE	Add security hardening to many library functions.
> -			Set to 1 or 2; 2 performs stricter checks than 1.
> +			Set to 1, 2 or 3; 3 performs stricter checks than 2, which
> +			performs stricter checks than 1.
>   
>      _REENTRANT, _THREAD_SAFE
>   			Obsolete; equivalent to _POSIX_C_SOURCE=199506L.
Carlos O'Donell Jan. 31, 2023, 8:29 p.m. UTC | #2 
On 1/31/23 09:20, Siddhesh Poyarekar wrote:
> Thanks, that looks correct.  Carlos, may I push this before you cut the release?
> 
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Yes, comment only fix in headers. OK for 2.37. Please push ASAP.

> On 2023-01-31 08:25, fanquake via Libc-alpha wrote:
>> ---
>>   include/features.h | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/features.h b/include/features.h
>> index 7d2c7a4f87..07c73b3e55 100644
>> --- a/include/features.h
>> +++ b/include/features.h
>> @@ -57,7 +57,8 @@
>>               __STRICT_ANSI__).
>>        _FORTIFY_SOURCE    Add security hardening to many library functions.
>> -            Set to 1 or 2; 2 performs stricter checks than 1.
>> +            Set to 1, 2 or 3; 3 performs stricter checks than 2, which
>> +            performs stricter checks than 1.
>>        _REENTRANT, _THREAD_SAFE
>>               Obsolete; equivalent to _POSIX_C_SOURCE=199506L.
>
Siddhesh Poyarekar Jan. 31, 2023, 10:34 p.m. UTC | #3 
On 2023-01-31 15:29, Carlos O'Donell wrote:
> On 1/31/23 09:20, Siddhesh Poyarekar wrote:
>> Thanks, that looks correct.  Carlos, may I push this before you cut the release?
>>
>> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
> 
> Yes, comment only fix in headers. OK for 2.37. Please push ASAP.
> 

Pushed, thanks.

Sid
diff mbox series

Patch

diff --git a/include/features.h b/include/features.h
index 7d2c7a4f87..07c73b3e55 100644
--- a/include/features.h
+++ b/include/features.h
@@ -57,7 +57,8 @@ 
 			__STRICT_ANSI__).
 
    _FORTIFY_SOURCE	Add security hardening to many library functions.
-			Set to 1 or 2; 2 performs stricter checks than 1.
+			Set to 1, 2 or 3; 3 performs stricter checks than 2, which
+			performs stricter checks than 1.
 
    _REENTRANT, _THREAD_SAFE
 			Obsolete; equivalent to _POSIX_C_SOURCE=199506L.