diff mbox series

[v2,3/3] scripts/build-many-glibcs.py: Remove unused RANLIB and STRIP option

Message ID 20221206160243.455627-4-adhemerval.zanella@linaro.org
State Superseded
Headers
Series Refactor binutils configure usage |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Adhemerval Zanella Dec. 6, 2022, 4:02 p.m. UTC 
  ---
 scripts/build-many-glibcs.py | 2 --
 1 file changed, 2 deletions(-)

Comments

Carlos O'Donell Jan. 11, 2023, 8:28 p.m. UTC | #1 
On 12/6/22 11:02, Adhemerval Zanella wrote:

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  scripts/build-many-glibcs.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index a49f50b792..32f336366c 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -1521,8 +1521,6 @@ class GlibcPolicyDefault(object):
>              '--host=%s' % glibc.triplet,
>              'CC=%s' % glibc.tool_name('gcc'),
>              'CXX=%s' % glibc.tool_name('g++'),
> -            'RANLIB=%s' % glibc.tool_name('ranlib'),
> -            'STRIP=%s' % glibc.tool_name('strip'),

OK. Agreed, these aren't used and we should make this as concise as possible.

>          ]
>          if glibc.os == 'gnu':
>              self.configure_args.append('MIG=%s' % glibc.tool_name('mig'))
diff mbox series

Patch

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index a49f50b792..32f336366c 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -1521,8 +1521,6 @@  class GlibcPolicyDefault(object):
             '--host=%s' % glibc.triplet,
             'CC=%s' % glibc.tool_name('gcc'),
             'CXX=%s' % glibc.tool_name('g++'),
-            'RANLIB=%s' % glibc.tool_name('ranlib'),
-            'STRIP=%s' % glibc.tool_name('strip'),
         ]
         if glibc.os == 'gnu':
             self.configure_args.append('MIG=%s' % glibc.tool_name('mig'))