gdb: Update gdbarch.py with latest changes in gdbarch.c
Commit Message
Commit 2b16913cdca2 ("gdb: make gdbarch_alloc take ownership of the tdep")
changed gdbarch.c without updating gdbarch.py. As a result, running
gdbarch.py reverts those changes and causes the build to fail.
So change gdbarch.py to generate the current version of gdbarch.c.
---
gdb/gdbarch.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On 1/11/23 12:45, Thiago Jung Bauermann via Gdb-patches wrote:
> Commit 2b16913cdca2 ("gdb: make gdbarch_alloc take ownership of the tdep")
> changed gdbarch.c without updating gdbarch.py. As a result, running
> gdbarch.py reverts those changes and causes the build to fail.
>
> So change gdbarch.py to generate the current version of gdbarch.c.
Heh, how silly of me. This is ok, thanks for fixing:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
Hello Simon,
Simon Marchi <simark@simark.ca> writes:
> On 1/11/23 12:45, Thiago Jung Bauermann via Gdb-patches wrote:
>> Commit 2b16913cdca2 ("gdb: make gdbarch_alloc take ownership of the tdep")
>> changed gdbarch.c without updating gdbarch.py. As a result, running
>> gdbarch.py reverts those changes and causes the build to fail.
>>
>> So change gdbarch.py to generate the current version of gdbarch.c.
>
> Heh, how silly of me. This is ok, thanks for fixing:
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
Thank you for the quick review! Pushed.
@@ -286,7 +286,7 @@ with open("gdbarch.c", "w") as f:
print(f" {c.type} {c.name};", file=f)
print(file=f)
print(" /* target specific vector. */", file=f)
- print(" struct gdbarch_tdep_base *tdep = nullptr;", file=f)
+ print(" gdbarch_tdep_up tdep;", file=f)
print(" gdbarch_dump_tdep_ftype *dump_tdep = nullptr;", file=f)
print(file=f)
print(" /* per-architecture data-pointers. */", file=f)
@@ -316,13 +316,13 @@ with open("gdbarch.c", "w") as f:
print(file=f)
print("struct gdbarch *", file=f)
print("gdbarch_alloc (const struct gdbarch_info *info,", file=f)
- print(" struct gdbarch_tdep_base *tdep)", file=f)
+ print(" gdbarch_tdep_up tdep)", file=f)
print("{", file=f)
print(" struct gdbarch *gdbarch;", file=f)
print("", file=f)
print(" gdbarch = new struct gdbarch;", file=f)
print(file=f)
- print(" gdbarch->tdep = tdep;", file=f)
+ print(" gdbarch->tdep = std::move (tdep);", file=f)
print(file=f)
for c in filter(info, components):
print(f" gdbarch->{c.name} = info->{c.name};", file=f)