diff mbox series

[PING,v2,gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop

Message ID 20221020182456.2701-1-j3.soon777@gmail.com
State New
Headers
Series [PING,v2,gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop |

Commit Message

Johnson Sun Oct. 20, 2022, 6:24 p.m. UTC 
  In 2014, the function `gdbpy_should_stop' has been replaced with
`gdbpy_breakpoint_cond_says_stop'

This replaces `gdbpy_should_stop' with `gdbpy_breakpoint_cond_says_stop' in the
comments.

Since `gdbpy_should_stop' has been renamed as noted in `gdb/ChangeLog-2014':

	* python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed
	from gdbpy_should_stop.  Change result type to enum scr_bp_stop.
---
 gdb/python/py-finishbreakpoint.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Johnson Sun Nov. 18, 2022, 12:14 p.m. UTC | #1 
Ping for: 
<https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.

Johnson

On 10/21/2022 2:24 AM, Johnson Sun wrote:
> In 2014, the function `gdbpy_should_stop' has been replaced with
> `gdbpy_breakpoint_cond_says_stop'
>
> This replaces `gdbpy_should_stop' with `gdbpy_breakpoint_cond_says_stop' in the
> comments.
>
> Since `gdbpy_should_stop' has been renamed as noted in `gdb/ChangeLog-2014':
>
> 	* python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed
> 	from gdbpy_should_stop.  Change result type to enum scr_bp_stop.
> ---
>   gdb/python/py-finishbreakpoint.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c
> index c80096f6810..dcf86317779 100644
> --- a/gdb/python/py-finishbreakpoint.c
> +++ b/gdb/python/py-finishbreakpoint.c
> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self)
>     Py_TYPE (self)->tp_free (self);
>   }
>   
> -/* Triggered when gdbpy_should_stop is about to execute the `stop' callback
> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to execute the `stop' callback
>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and cache the
>      `return_value', if possible.  */
>   
> @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj)
>       }
>   }
>   
> -/* Triggered when gdbpy_should_stop has triggered the `stop' callback
> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the `stop' callback
>      of the gdb.FinishBreakpoint object BP_OBJ.  */
>   
>   void
Johnson Sun Nov. 25, 2022, 3:10 p.m. UTC | #2 
Ping for: 
<https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.

Johnson

On 11/18/2022 8:14 PM, JohnsonSun wrote:
> Ping for: 
> <https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.
>
> Johnson
>
> On 10/21/2022 2:24 AM, Johnson Sun wrote:
>> In 2014, the function `gdbpy_should_stop' has been replaced with
>> `gdbpy_breakpoint_cond_says_stop'
>>
>> This replaces `gdbpy_should_stop' with 
>> `gdbpy_breakpoint_cond_says_stop' in the
>> comments.
>>
>> Since `gdbpy_should_stop' has been renamed as noted in 
>> `gdb/ChangeLog-2014':
>>
>>     * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed
>>     from gdbpy_should_stop.  Change result type to enum scr_bp_stop.
>> ---
>>   gdb/python/py-finishbreakpoint.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/python/py-finishbreakpoint.c 
>> b/gdb/python/py-finishbreakpoint.c
>> index c80096f6810..dcf86317779 100644
>> --- a/gdb/python/py-finishbreakpoint.c
>> +++ b/gdb/python/py-finishbreakpoint.c
>> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self)
>>     Py_TYPE (self)->tp_free (self);
>>   }
>>   -/* Triggered when gdbpy_should_stop is about to execute the `stop' 
>> callback
>> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to 
>> execute the `stop' callback
>>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and 
>> cache the
>>      `return_value', if possible.  */
>>   @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct 
>> gdbpy_breakpoint_object *bp_obj)
>>       }
>>   }
>>   -/* Triggered when gdbpy_should_stop has triggered the `stop' callback
>> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the 
>> `stop' callback
>>      of the gdb.FinishBreakpoint object BP_OBJ.  */
>>     void
>
Johnson Sun Dec. 4, 2022, 4:45 p.m. UTC | #3 
Ping for: 
<https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.

Johnson

On 11/25/2022 11:10 PM, Johnson Sun wrote:
> Ping for: 
> <https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.
>
> Johnson
>
> On 11/18/2022 8:14 PM, JohnsonSun wrote:
>> Ping for: 
>> <https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.
>>
>> Johnson
>>
>> On 10/21/2022 2:24 AM, Johnson Sun wrote:
>>> In 2014, the function `gdbpy_should_stop' has been replaced with
>>> `gdbpy_breakpoint_cond_says_stop'
>>>
>>> This replaces `gdbpy_should_stop' with 
>>> `gdbpy_breakpoint_cond_says_stop' in the
>>> comments.
>>>
>>> Since `gdbpy_should_stop' has been renamed as noted in 
>>> `gdb/ChangeLog-2014':
>>>
>>>     * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed
>>>     from gdbpy_should_stop.  Change result type to enum scr_bp_stop.
>>> ---
>>>   gdb/python/py-finishbreakpoint.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/gdb/python/py-finishbreakpoint.c 
>>> b/gdb/python/py-finishbreakpoint.c
>>> index c80096f6810..dcf86317779 100644
>>> --- a/gdb/python/py-finishbreakpoint.c
>>> +++ b/gdb/python/py-finishbreakpoint.c
>>> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self)
>>>     Py_TYPE (self)->tp_free (self);
>>>   }
>>>   -/* Triggered when gdbpy_should_stop is about to execute the 
>>> `stop' callback
>>> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to 
>>> execute the `stop' callback
>>>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and 
>>> cache the
>>>      `return_value', if possible.  */
>>>   @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct 
>>> gdbpy_breakpoint_object *bp_obj)
>>>       }
>>>   }
>>>   -/* Triggered when gdbpy_should_stop has triggered the `stop' 
>>> callback
>>> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the 
>>> `stop' callback
>>>      of the gdb.FinishBreakpoint object BP_OBJ.  */
>>>     void
>>
Johnson Sun Dec. 12, 2022, 9:44 p.m. UTC | #4 
Ping for: 
<https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.

Johnson

On 12/5/2022 12:45 AM, Johnson Sun wrote:
> Ping for: 
> <https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.
>
> Johnson
>
> On 11/25/2022 11:10 PM, Johnson Sun wrote:
>> Ping for: 
>> <https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.
>>
>> Johnson
>>
>> On 11/18/2022 8:14 PM, JohnsonSun wrote:
>>> Ping for: 
>>> <https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.
>>>
>>> Johnson
>>>
>>> On 10/21/2022 2:24 AM, Johnson Sun wrote:
>>>> In 2014, the function `gdbpy_should_stop' has been replaced with
>>>> `gdbpy_breakpoint_cond_says_stop'
>>>>
>>>> This replaces `gdbpy_should_stop' with 
>>>> `gdbpy_breakpoint_cond_says_stop' in the
>>>> comments.
>>>>
>>>> Since `gdbpy_should_stop' has been renamed as noted in 
>>>> `gdb/ChangeLog-2014':
>>>>
>>>>     * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): 
>>>> Renamed
>>>>     from gdbpy_should_stop.  Change result type to enum scr_bp_stop.
>>>> ---
>>>>   gdb/python/py-finishbreakpoint.c | 4 ++--
>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/gdb/python/py-finishbreakpoint.c 
>>>> b/gdb/python/py-finishbreakpoint.c
>>>> index c80096f6810..dcf86317779 100644
>>>> --- a/gdb/python/py-finishbreakpoint.c
>>>> +++ b/gdb/python/py-finishbreakpoint.c
>>>> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self)
>>>>     Py_TYPE (self)->tp_free (self);
>>>>   }
>>>>   -/* Triggered when gdbpy_should_stop is about to execute the 
>>>> `stop' callback
>>>> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to 
>>>> execute the `stop' callback
>>>>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and 
>>>> cache the
>>>>      `return_value', if possible.  */
>>>>   @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct 
>>>> gdbpy_breakpoint_object *bp_obj)
>>>>       }
>>>>   }
>>>>   -/* Triggered when gdbpy_should_stop has triggered the `stop' 
>>>> callback
>>>> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered 
>>>> the `stop' callback
>>>>      of the gdb.FinishBreakpoint object BP_OBJ.  */
>>>>     void
>>>
Simon Marchi Dec. 13, 2022, 2:34 a.m. UTC | #5 
On 12/12/22 16:44, Johnson Sun via Gdb-patches wrote:
> Ping for: <https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.
> 
> Johnson

Sorry for the delay.

I pushed the patch, after rewrapping the lines so they don't exceed the line length limit.

Simon
diff mbox series

Patch

diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c
index c80096f6810..dcf86317779 100644
--- a/gdb/python/py-finishbreakpoint.c
+++ b/gdb/python/py-finishbreakpoint.c
@@ -90,7 +90,7 @@  bpfinishpy_dealloc (PyObject *self)
   Py_TYPE (self)->tp_free (self);
 }
 
-/* Triggered when gdbpy_should_stop is about to execute the `stop' callback
+/* Triggered when gdbpy_breakpoint_cond_says_stop is about to execute the `stop' callback
    of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and cache the
    `return_value', if possible.  */
 
@@ -134,7 +134,7 @@  bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj)
     }
 }
 
-/* Triggered when gdbpy_should_stop has triggered the `stop' callback
+/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the `stop' callback
    of the gdb.FinishBreakpoint object BP_OBJ.  */
 
 void