sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings.
| Message ID | 54D61EFC.3040000@sunrus.com.cn |
|---|---|
| State | Committed |
| Headers |
Received: (qmail 20375 invoked by alias); 7 Feb 2015 14:12:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 19654 invoked by uid 89); 7 Feb 2015 14:12:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-194.mail.aliyun.com Received: from out1134-194.mail.aliyun.com (HELO out1134-194.mail.aliyun.com) (42.120.134.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Feb 2015 14:11:58 +0000 X-Alimail-AntiSpam: AC=CONTINUE; BC=0.07946592|-1; FP=0|0|0|0|0|-1|-1|-1; HT=r41g03024; MF=gang.chen@sunrus.com.cn; PH=DS; RN=1; RT=1; SR=0; Received: from ShengShiZhuChengdeMacBook-Pro.local(mailfrom:gang.chen@sunrus.com.cn ip:223.72.65.5) by smtp.aliyun-inc.com(10.147.38.220); Sat, 07 Feb 2015 22:11:52 +0800 Message-ID: <54D61EFC.3040000@sunrus.com.cn> Date: Sat, 07 Feb 2015 22:19:40 +0800 From: Chen Gang S <gang.chen@sunrus.com.cn> User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings. Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit |
Commit Message
Chen Gang
Feb. 7, 2015, 2:19 p.m. UTC
The related warnings:
gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c
../../../binutils-gdb/sim/mcore/interp.c: In function ‘handle_trap1’:
../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function ‘link’ [-Wimplicit-function-declaration]
cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]);
^
../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration]
cpu.gr[RET1] = access ((char *) a[0], a[1]);
^
2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com>
* mcore/interp.c: Include "unistd.h" standard C header file to
avoid compiling warnings.
---
sim/ChangeLog | 5 +++++
sim/mcore/interp.c | 1 +
2 files changed, 6 insertions(+)
Comments
On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote: > The related warnings: > > gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c > ../../../binutils-gdb/sim/mcore/interp.c: In function ‘handle_trap1’: > ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function ‘link’ [-Wimplicit-function-declaration] > cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]); > ^ > ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration] > cpu.gr[RET1] = access ((char *) a[0], a[1]); > ^ > > 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> > > * mcore/interp.c: Include "unistd.h" standard C header file to > avoid compiling warnings. LGTM
On 2/8/15 07:22, Doug Evans wrote: > On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote: >> The related warnings: >> >> gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c >> ../../../binutils-gdb/sim/mcore/interp.c: In function ‘handle_trap1’: >> ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function ‘link’ [-Wimplicit-function-declaration] >> cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]); >> ^ >> ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration] >> cpu.gr[RET1] = access ((char *) a[0], a[1]); >> ^ >> >> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> >> >> * mcore/interp.c: Include "unistd.h" standard C header file to >> avoid compiling warnings. > > LGTM Excuse me, I am not quite familiar with the short word, I guess it is " Look Good To ME", Is what I guess correct? Thanks.
On Sat, Feb 7, 2015 at 4:02 PM, Chen Gang S <gang.chen@sunrus.com.cn> wrote: > On 2/8/15 07:22, Doug Evans wrote: >> On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote: >>> The related warnings: >>> >>> gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c >>> ../../../binutils-gdb/sim/mcore/interp.c: In function ‘handle_trap1’: >>> ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function ‘link’ [-Wimplicit-function-declaration] >>> cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]); >>> ^ >>> ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration] >>> cpu.gr[RET1] = access ((char *) a[0], a[1]); >>> ^ >>> >>> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> >>> >>> * mcore/interp.c: Include "unistd.h" standard C header file to >>> avoid compiling warnings. >> >> LGTM > > Excuse me, I am not quite familiar with the short word, I guess it is " > Look Good To ME", > > Is what I guess correct? Looks Good To Me, yeah
On 2/8/15 08:35, Doug Evans wrote: > On Sat, Feb 7, 2015 at 4:02 PM, Chen Gang S <gang.chen@sunrus.com.cn> wrote: >> On 2/8/15 07:22, Doug Evans wrote: >>> On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote: >>>> The related warnings: >>>> >>>> gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c >>>> ../../../binutils-gdb/sim/mcore/interp.c: In function ‘handle_trap1’: >>>> ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function ‘link’ [-Wimplicit-function-declaration] >>>> cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]); >>>> ^ >>>> ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration] >>>> cpu.gr[RET1] = access ((char *) a[0], a[1]); >>>> ^ >>>> >>>> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> >>>> >>>> * mcore/interp.c: Include "unistd.h" standard C header file to >>>> avoid compiling warnings. >>> >>> LGTM >> >> Excuse me, I am not quite familiar with the short word, I guess it is " >> Look Good To ME", >> >> Is what I guess correct? > > Looks Good To Me, > yeah Thank you for your work, and I shall "git push" to main branch, if no additional reply within 3 days (2015-02-10). Thanks.
> >>>> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> > >>>> > >>>> * mcore/interp.c: Include "unistd.h" standard C header file to > >>>> avoid compiling warnings. A couple of small procedural nits... There is a ChangeLog file in sim/mcore, so this is the one that should be updated, and thus the name of the file in the ChangeLog entry should not have the "mcore/" part. Also, the ChangeLog entry should only say "what" has been changed, not "why". If you feel that the "why" needs to be provided, it should be provided in the code. In this case, I feel that your revision log is sufficient. So, your ChangeLog entry should look like: 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> * interp.c: Include "unistd.h".
On 2/9/15 00:00, Joel Brobecker wrote: >>>>>> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> >>>>>> >>>>>> * mcore/interp.c: Include "unistd.h" standard C header file to >>>>>> avoid compiling warnings. > > A couple of small procedural nits... > > There is a ChangeLog file in sim/mcore, so this is the one that > should be updated, and thus the name of the file in the ChangeLog > entry should not have the "mcore/" part. > > Also, the ChangeLog entry should only say "what" has been changed, > not "why". If you feel that the "why" needs to be provided, it should > be provided in the code. In this case, I feel that your revision log > is sufficient. > > So, your ChangeLog entry should look like: > > 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> > > * interp.c: Include "unistd.h". OK, thanks. I guess, before "git push", I need send patch v2 to mailing list. If no any additional reply, I shall send patch v2 within 2015-02-10. Thanks.
> > 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> > > > > * interp.c: Include "unistd.h". > > OK, thanks. I guess, before "git push", I need send patch v2 to mailing > list. > > If no any additional reply, I shall send patch v2 within 2015-02-10. The patch was approved and I had no comments on it, so no need to send v2; just push.
On 2/9/15 10:28, Joel Brobecker wrote: >>> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> >>> >>> * interp.c: Include "unistd.h". >> >> OK, thanks. I guess, before "git push", I need send patch v2 to mailing >> list. >> >> If no any additional reply, I shall send patch v2 within 2015-02-10. > > The patch was approved and I had no comments on it, so no need to send > v2; just push. > I guess, I shall "git push" with the modified ChangeLog contents as below (also the related patch comments need to be modified too): 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> * interp.c: Include "unistd.h". If no additional reply, I shall "git push" within 2015-02-11. Thanks.
diff --git a/sim/ChangeLog b/sim/ChangeLog index a891ce5..8a05ff7 100644 --- a/sim/ChangeLog +++ b/sim/ChangeLog @@ -1,3 +1,8 @@ +2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com> + + * mcore/interp.c: Include "unistd.h" standard C header file to + avoid compiling warnings. + 2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com> * microblaze/interp.c (sim_do_command): Call freeargv() before diff --git a/sim/mcore/interp.c b/sim/mcore/interp.c index dfaa6aa..7e2be0d 100644 --- a/sim/mcore/interp.c +++ b/sim/mcore/interp.c @@ -23,6 +23,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */ #include <sys/times.h> #include <sys/param.h> #include <netinet/in.h> /* for byte ordering macros */ +#include <unistd.h> #include "bfd.h" #include "gdb/callback.h" #include "libiberty.h"