Message ID | 04f72f880579950f6196da72073a3698582fda0b.1666258361.git.research_trasio@irq.a4lg.com |
---|---|
State | Committed |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 519B9395BC11 for <patchwork@sourceware.org>; Thu, 20 Oct 2022 09:38:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 519B9395BC11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666258707; bh=zCoLZHM+eaf3yGR6AIyLcxMzILJAIglng1oAdADa6hQ=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xbgo6IDSmRa1HqVsD9Pby8vR0/lmS9d8olkDXzVbtebVlV+oHPWft3xLSZbTkfw8u JxcSzLUAxohzUpZ681yDfODrdapl2sxHsle7snPcMgcAEdGrNIFy6PFFiV0PksQg+0 xElB/dzN8ld8fkU4J76TI9Vxp9xc0vSsw6X1wkGw= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 9FB49395A060 for <gdb-patches@sourceware.org>; Thu, 20 Oct 2022 09:38:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FB49395A060 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 015EE300089; Thu, 20 Oct 2022 09:37:58 +0000 (UTC) To: Tsukasa OI <research_trasio@irq.a4lg.com>, Andrew Burgess <aburgess@redhat.com>, Mike Frysinger <vapier@gentoo.org>, Nick Clifton <nickc@redhat.com> Subject: [PATCH 29/40] sim/ppc: Fix indentation on generated code Date: Thu, 20 Oct 2022 09:32:34 +0000 Message-Id: <04f72f880579950f6196da72073a3698582fda0b.1666258361.git.research_trasio@irq.a4lg.com> In-Reply-To: <cover.1666258361.git.research_trasio@irq.a4lg.com> References: <cover.1666258361.git.research_trasio@irq.a4lg.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Tsukasa OI via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Tsukasa OI <research_trasio@irq.a4lg.com> Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
sim+gdb: Suppress warnings if built with Clang (big batch 1)
|
|
Commit Message
Tsukasa OI
Oct. 20, 2022, 9:32 a.m. UTC
Clang generates a warning if there is a block statement and another adjacent statement with a misleading indent ("-Wmisleading-indentation"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). The cause of this warning, $(builddir)/sim/ppc/semantics.c is generated by $(srcdir)/sim/ppc/igen.c and this commit fixes generating misleading indentation by removing two spaces. --- sim/ppc/igen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 20 Oct 2022 09:32, Tsukasa OI wrote: > Clang generates a warning if there is a block statement and another > adjacent statement with a misleading indent ("-Wmisleading-indentation"). > On the default configuration, it causes a build failure > (unless "--disable-werror" is specified). > > The cause of this warning, $(builddir)/sim/ppc/semantics.c is generated by > $(srcdir)/sim/ppc/igen.c and this commit fixes generating misleading > indentation by removing two spaces. > --- > sim/ppc/igen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sim/ppc/igen.c b/sim/ppc/igen.c > index 27b48638276..786ea540d57 100644 > --- a/sim/ppc/igen.c > +++ b/sim/ppc/igen.c > @@ -233,7 +233,7 @@ gen_semantics_c(insn_table *table, > lf_printf(file, " option_mpc860c0 = 0;\n"); > lf_printf(file, " if (tree_find_property(root, \"/options/mpc860c0\"))\n"); > lf_printf(file, " option_mpc860c0 = tree_find_integer_property(root, \"/options/mpc860c0\");\n"); > - lf_printf(file, " option_mpc860c0 *= 4; /* convert word count to byte count */\n"); > + lf_printf(file, " option_mpc860c0 *= 4; /* convert word count to byte count */\n"); this maintains existing behavior, and logically it's the same, but i think we should fix the intention of the code -- add braces so that the *4 only happens inside the if statement. -mike
diff --git a/sim/ppc/igen.c b/sim/ppc/igen.c index 27b48638276..786ea540d57 100644 --- a/sim/ppc/igen.c +++ b/sim/ppc/igen.c @@ -233,7 +233,7 @@ gen_semantics_c(insn_table *table, lf_printf(file, " option_mpc860c0 = 0;\n"); lf_printf(file, " if (tree_find_property(root, \"/options/mpc860c0\"))\n"); lf_printf(file, " option_mpc860c0 = tree_find_integer_property(root, \"/options/mpc860c0\");\n"); - lf_printf(file, " option_mpc860c0 *= 4; /* convert word count to byte count */\n"); + lf_printf(file, " option_mpc860c0 *= 4; /* convert word count to byte count */\n"); lf_printf(file, "}\n"); lf_printf(file, "\n"); if (generate_expanded_instructions)