wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency
Checks
Context |
Check |
Description |
dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
dj/TryBot-32bit |
success
|
Build for i686
|
Commit Message
Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
xsetlocale (LC_ALL, "de_DE.UTF-8");
xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
---
wcsmbs/Makefile | 2 ++
1 file changed, 2 insertions(+)
Comments
On Fri, Jul 29, 2022 at 10:51 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
>
> xsetlocale (LC_ALL, "de_DE.UTF-8");
> xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
> wcsmbs/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
> $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
> $(objpfx)tst-c16-surrogate.out: $(gen-locales)
> $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
> endif
>
> $(objpfx)tst-wcstod-round: $(libm)
> --
> 2.37.1
>
Fixes the issue.
LGTM
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
On 29/07/22 14:50, H.J. Lu via Libc-alpha wrote:
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
>
> xsetlocale (LC_ALL, "de_DE.UTF-8");
> xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
> wcsmbs/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
> $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
> $(objpfx)tst-c16-surrogate.out: $(gen-locales)
> $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
> endif
>
> $(objpfx)tst-wcstod-round: $(libm)
LGTM as well.
On 7/29/22 13:50, H.J. Lu via Libc-alpha wrote:
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
>
> xsetlocale (LC_ALL, "de_DE.UTF-8");
> xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
> wcsmbs/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
> $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
> $(objpfx)tst-c16-surrogate.out: $(gen-locales)
> $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
> endif
>
> $(objpfx)tst-wcstod-round: $(libm)
LGTM. OK for 2.36 also.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
@@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
$(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
$(objpfx)tst-c16-surrogate.out: $(gen-locales)
$(objpfx)tst-c32-state.out: $(gen-locales)
+$(objpfx)test-c8rtomb.out: $(gen-locales)
+$(objpfx)test-mbrtoc8.out: $(gen-locales)
endif
$(objpfx)tst-wcstod-round: $(libm)