diff mbox series

wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency

Message ID 20220729175056.268461-1-hjl.tools@gmail.com
State Committed
Commit e03f5ccd6cc8f829416156eac75acee501626c1f
Headers
Series wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

H.J. Lu July 29, 2022, 5:50 p.m. UTC 
  Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for

  xsetlocale (LC_ALL, "de_DE.UTF-8");
  xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
---
 wcsmbs/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Sunil Pandey July 29, 2022, 6:02 p.m. UTC | #1 
On Fri, Jul 29, 2022 at 10:51 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
>
>   xsetlocale (LC_ALL, "de_DE.UTF-8");
>   xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
>  wcsmbs/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
>  $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
>  $(objpfx)tst-c16-surrogate.out: $(gen-locales)
>  $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
>  endif
>
>  $(objpfx)tst-wcstod-round: $(libm)
> --
> 2.37.1
>

Fixes the issue.

LGTM
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
Adhemerval Zanella Netto July 29, 2022, 7:08 p.m. UTC | #2 
On 29/07/22 14:50, H.J. Lu via Libc-alpha wrote:
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
> 
>   xsetlocale (LC_ALL, "de_DE.UTF-8");
>   xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
>  wcsmbs/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
>  $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
>  $(objpfx)tst-c16-surrogate.out: $(gen-locales)
>  $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
>  endif
>  
>  $(objpfx)tst-wcstod-round: $(libm)

LGTM as well.
Carlos O'Donell July 31, 2022, 11:57 a.m. UTC | #3 
On 7/29/22 13:50, H.J. Lu via Libc-alpha wrote:
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
> 
>   xsetlocale (LC_ALL, "de_DE.UTF-8");
>   xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
>  wcsmbs/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
>  $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
>  $(objpfx)tst-c16-surrogate.out: $(gen-locales)
>  $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
>  endif
>  
>  $(objpfx)tst-wcstod-round: $(libm)

LGTM. OK for 2.36 also.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
diff mbox series

Patch

diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
index e6b9e8743a..3d19d5556f 100644
--- a/wcsmbs/Makefile
+++ b/wcsmbs/Makefile
@@ -73,6 +73,8 @@  $(objpfx)tst-wcstol-locale.out: $(gen-locales)
 $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
 $(objpfx)tst-c16-surrogate.out: $(gen-locales)
 $(objpfx)tst-c32-state.out: $(gen-locales)
+$(objpfx)test-c8rtomb.out: $(gen-locales)
+$(objpfx)test-mbrtoc8.out: $(gen-locales)
 endif
 
 $(objpfx)tst-wcstod-round: $(libm)