diff mbox series

[v1] x86: Remove unneeded rtld-wmemcmp

Message ID 20220712192910.351121-9-goldstein.w.n@gmail.com
State Committed
Commit 42b014dd1b92b4cd0afbff901a82d8b0a82d36a8
Headers
Series [v1] x86: Remove unneeded rtld-wmemcmp |

Checks

Context Check Description
dj/TryBot-32bit success Build for i686
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Noah Goldstein July 12, 2022, 7:29 p.m. UTC 
  wmemcmp isn't used by the dynamic loader so their no need to add an
RTLD stub for it.

Tested with and without multiarch on x86_64 for ISA levels:
{generic, x86-64-v2, x86-64-v3, x86-64-v4}

And m32 with and without multiarch.
---
 sysdeps/x86_64/multiarch/rtld-wmemcmp.S | 18 ------------------
 1 file changed, 18 deletions(-)
 delete mode 100644 sysdeps/x86_64/multiarch/rtld-wmemcmp.S

Comments

H.J. Lu July 12, 2022, 7:44 p.m. UTC | #1 
On Tue, Jul 12, 2022 at 12:29 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> wmemcmp isn't used by the dynamic loader so their no need to add an
> RTLD stub for it.
>
> Tested with and without multiarch on x86_64 for ISA levels:
> {generic, x86-64-v2, x86-64-v3, x86-64-v4}
>
> And m32 with and without multiarch.
> ---
>  sysdeps/x86_64/multiarch/rtld-wmemcmp.S | 18 ------------------
>  1 file changed, 18 deletions(-)
>  delete mode 100644 sysdeps/x86_64/multiarch/rtld-wmemcmp.S
>
> diff --git a/sysdeps/x86_64/multiarch/rtld-wmemcmp.S b/sysdeps/x86_64/multiarch/rtld-wmemcmp.S
> deleted file mode 100644
> index 71a6f0affa..0000000000
> --- a/sysdeps/x86_64/multiarch/rtld-wmemcmp.S
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -/* Copyright (C) 2022 Free Software Foundation, Inc.
> -   This file is part of the GNU C Library.
> -
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library; if not, see
> -   <https://www.gnu.org/licenses/>.  */
> -
> -#include "../wmemcmp.S"
> --
> 2.34.1
>

LGTM.

Thanks.
diff mbox series

Patch

diff --git a/sysdeps/x86_64/multiarch/rtld-wmemcmp.S b/sysdeps/x86_64/multiarch/rtld-wmemcmp.S
deleted file mode 100644
index 71a6f0affa..0000000000
--- a/sysdeps/x86_64/multiarch/rtld-wmemcmp.S
+++ /dev/null
@@ -1,18 +0,0 @@ 
-/* Copyright (C) 2022 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include "../wmemcmp.S"