[PATCHSET,1/4] Fix various issue in TUI
Commit Message
This patch leaves more place on the status line for the process/thread
ID info, so that the probability of chopping it is significantly lower.
OK to commit?
2014-12-31 Eli Zaretskii <eliz@gnu.org>
* tui/tui-data.h (LINE_PREFIX): Make shorter.
(MAX_PID_WIDTH): Leave 5 more characters.
Comments
On 12/31/2014 05:31 PM, Eli Zaretskii wrote:
> This patch leaves more place on the status line for the process/thread
> ID info, so that the probability of chopping it is significantly lower.
>
> OK to commit?
>
> 2014-12-31 Eli Zaretskii <eliz@gnu.org>
>
> * tui/tui-data.h (LINE_PREFIX): Make shorter.
> (MAX_PID_WIDTH): Leave 5 more characters.
OK.
(Please recall to give the commit a more specific subject line
though, rather than having all 4 patches with the same subject.)
> /* Strings to display in the TUI status line. */
> #define PROC_PREFIX "In: "
> -#define LINE_PREFIX "Line: "
> +#define LINE_PREFIX "L"
I have to a admit this one looked a little odd to me,
but I guess it's a matter of habit.
Thanks,
Pedro Alves
> Date: Mon, 05 Jan 2015 19:20:02 +0000
> From: Pedro Alves <palves@redhat.com>
>
> > /* Strings to display in the TUI status line. */
> > #define PROC_PREFIX "In: "
> > -#define LINE_PREFIX "Line: "
> > +#define LINE_PREFIX "L"
>
> I have to a admit this one looked a little odd to me,
> but I guess it's a matter of habit.
Well, Emacs shows "Lnnn", so the habit is already here ;-)
> Date: Mon, 05 Jan 2015 19:20:02 +0000
> From: Pedro Alves <palves@redhat.com>
>
> On 12/31/2014 05:31 PM, Eli Zaretskii wrote:
> > This patch leaves more place on the status line for the process/thread
> > ID info, so that the probability of chopping it is significantly lower.
> >
> > OK to commit?
> >
> > 2014-12-31 Eli Zaretskii <eliz@gnu.org>
> >
> > * tui/tui-data.h (LINE_PREFIX): Make shorter.
> > (MAX_PID_WIDTH): Leave 5 more characters.
>
> OK.
>
> (Please recall to give the commit a more specific subject line
> though, rather than having all 4 patches with the same subject.)
>
> > /* Strings to display in the TUI status line. */
> > #define PROC_PREFIX "In: "
> > -#define LINE_PREFIX "Line: "
> > +#define LINE_PREFIX "L"
>
> I have to a admit this one looked a little odd to me,
> but I guess it's a matter of habit.
Thanks, pushed.
@@ -75,7 +75,7 @@
/* Strings to display in the TUI status line. */
#define PROC_PREFIX "In: "
-#define LINE_PREFIX "Line: "
+#define LINE_PREFIX "L"
#define PC_PREFIX "PC: "
#define SINGLE_KEY "(SingleKey)"
@@ -85,7 +85,7 @@
numbers. */
#define MIN_PROC_WIDTH 12
#define MAX_TARGET_WIDTH 10
-#define MAX_PID_WIDTH 14
+#define MAX_PID_WIDTH 19
#define TUI_FLOAT_REGS_NAME "$FREGS"
#define TUI_FLOAT_REGS_NAME_LOWER "$fregs"