diff mbox series

doc: invoke: RISC-V: Clean up the -mstrict-align wording

Message ID 20220208032033.2357-1-palmer@rivosinc.com
State Deferred, archived
Headers
Series doc: invoke: RISC-V: Clean up the -mstrict-align wording |

Commit Message

Palmer Dabbelt Feb. 8, 2022, 3:20 a.m. UTC 
  The polarity of do/do not was reversed for this option when compored to
the rest of them.  This seems to have been copied from PowerPC, when the
polarity of the arguments in the docs was reversed (presumably to match
the default), but appears to have never made sense on RISC-V.

gcc/ChangeLog

	* doc/invoke.texi (RISC-V -mstrict-align): Re-word the do/do not
	language.

Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
 gcc/doc/invoke.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kito Cheng Feb. 8, 2022, 9:07 a.m. UTC | #1 
LGTM, thanks :)

On Tue, Feb 8, 2022 at 12:30 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> The polarity of do/do not was reversed for this option when compored to
> the rest of them.  This seems to have been copied from PowerPC, when the
> polarity of the arguments in the docs was reversed (presumably to match
> the default), but appears to have never made sense on RISC-V.
>
> gcc/ChangeLog
>
>         * doc/invoke.texi (RISC-V -mstrict-align): Re-word the do/do not
>         language.
>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
>  gcc/doc/invoke.texi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 0ebe538ccdc..5e8af05e359 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -27702,7 +27702,7 @@ integer load/stores only.
>  @item -mstrict-align
>  @itemx -mno-strict-align
>  @opindex mstrict-align
> -Do not or do generate unaligned memory accesses.  The default is set depending
> +Do or do not generate unaligned memory accesses.  The default is set depending
>  on whether the processor we are optimizing for supports fast unaligned access
>  or not.
>
> --
> 2.34.1
>
Andreas Schwab Feb. 8, 2022, 9:25 a.m. UTC | #2 
On Feb 07 2022, Palmer Dabbelt wrote:

> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 0ebe538ccdc..5e8af05e359 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -27702,7 +27702,7 @@ integer load/stores only.
>  @item -mstrict-align
>  @itemx -mno-strict-align
>  @opindex mstrict-align
> -Do not or do generate unaligned memory accesses.  The default is set depending

I think the logic is that -mstrict-align is "do not" and
-mno-strict-align is "do".
Palmer Dabbelt Feb. 10, 2022, 5:22 p.m. UTC | #3 
On Tue, 08 Feb 2022 01:25:01 PST (-0800), schwab@linux-m68k.org wrote:
> On Feb 07 2022, Palmer Dabbelt wrote:
>
>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
>> index 0ebe538ccdc..5e8af05e359 100644
>> --- a/gcc/doc/invoke.texi
>> +++ b/gcc/doc/invoke.texi
>> @@ -27702,7 +27702,7 @@ integer load/stores only.
>>  @item -mstrict-align
>>  @itemx -mno-strict-align
>>  @opindex mstrict-align
>> -Do not or do generate unaligned memory accesses.  The default is set depending
>
> I think the logic is that -mstrict-align is "do not" and
> -mno-strict-align is "do".

Ya, sorry, looks like I wasn't really paying attention in either of 
these.
diff mbox series

Patch

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 0ebe538ccdc..5e8af05e359 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -27702,7 +27702,7 @@  integer load/stores only.
 @item -mstrict-align
 @itemx -mno-strict-align
 @opindex mstrict-align
-Do not or do generate unaligned memory accesses.  The default is set depending
+Do or do not generate unaligned memory accesses.  The default is set depending
 on whether the processor we are optimizing for supports fast unaligned access
 or not.