diff mbox series

Guard tst-valgrind-smoke.out with run-built-tests

Message ID 20220126195737.45163-1-mark@klomp.org
State Committed
Commit af6dc56b8c313cb2fe2df53f92d1bc9d0a820368
Headers
Series Guard tst-valgrind-smoke.out with run-built-tests |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Mark Wielaard Jan. 26, 2022, 7:57 p.m. UTC 
  Prevent tst-valgrind-smoke from running when run-built-tests is not yes.
---
 elf/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Resent as separate PATCH to get it into patchwork.

Comments

Adhemerval Zanella Netto Jan. 26, 2022, 8:08 p.m. UTC | #1 
On 26/01/2022 16:57, Mark Wielaard wrote:
> Prevent tst-valgrind-smoke from running when run-built-tests is not yes.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  elf/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> Resent as separate PATCH to get it into patchwork.
> 
> diff --git a/elf/Makefile b/elf/Makefile
> index daafb5cf12..775c755291 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -530,7 +530,9 @@ endif
>  endif
>  endif
>  
> +ifeq ($(run-built-tests),yes)
>  tests-special += $(objpfx)tst-valgrind-smoke.out
> +endif
>  $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test
>  	$(SHELL) $< $(objpfx)ld.so  $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \
>  		'$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)
Mark Wielaard Jan. 26, 2022, 10:49 p.m. UTC | #2 
Hi,

On Wed, Jan 26, 2022 at 05:08:48PM -0300, Adhemerval Zanella wrote:
> On 26/01/2022 16:57, Mark Wielaard wrote:
> > Prevent tst-valgrind-smoke from running when run-built-tests is not yes.
> 
> LGTM, thanks.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Thanks. The patchwork trybot is also green.

Pushed,

Mark
diff mbox series

Patch

diff --git a/elf/Makefile b/elf/Makefile
index daafb5cf12..775c755291 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -530,7 +530,9 @@  endif
 endif
 endif
 
+ifeq ($(run-built-tests),yes)
 tests-special += $(objpfx)tst-valgrind-smoke.out
+endif
 $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test
 	$(SHELL) $< $(objpfx)ld.so  $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \
 		'$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)