gcc/configure: out of date

  Hello.

I noticed that when I run:
ACLOCAL=~/bin/automake-1.15.1/bin/aclocal  AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf

in gcc subfolder I get the following diff:


Am I correct that somebody forgot to re-generate the file?

Martin
  

On 1/14/22 16:46, Martin Liška wrote:
> Hello.
> 
> I noticed that when I run:
> ACLOCAL=~/bin/automake-1.15.1/bin/aclocal  AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf
> 
> in gcc subfolder I get the following diff:

Have it, started with:


commit 7c6ae994fb587c19ca14aebe18dbc9aca83be609
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Thu Dec 16 23:56:16 2021 +0100

     config: Add check whether D compiler works (PR103528)
     
     As well as checking for the existence of a GDC compiler, also validate
     that it has also been built with libphobos, otherwise warn or fail with
     the message that GDC is required to build d.
     
     config/ChangeLog:
     
             PR d/103528
             * acx.m4 (ACX_PROG_GDC): Add check whether D compiler works.
     
     ChangeLog:
     
             * configure: Regenerate.

I'm going to push the patch I pasted in the previous email.

Martin
  

Excerpts from Martin Liška's message of Januar 14, 2022 4:51 pm:
> On 1/14/22 16:46, Martin Liška wrote:
>> Hello.
>> 
>> I noticed that when I run:
>> ACLOCAL=~/bin/automake-1.15.1/bin/aclocal  AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf
>> 
>> in gcc subfolder I get the following diff:
> 
> Have it, started with:
> 

Good spot! Thanks.

Iain.
  

Martin, I've looked into removing the -Wno-error for this warning
for just a subset of targets.  It seems doable with some hardcoding
in configure.ac but if you're planning to do the cleanup for all of
them I'm wondering if we should even bother.  What do you think?

Martin

On 1/14/22 08:46, Martin Liška wrote:
> Hello.
> 
> I noticed that when I run:
> ACLOCAL=~/bin/automake-1.15.1/bin/aclocal  
> AUTOMAKE=~/bin/automake-1.15.1/bin/automake autoconf
> 
> in gcc subfolder I get the following diff:
> 
> diff --git a/gcc/configure b/gcc/configure
> index d19059e13cc..ff570f73ef5 100755
> --- a/gcc/configure
> +++ b/gcc/configure
> @@ -5352,7 +5352,26 @@ else
>     GDC="$ac_cv_prog_GDC"
>   fi
> 
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether the D 
> compiler works" >&5
> +$as_echo_n "checking whether the D compiler works... " >&6; }
> +if ${acx_cv_d_compiler_works+:} false; then :
> +  $as_echo_n "(cached) " >&6
> +else
> +  cat >conftest.d <<EOF
> +module conftest; int main() { return 0; }
> +EOF
> +acx_cv_d_compiler_works=no
>   if test "x$GDC" != xno; then
> +  errors=`(${GDC} -I"$srcdir"/d -c conftest.d) 2>&1 || echo failure`
> +  if test x"$errors" = x && test -f conftest.$ac_objext; then
> +    acx_cv_d_compiler_works=yes
> +  fi
> +  rm -f conftest.*
> +fi
> +fi
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: 
> $acx_cv_d_compiler_works" >&5
> +$as_echo "$acx_cv_d_compiler_works" >&6; }
> +if test "x$GDC" != xno && test x$acx_cv_d_compiler_works != xno; then
>     have_gdc=yes
>   else
>     have_gdc=no
> @@ -19640,7 +19659,7 @@ else
>     lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
>     lt_status=$lt_dlunknown
>     cat > conftest.$ac_ext <<_LT_EOF
> -#line 19643 "configure"
> +#line 19662 "configure"
>   #include "confdefs.h"
> 
>   #if HAVE_DLFCN_H
> @@ -19746,7 +19765,7 @@ else
>     lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
>     lt_status=$lt_dlunknown
>     cat > conftest.$ac_ext <<_LT_EOF
> -#line 19749 "configure"
> +#line 19768 "configure"
>   #include "confdefs.h"
> 
>   #if HAVE_DLFCN_H
> 
> Am I correct that somebody forgot to re-generate the file?
> 
> Martin
  

On 1/16/22 01:31, Martin Sebor wrote:

Hello.

(I think your message in unrelated to this email thread).

> Martin, I've looked into removing the -Wno-error for this warning
> for just a subset of targets.  It seems doable with some hardcoding
> in configure.ac but if you're planning to do the cleanup for all of
> them I'm wondering if we should even bother.  What do you think?

Yes, I've just installed patches that should address all -Wformat-diag errors
for all targets we have.

Please enable the corresponding -Werror for bootstrap.

Thanks,
Martin

> 
> Martin
  

On 1/18/22 17:28, Martin Liška wrote:
> On 1/16/22 01:31, Martin Sebor wrote:
> 
> Hello.
> 
> (I think your message in unrelated to this email thread).
> 
>> Martin, I've looked into removing the -Wno-error for this warning
>> for just a subset of targets.  It seems doable with some hardcoding
>> in configure.ac but if you're planning to do the cleanup for all of
>> them I'm wondering if we should even bother.  What do you think?
> 
> Yes, I've just installed patches that should address all -Wformat-diag errors
> for all targets we have.
> 
> Please enable the corresponding -Werror for bootstrap.

I've got a patch that enables that. Right now, there should not be any -Wformat-diag
in any target. Thus I'm going to install the following patch.

Martin

> 
> Thanks,
> Martin
> 
>>
>> Martin
>