diff mbox series

Missing audit17 test

Message ID 20220115154522.33x4yyfklglvzsng@begin
State Superseded
Headers
Series Missing audit17 test |

Checks

Context Check Description
dj/TryBot-apply_patch fail Patch failed to apply to master at the time it was sent
dj/TryBot-32bit fail Patch series failed to apply

Commit Message

Samuel Thibault Jan. 15, 2022, 3:45 p.m. UTC 
  Hello,

9926f6e2eeb3 ("elf: Skip tst-auditlogmod-* if the linker doesn't support
--depaudit [BZ #28 151]") happened to be dropping tst-audit17:


was that expected?

Samuel

Comments

Adhemerval Zanella Netto Jan. 17, 2022, 6:13 p.m. UTC | #1 
On 15/01/2022 12:45, Samuel Thibault via Libc-alpha wrote:
> Hello,
> 
> 9926f6e2eeb3 ("elf: Skip tst-auditlogmod-* if the linker doesn't support
> --depaudit [BZ #28 151]") happened to be dropping tst-audit17:

Good catch, I will reinstate it.

> 
> diff --git a/elf/Makefile b/elf/Makefile
> index 725537c40b..9f3fadc37e 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -219,7 +219,6 @@ tests += restest1 preloadtest loadfail multiload origtest resolvfail \
>          tst-dlopen-self tst-auditmany tst-initfinilazyfail tst-dlopenfail \
>          tst-dlopenfail-2 \
>          tst-filterobj tst-filterobj-dlopen tst-auxobj tst-auxobj-dlopen \
> -        tst-audit14 tst-audit15 tst-audit16 tst-audit17 \
>          tst-single_threaded tst-single_threaded-pthread \
>          tst-tls-ie tst-tls-ie-dlmopen argv0test \
>          tst-glibc-hwcaps tst-glibc-hwcaps-prepend tst-glibc-hwcaps-mask \
> @@ -238,6 +237,9 @@ selinux-enabled := $(shell cat /selinux/enforce 2> /dev/null)
>  ifneq ($(selinux-enabled),1)
>  tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog
>  endif
> +ifeq ($(have-depaudit),yes)
> +tests += tst-audit14 tst-audit15 tst-audit16
> +endif
>  endif
>  tests += $(tests-execstack-$(have-z-execstack))
>  ifeq ($(run-built-tests),yes)
> 
> was that expected?
> 
> Samuel
diff mbox series

Patch

diff --git a/elf/Makefile b/elf/Makefile
index 725537c40b..9f3fadc37e 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -219,7 +219,6 @@  tests += restest1 preloadtest loadfail multiload origtest resolvfail \
         tst-dlopen-self tst-auditmany tst-initfinilazyfail tst-dlopenfail \
         tst-dlopenfail-2 \
         tst-filterobj tst-filterobj-dlopen tst-auxobj tst-auxobj-dlopen \
-        tst-audit14 tst-audit15 tst-audit16 tst-audit17 \
         tst-single_threaded tst-single_threaded-pthread \
         tst-tls-ie tst-tls-ie-dlmopen argv0test \
         tst-glibc-hwcaps tst-glibc-hwcaps-prepend tst-glibc-hwcaps-mask \
@@ -238,6 +237,9 @@  selinux-enabled := $(shell cat /selinux/enforce 2> /dev/null)
 ifneq ($(selinux-enabled),1)
 tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog
 endif
+ifeq ($(have-depaudit),yes)
+tests += tst-audit14 tst-audit15 tst-audit16
+endif
 endif
 tests += $(tests-execstack-$(have-z-execstack))
 ifeq ($(run-built-tests),yes)