Message ID | cover.1642179009.git.fweimer@redhat.com |
---|---|
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E236F3836015 for <patchwork@sourceware.org>; Fri, 14 Jan 2022 16:52:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E236F3836015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1642179146; bh=T7IGgx5pnqVU33HTZFfKB93RK98Ww/yEur4ZWubeREo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Y1VHijYKnrCVHekwp/rcFbMqyRYoR69fO5hYEv8B32BmkQrDoDICByBlm3OIN8yfT nCl5hir95Qt+7qLsL0nf7swJu+ZcWUEufSd3tVXRJghQRokOhrFu7E9KCfx+/z/hPH L5UQ+0eCUx0v1YKzT1U38uFrXGxtER3R1BALBCuE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6ED033858C39 for <libc-alpha@sourceware.org>; Fri, 14 Jan 2022 16:52:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6ED033858C39 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-323-Nd-PQeBbNdSaapzkw7HVJw-1; Fri, 14 Jan 2022 11:51:52 -0500 X-MC-Unique: Nd-PQeBbNdSaapzkw7HVJw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6764483DD29; Fri, 14 Jan 2022 16:51:51 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E8587DE20; Fri, 14 Jan 2022 16:51:50 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH v2 0/6] Reliable CPU compatibility diagnostics in ld.so X-From-Line: 07f71c2a57d045f20aebc2217a7f7f635785e5f6 Mon Sep 17 00:00:00 2001 Message-Id: <cover.1642179009.git.fweimer@redhat.com> Date: Fri, 14 Jan 2022 17:51:48 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Florian Weimer <fweimer@redhat.com> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Reliable CPU compatibility diagnostics in ld.so
|
|
Message
Florian Weimer
Jan. 14, 2022, 4:51 p.m. UTC
v2: Rebased after the first two patches went. New first patch to reflow elf/Makefile. configure option has been renamed. Florian Weimer (6): elf/Makefile: Reflow and sort most variable assignments elf: Split dl-printf.c from dl-misc.c Add --with-rtld-early-cflags configure option powerpc64le: Use <gcc-macros.h> in early HWCAP check x86: Add x86-64-vN check to early startup s390x: Use <gcc-macros.h> in early HWCAP check INSTALL | 8 + config.make.in | 1 + configure | 13 + configure.ac | 6 + elf/Makefile | 429 +++++++++++++----- elf/dl-misc.c | 281 +----------- elf/dl-printf.c | 292 ++++++++++++ manual/install.texi | 7 + sysdeps/powerpc/powerpc64/le/dl-hwcap-check.h | 9 +- sysdeps/s390/s390-64/dl-hwcap-check.h | 5 +- sysdeps/x86/Makefile | 1 + sysdeps/x86/dl-get-cpu-features.c | 31 +- 12 files changed, 697 insertions(+), 386 deletions(-) create mode 100644 elf/dl-printf.c base-commit: ef7c6d42fe163a5e49a478c43e655ce4633fa5ba
Comments
I think there should be a NEWS entry for the new feature and configure option.
* Joseph Myers: > I think there should be a NEWS entry for the new feature and configure > option. Fair enough. I'm going to add: * A new configure option, --with-rtld-early-cflags, can be used to specify additional compiler flags for building the early startup code of the dynamic linker. On targets which have CPU compatibility checks, this can help to ensure that proper diagnostics are printed if the dynamic loader runs on an incompatible CPU. Thanks, Florian
On 1/14/22 12:59, Florian Weimer via Libc-alpha wrote: > * Joseph Myers: > >> I think there should be a NEWS entry for the new feature and configure >> option. > > Fair enough. I'm going to add: > > * A new configure option, --with-rtld-early-cflags, can be used to > specify additional compiler flags for building the early startup code > of the dynamic linker. On targets which have CPU compatibility > checks, this can help to ensure that proper diagnostics are printed if > the dynamic loader runs on an incompatible CPU. LGTM. Reviewed-by: Carlos O'Donell <carlos@redhat.com>