timezone: Fix tst-bz28707 Makefile rule
Checks
Context |
Check |
Description |
dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
dj/TryBot-32bit |
success
|
Build for i686
|
Commit Message
The $(testdata)/XT5 rule is ambiguous and it may not be correct
evaluated.
---
timezone/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
I am seeing make check completion failure without this issue and I
will install this shortly if no one opposes it.
On 10/01/2022 10:18, Adhemerval Zanella wrote:
> The $(testdata)/XT5 rule is ambiguous and it may not be correct
> evaluated.
> ---
> timezone/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/timezone/Makefile b/timezone/Makefile
> index 4e7f68a8fc..a789c22d26 100644
> --- a/timezone/Makefile
> +++ b/timezone/Makefile
> @@ -124,7 +124,8 @@ $(testdata)/XT%: testdata/XT%
> $(make-target-directory)
> cp $< $@
>
> -$(testdata)/XT%: testdata/gen-XT%.sh
> +$(testdata)/XT5: testdata/gen-XT5.sh
> + $(make-target-directory)
> $(SHELL) $< > $@.tmp
> mv $@.tmp $@
>
* Adhemerval Zanella via Libc-alpha:
> I am seeing make check completion failure without this issue and I
> will install this shortly if no one opposes it.
Yes, please check it in.
Thanks,
Florian
@@ -124,7 +124,8 @@ $(testdata)/XT%: testdata/XT%
$(make-target-directory)
cp $< $@
-$(testdata)/XT%: testdata/gen-XT%.sh
+$(testdata)/XT5: testdata/gen-XT5.sh
+ $(make-target-directory)
$(SHELL) $< > $@.tmp
mv $@.tmp $@