Message ID | 20211216015254.3940981-1-siddhesh@sourceware.org |
---|---|
State | Committed |
Commit | ae23fa3e5fe24daf94fc7f8e5268bb8ceeda7477 |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EF66B3858413 for <patchwork@sourceware.org>; Thu, 16 Dec 2021 01:53:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF66B3858413 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639619606; bh=9TOLddvfWeU5/HdGtR34QzGbLtpzkLZ4jH5GWCPM5nI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=fNFJsQu8tCf1wpCS5Ado60GrEDX9sW/h7vGtXvE9Mp13PhSN6pNUoNYvkuNOd7zx1 MlRFqKS3BcokSZDBzKBuLiL/6AnzaPlqTdB5V9/eVX2N5WW9CiozzKpygZpB+a3EiA dFUH5oCy6miZqQ4maa4OCe7guHo2SHAtszbgJENo= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from bird.elm.relay.mailchannels.net (bird.elm.relay.mailchannels.net [23.83.212.17]) by sourceware.org (Postfix) with ESMTPS id 4ABC13858D28 for <libc-alpha@sourceware.org>; Thu, 16 Dec 2021 01:53:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4ABC13858D28 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 14CDD622EA1 for <libc-alpha@sourceware.org>; Thu, 16 Dec 2021 01:53:03 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id AD32F622DD0 for <libc-alpha@sourceware.org>; Thu, 16 Dec 2021 01:53:02 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.100.11.82 (trex/6.4.3); Thu, 16 Dec 2021 01:53:03 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Soft-Skirt: 0bf9599d2f1e90f5_1639619582952_1717734322 X-MC-Loop-Signature: 1639619582952:1599712443 X-MC-Ingress-Time: 1639619582952 Received: from rhbox.. (unknown [223.185.62.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4JDw9m6gd6z1M for <libc-alpha@sourceware.org>; Wed, 15 Dec 2021 17:53:00 -0800 (PST) To: libc-alpha@sourceware.org Subject: [committed] __glibc_unsafe_len: Fix comment Date: Thu, 16 Dec 2021 07:22:54 +0530 Message-Id: <20211216015254.3940981-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1167.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Siddhesh Poyarekar <siddhesh@sourceware.org> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
[committed] __glibc_unsafe_len: Fix comment
|
|
Commit Message
Siddhesh Poyarekar
Dec. 16, 2021, 1:52 a.m. UTC
We know that the length is *unsafe*.
Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
---
misc/sys/cdefs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 15/12/2021 22:52, Siddhesh Poyarekar via Libc-alpha wrote: > We know that the length is *unsafe*. > > Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org> Seems obvious enough. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > misc/sys/cdefs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h > index ab57d4a065..a05b538579 100644 > --- a/misc/sys/cdefs.h > +++ b/misc/sys/cdefs.h > @@ -169,7 +169,7 @@ > __s, __osz)) \ > && __glibc_safe_len_cond ((__SIZE_TYPE__) (__l), __s, __osz)) > > -/* Conversely, we know at compile time that the length is safe if the > +/* Conversely, we know at compile time that the length is unsafe if the > __L * __S <= __OBJSZ condition can be folded to a constant and if it is > false. */ > #define __glibc_unsafe_len(__l, __s, __osz) \
On 12/16/21 15:54, Adhemerval Zanella via Libc-alpha wrote: > > > On 15/12/2021 22:52, Siddhesh Poyarekar via Libc-alpha wrote: >> We know that the length is *unsafe*. >> >> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org> > > Seems obvious enough. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Oh I already committed that one as obvious, could you please review this one: https://patchwork.sourceware.org/project/glibc/patch/20211216014731.3939905-1-siddhesh@sourceware.org/ Thanks, Siddhesh
On 16/12/2021 07:44, Siddhesh Poyarekar wrote: > On 12/16/21 15:54, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 15/12/2021 22:52, Siddhesh Poyarekar via Libc-alpha wrote: >>> We know that the length is *unsafe*. >>> >>> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org> >> >> Seems obvious enough. >> >> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > > Oh I already committed that one as obvious, could you please review this one: Oops I did not see the 'committed' title. > > https://patchwork.sourceware.org/project/glibc/patch/20211216014731.3939905-1-siddhesh@sourceware.org/ > Sure. > Thanks, > Siddhesh
diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h index ab57d4a065..a05b538579 100644 --- a/misc/sys/cdefs.h +++ b/misc/sys/cdefs.h @@ -169,7 +169,7 @@ __s, __osz)) \ && __glibc_safe_len_cond ((__SIZE_TYPE__) (__l), __s, __osz)) -/* Conversely, we know at compile time that the length is safe if the +/* Conversely, we know at compile time that the length is unsafe if the __L * __S <= __OBJSZ condition can be folded to a constant and if it is false. */ #define __glibc_unsafe_len(__l, __s, __osz) \