diff mbox series

[4/4] Mark IFN_ADD/MUL_OVERFLOW as commutative

Message ID mpt5yt0uqda.fsf@arm.com
State Committed
Headers
Series [1/4] Canonicalize argument order for commutative functions |

Commit Message

Richard Sandiford Nov. 10, 2021, 12:50 p.m. UTC 
  Mark IFN_ADD/MUL_OVERFLOW as commutative.

Tested on aarch64-linux-gnu and x86_64-linux-gnu.  OK to install?

Richard


gcc/
	* internal-fn.c (first_commutative_operand): Handle IFN_ADD_OVERFLOW
	and IFN_MUL_OVERFLOW.

gcc/testsuite/
	* gcc.dg/add-mul-overflow-1.c: New test.
---
 gcc/internal-fn.c                         |  2 ++
 gcc/testsuite/gcc.dg/add-mul-overflow-1.c | 28 +++++++++++++++++++++++
 2 files changed, 30 insertions(+)
 create mode 100644 gcc/testsuite/gcc.dg/add-mul-overflow-1.c

Comments

Jakub Jelinek Nov. 10, 2021, 12:57 p.m. UTC | #1 
On Wed, Nov 10, 2021 at 12:50:09PM +0000, Richard Sandiford via Gcc-patches wrote:
> gcc/
> 	* internal-fn.c (first_commutative_operand): Handle IFN_ADD_OVERFLOW
> 	and IFN_MUL_OVERFLOW.
> 
> gcc/testsuite/
> 	* gcc.dg/add-mul-overflow-1.c: New test.

Ok.

	Jakub
diff mbox series

Patch

diff --git a/gcc/internal-fn.c b/gcc/internal-fn.c
index b64555ada36..10f08182f7e 100644
--- a/gcc/internal-fn.c
+++ b/gcc/internal-fn.c
@@ -3867,6 +3867,8 @@  first_commutative_argument (internal_fn fn)
     case IFN_FMS:
     case IFN_FNMA:
     case IFN_FNMS:
+    case IFN_ADD_OVERFLOW:
+    case IFN_MUL_OVERFLOW:
       return 0;
 
     case IFN_COND_ADD:
diff --git a/gcc/testsuite/gcc.dg/add-mul-overflow-1.c b/gcc/testsuite/gcc.dg/add-mul-overflow-1.c
new file mode 100644
index 00000000000..b23cdddbb63
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/add-mul-overflow-1.c
@@ -0,0 +1,28 @@ 
+/* { dg-options "-O -fdump-tree-optimized" } */
+
+int res[4];
+
+void
+f1 (int x, int y)
+{
+  res[2] = __builtin_add_overflow (x, y, res + 0);
+  res[3] = __builtin_add_overflow (y, x, res + 1);
+}
+
+void
+f2 (int x, int y)
+{
+  res[2] = __builtin_sub_overflow (x, y, res + 0);
+  res[3] = __builtin_sub_overflow (y, x, res + 1);
+}
+
+void
+f3 (int x, int y)
+{
+  res[2] = __builtin_mul_overflow (x, y, res + 0);
+  res[3] = __builtin_mul_overflow (y, x, res + 1);
+}
+
+/* { dg-final { scan-tree-dump-times {\.ADD_OVERFLOW} 1 "optimized" } } */
+/* { dg-final { scan-tree-dump-times {\.SUB_OVERFLOW} 2 "optimized" } } */
+/* { dg-final { scan-tree-dump-times {\.MUL_OVERFLOW} 1 "optimized" } } */